From 11ed366c487a938815cd52ad2ab5467b0f90e1ae Mon Sep 17 00:00:00 2001 From: mbonadei Date: Mon, 24 Apr 2017 12:26:27 -0700 Subject: Revert of Enable GN check for webrtc/base (patchset #13 id:240001 of https://codereview.webrtc.org/2717083002/ ) Reason for revert: Breaks Chromium because in Chromium we import WebRTC with rtc_include_tests=false (https://bugs.chromium.org/p/chromium/issues/detail?id=713179#c6). Chromium uses webrtc/test/fuzzers and this CL adds test dependencies to neteq_rtc_fuzzer. Original issue's description: > Enable GN check for webrtc/base > > It's not possible to enable it for the rtc_base_approved > target but since a larger refactoring is ongoing for webrtc/base > this CL doesn't attempt to fix that. > > Changes made: > * Move webrtc/system_wrappers/include/stringize_macros.h into > webrtc/base:rtc_base_approved_unittests (and corresponding > unit test to rtc_base_approved_unittests). > * Move md5digest.* from rtc_base_approved to rtc_base_test_utils target. > * Move webrtc/system_wrappers/include/stringize_macros.h (+test) into > webrtc/base. > * Remove unused use include of webrtc/base/fileutils.h in > webrtc/base/pathutils.cc > > BUG=webrtc:6828, webrtc:3806, webrtc:7480 > NOTRY=True > > Review-Url: https://codereview.webrtc.org/2717083002 > Cr-Commit-Position: refs/heads/master@{#17766} > Committed: https://chromium.googlesource.com/external/webrtc/+/ed754e71ae8866db641677073274e86fe704eeac TBR=perkj@webrtc.org,tommi@webrtc.org,nisse@webrtc.org,kjellander@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6828, webrtc:3806, webrtc:7480 NOTRY=True Review-Url: https://codereview.webrtc.org/2838683002 Cr-Commit-Position: refs/heads/master@{#17849} --- .gn | 1 - 1 file changed, 1 deletion(-) (limited to '.gn') diff --git a/.gn b/.gn index 585ff30842..f8a113af18 100644 --- a/.gn +++ b/.gn @@ -24,7 +24,6 @@ secondary_source = "//build/secondary/" check_targets = [ "//webrtc/api/*", "//webrtc/audio/*", - "//webrtc/base/*", "//webrtc/call/*", "//webrtc/common_video/*", "//webrtc/common_audio/*", -- cgit v1.2.3