From 8d684732cc0305fe8fabe621b319ebe3bd42fc59 Mon Sep 17 00:00:00 2001 From: Mirko Bonadei Date: Tue, 15 Oct 2019 21:25:07 +0200 Subject: Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true." This is a reland of 03bc15c646d5b41d3169f2686316944788f640ed I will revert this reland as soon as it lands because I just need to have a WebRTC commit to pin in Chromium in order to test the component build (this CL enables symbol exports). Original change's description: > Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true. > > In order to land the component build support in Chromium, it is > easier to turn on symbols export every time that is_component_build=true > instead of setting rtc_enable_symbol_export=is_component_build in > Chromium (since is_component_build is not available in .gn). > > rtc_enable_symbol_export is still kept in the mix in order to turn > on symbol exports in any case a shared library will be added to the > WebRTC build. > > Bug: webrtc:9419 > Change-Id: I5a7195826dea13d9a6f10a1160c35f2864bfa6c2 > Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157108 > Reviewed-by: Karl Wiberg > Commit-Queue: Mirko Bonadei > Cr-Commit-Position: refs/heads/master@{#29540} TBR: kwiberg@webrtc.org No-Try: True Bug: webrtc:9419 Change-Id: Id247243d8464062051e050e406b8b84ee1355a58 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/159036 Commit-Queue: Mirko Bonadei Reviewed-by: Mirko Bonadei Cr-Commit-Position: refs/heads/master@{#29734} --- BUILD.gn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'BUILD.gn') diff --git a/BUILD.gn b/BUILD.gn index 73569c5a09..98ff6a039d 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -111,7 +111,7 @@ config("common_inherited_config") { cflags = [] ldflags = [] - if (rtc_enable_symbol_export) { + if (rtc_enable_symbol_export || is_component_build) { defines = [ "WEBRTC_ENABLE_SYMBOL_EXPORT" ] } -- cgit v1.2.3