From 86d053c2db6ed25e4854c307d563999298dda2e5 Mon Sep 17 00:00:00 2001 From: Mirko Bonadei Date: Thu, 17 Oct 2019 21:32:04 +0200 Subject: Use source_sets in component builds and static_library in release builds. Static libraries don't guarantee that an exported symbol gets linked into a shared library (and in order to support Chromium's component build mode, WebRTC needs to be linked as a shared library). Source sets always pass all the object files to the linker. On the flip side, source_sets link more object files in release builds and to avoid this, this CL introduces a the GN template "rtc_library" that expands to static_library during release builds and to source_set during component builds. See: https://gn.googlesource.com/gn/+/master/docs/reference.md#func_source_set Bug: webrtc:9419 Change-Id: I4667e820c2b3fcec417becbd2034acc13e4f04fe Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/157168 Commit-Queue: Mirko Bonadei Reviewed-by: Karl Wiberg Reviewed-by: Nico Weber Cr-Commit-Position: refs/heads/master@{#29525} --- api/audio_codecs/test/BUILD.gn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'api/audio_codecs/test') diff --git a/api/audio_codecs/test/BUILD.gn b/api/audio_codecs/test/BUILD.gn index 61234f5539..575f062ce7 100644 --- a/api/audio_codecs/test/BUILD.gn +++ b/api/audio_codecs/test/BUILD.gn @@ -13,7 +13,7 @@ if (is_android) { } if (rtc_include_tests) { - rtc_source_set("audio_codecs_api_unittests") { + rtc_library("audio_codecs_api_unittests") { testonly = true sources = [ "audio_decoder_factory_template_unittest.cc", -- cgit v1.2.3