From 688e308a353c27803a66803230235638f4dd1f2b Mon Sep 17 00:00:00 2001 From: aluebs Date: Thu, 14 Jan 2016 04:32:46 -0800 Subject: Re-land: "Use an explicit identifier in Config" This let's us use them to configure them when using WebRTC as an external library. One use case where this is necessary is in the Android OS. Original CL: https://codereview.webrtc.org/1538643004/ TBR=tommi@webrtc.org Review URL: https://codereview.webrtc.org/1589573004 Cr-Commit-Position: refs/heads/master@{#11248} --- webrtc/modules/audio_processing/include/audio_processing.h | 6 ++++++ webrtc/modules/video_coding/codecs/vp8/temporal_layers.h | 3 +++ 2 files changed, 9 insertions(+) (limited to 'webrtc/modules') diff --git a/webrtc/modules/audio_processing/include/audio_processing.h b/webrtc/modules/audio_processing/include/audio_processing.h index 5dd63ebc30..9a3a4b32d5 100644 --- a/webrtc/modules/audio_processing/include/audio_processing.h +++ b/webrtc/modules/audio_processing/include/audio_processing.h @@ -65,6 +65,7 @@ class VoiceDetection; struct ExtendedFilter { ExtendedFilter() : enabled(false) {} explicit ExtendedFilter(bool enabled) : enabled(enabled) {} + static const ConfigOptionID identifier = ConfigOptionID::kExtendedFilter; bool enabled; }; @@ -76,6 +77,7 @@ struct ExtendedFilter { struct DelayAgnostic { DelayAgnostic() : enabled(false) {} explicit DelayAgnostic(bool enabled) : enabled(enabled) {} + static const ConfigOptionID identifier = ConfigOptionID::kDelayAgnostic; bool enabled; }; @@ -96,6 +98,7 @@ struct ExperimentalAgc { : enabled(enabled), startup_min_volume(kAgcStartupMinVolume) {} ExperimentalAgc(bool enabled, int startup_min_volume) : enabled(enabled), startup_min_volume(startup_min_volume) {} + static const ConfigOptionID identifier = ConfigOptionID::kExperimentalAgc; bool enabled; int startup_min_volume; }; @@ -105,6 +108,7 @@ struct ExperimentalAgc { struct ExperimentalNs { ExperimentalNs() : enabled(false) {} explicit ExperimentalNs(bool enabled) : enabled(enabled) {} + static const ConfigOptionID identifier = ConfigOptionID::kExperimentalNs; bool enabled; }; @@ -127,6 +131,7 @@ struct Beamforming { : enabled(enabled), array_geometry(array_geometry), target_direction(target_direction) {} + static const ConfigOptionID identifier = ConfigOptionID::kBeamforming; const bool enabled; const std::vector array_geometry; const SphericalPointf target_direction; @@ -141,6 +146,7 @@ struct Beamforming { struct Intelligibility { Intelligibility() : enabled(false) {} explicit Intelligibility(bool enabled) : enabled(enabled) {} + static const ConfigOptionID identifier = ConfigOptionID::kIntelligibility; bool enabled; }; diff --git a/webrtc/modules/video_coding/codecs/vp8/temporal_layers.h b/webrtc/modules/video_coding/codecs/vp8/temporal_layers.h index 7fe03a4da8..47112c64aa 100644 --- a/webrtc/modules/video_coding/codecs/vp8/temporal_layers.h +++ b/webrtc/modules/video_coding/codecs/vp8/temporal_layers.h @@ -14,6 +14,7 @@ #include "vpx/vpx_encoder.h" +#include "webrtc/common.h" #include "webrtc/common_video/include/video_image.h" #include "webrtc/typedefs.h" @@ -30,6 +31,8 @@ class TemporalLayers { virtual ~Factory() {} virtual TemporalLayers* Create(int temporal_layers, uint8_t initial_tl0_pic_idx) const; + static const ConfigOptionID identifier = + ConfigOptionID::kTemporalLayersFactory; }; virtual ~TemporalLayers() {} -- cgit v1.2.3