diff options
| author | Christian O. Andersson <cricke@chromium.org> | 2019-02-22 19:22:24 +0000 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-02-22 19:22:24 +0000 |
| commit | dd652fd9bbe92f99d2b6e5b524430e80fd22880f (patch) | |
| tree | 9443bf8d35b53f80f7c3c2fbe3bfc0880ce764e2 /src/org | |
| parent | bfaef85a184707a4992e1a8e952a63dfb99c7f76 (diff) | |
| download | webview_support_interfaces-dd652fd9bbe92f99d2b6e5b524430e80fd22880f.tar.gz | |
Replaced 'Should' with 'Will' per Android API council guidance
See https://crrev.com/c/1185001 for details
Design doc: https://docs.google.com/document/d/188BbgvTdhKf8bXikCL-JMduEclJOd9GxhKu79hmSVdo/edit
Test: run_webview_instrumentation_test_apk -f AwSettingsTest#testWillSuppressErrorPage
Change-Id: I71603bf906b58c9c42cb06ecf1abcee10360d5cb
Reviewed-on: https://chromium-review.googlesource.com/c/1482900
Auto-Submit: Christian O. Andersson <cricke@chromium.org>
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#634775}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: e17c03864c35247885ce6435d864f8a2a6668702
Diffstat (limited to 'src/org')
| -rw-r--r-- | src/org/chromium/support_lib_boundary/WebSettingsBoundaryInterface.java | 4 | ||||
| -rw-r--r-- | src/org/chromium/support_lib_boundary/util/Features.java | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/src/org/chromium/support_lib_boundary/WebSettingsBoundaryInterface.java b/src/org/chromium/support_lib_boundary/WebSettingsBoundaryInterface.java index b198e33..338fc32 100644 --- a/src/org/chromium/support_lib_boundary/WebSettingsBoundaryInterface.java +++ b/src/org/chromium/support_lib_boundary/WebSettingsBoundaryInterface.java @@ -21,6 +21,6 @@ public interface WebSettingsBoundaryInterface { void setDisabledActionModeMenuItems(int menuItems); int getDisabledActionModeMenuItems(); - void setShouldSuppressErrorPage(boolean suppressed); - boolean getShouldSuppressErrorPage(); + void setWillSuppressErrorPage(boolean suppressed); + boolean getWillSuppressErrorPage(); } diff --git a/src/org/chromium/support_lib_boundary/util/Features.java b/src/org/chromium/support_lib_boundary/util/Features.java index c2faf74..fbf0625 100644 --- a/src/org/chromium/support_lib_boundary/util/Features.java +++ b/src/org/chromium/support_lib_boundary/util/Features.java @@ -132,8 +132,8 @@ public class Features { // ProxyController.clearProxyOverride public static final String PROXY_OVERRIDE = "PROXY_OVERRIDE:3"; - // WebSettingsCompat.setShouldSuppressErrorPage - // WebSettingsCompat.getShouldSuppressErrorPage + // WebSettingsCompat.setWillSuppressErrorPage + // WebSettingsCompat.getWillSuppressErrorPage public static final String SUPPRESS_ERROR_PAGE = "SUPPRESS_ERROR_PAGE"; // WebViewCompat.getWebViewRenderer |