From 79460ff276a42da9bfefbf14ee5954e5ea94b2ca Mon Sep 17 00:00:00 2001 From: hamzeh Date: Thu, 23 Jun 2022 18:26:18 -0700 Subject: Modify xmp_toolkit library to make it host supported Test: m xmp_toolkit Change-Id: Ida90be0dda6c4f8c95bc2c2e73cb6e3b1042d80a --- XMPCore/Android.bp | 1 + 1 file changed, 1 insertion(+) diff --git a/XMPCore/Android.bp b/XMPCore/Android.bp index 4a6bc57..c432274 100644 --- a/XMPCore/Android.bp +++ b/XMPCore/Android.bp @@ -17,6 +17,7 @@ license { java_library { name: "xmp_toolkit", + host_supported: true, // Include all the java files. srcs: ["src/**/*.java"], sdk_version: "current", -- cgit v1.2.3 From 30349d685a028f1faf02dfcba07239eefc51cb0d Mon Sep 17 00:00:00 2001 From: Cole Faust Date: Sat, 15 Oct 2022 21:33:29 -0700 Subject: Fix errorprone warnings that should be errors This commit is part of a large scale change to fix errorprone errors that have been downgraded to warnings in the android source tree, so that they can be promoted to errors again. The full list of changes include the following, but not all will be present in any one individual commit: BadAnnotationImplementation BadShiftAmount BanJNDI BoxedPrimitiveEquality ComparableType ComplexBooleanConstant CollectionToArraySafeParameter ConditionalExpressionNumericPromotion DangerousLiteralNull DoubleBraceInitialization DurationFrom DurationTemporalUnit EmptyTopLevelDeclaration EqualsNull EqualsReference FormatString FromTemporalAccessor GetClassOnAnnotation GetClassOnClass HashtableContains IdentityBinaryExpression IdentityHashMapBoxing InstantTemporalUnit InvalidTimeZoneID InvalidZoneId IsInstanceIncompatibleType JUnitParameterMethodNotFound LockOnBoxedPrimitive MathRoundIntLong MislabeledAndroidString MisusedDayOfYear MissingSuperCall MisusedWeekYear ModifyingCollectionWithItself NoCanIgnoreReturnValueOnClasses NonRuntimeAnnotation NullableOnContainingClass NullTernary OverridesJavaxInjectableMethod ParcelableCreator PeriodFrom PreconditionsInvalidPlaceholder ProtoBuilderReturnValueIgnored ProtoFieldNullComparison RandomModInteger RectIntersectReturnValueIgnored ReturnValueIgnored SelfAssignment SelfComparison SelfEquals SizeGreaterThanOrEqualsZero StringBuilderInitWithChar TreeToString TryFailThrowable UnnecessaryCheckNotNull UnusedCollectionModifiedInPlace XorPower See https://errorprone.info/bugpatterns for more information on the checks. Bug: 253827323 Test: m RUN_ERROR_PRONE=true javac-check Change-Id: I68a369c8e5393820b72e3e10b0e001de514cf7e8 --- XMPCore/Android.bp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/XMPCore/Android.bp b/XMPCore/Android.bp index c432274..a704dcb 100644 --- a/XMPCore/Android.bp +++ b/XMPCore/Android.bp @@ -21,4 +21,9 @@ java_library { // Include all the java files. srcs: ["src/**/*.java"], sdk_version: "current", + errorprone: { + javacflags: [ + "-Xep:ComparableType:WARN", + ], + }, } -- cgit v1.2.3