diff options
| author | Lei Zhang <thestig@chromium.org> | 2022-03-21 19:44:06 +0000 |
|---|---|---|
| committer | Copybara-Service <copybara-worker@google.com> | 2022-03-21 12:59:40 -0700 |
| commit | 16b8c02648faf08794ed0048c0fb1427909e9a46 (patch) | |
| tree | acef6506d1be1c9e8df59d76a389efd1f343ef75 | |
| parent | 8b4114dfa1faa320faae92a354f84883f88b46bc (diff) | |
| download | zlib-16b8c02648faf08794ed0048c0fb1427909e9a46.tar.gz | |
Avoid including base/files/file_util.h in some headers.
Rarely would anyone ever use base/files/file_util.h functions inside a
header. Most code authors meant to include base/files/file_path.h or
forward declare base::FilePath. Do that and then add missing file_util.h
includes to fix the build.
Bug: 242216
Change-Id: I6280125f310cff0db1109c401d84e01aba386376
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3518311
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Owners-Override: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#983450}
NOKEYCHECK=True
GitOrigin-RevId: 527964a214baed4f325c0d7751bfc527ba10bf34
| -rw-r--r-- | google/zip_reader.cc | 1 | ||||
| -rw-r--r-- | google/zip_reader.h | 1 |
2 files changed, 1 insertions, 1 deletions
diff --git a/google/zip_reader.cc b/google/zip_reader.cc index 93fe134..b8143cd 100644 --- a/google/zip_reader.cc +++ b/google/zip_reader.cc @@ -10,6 +10,7 @@ #include "base/bind.h" #include "base/check.h" #include "base/files/file.h" +#include "base/files/file_util.h" #include "base/i18n/icu_string_conversions.h" #include "base/logging.h" #include "base/numerics/safe_conversions.h" diff --git a/google/zip_reader.h b/google/zip_reader.h index edf548b..df7452a 100644 --- a/google/zip_reader.h +++ b/google/zip_reader.h @@ -14,7 +14,6 @@ #include "base/callback.h" #include "base/files/file.h" #include "base/files/file_path.h" -#include "base/files/file_util.h" #include "base/memory/weak_ptr.h" #include "base/numerics/safe_conversions.h" #include "base/time/time.h" |