diff options
| author | François Degros <fdegros@chromium.org> | 2022-02-16 06:39:40 +0000 |
|---|---|---|
| committer | Copybara-Service <copybara-worker@google.com> | 2022-02-15 22:50:26 -0800 |
| commit | 901a5d97c2ac1420e0fe065c584d259ae610f355 (patch) | |
| tree | 73d180952f2b3478b057c8dcc1b62519cf1bfd8e | |
| parent | 6a005193afe178305e2c956304bec8be06e05d51 (diff) | |
| download | zlib-901a5d97c2ac1420e0fe065c584d259ae610f355.tar.gz | |
[zip] Add log message
minizip can potentially report an error when closing a ZIP.
Just to make sure that no error goes unnoticed, log this error to
make debugging easier.
BUG=chromium:1295127
TEST=autoninja -C out/Default zlib_unittests && out/Default/zlib_unittests
Change-Id: I37ebb68ffe017c34f94f46de51c95c5a4f16ac3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3464761
Commit-Queue: François Degros <fdegros@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/main@{#971665}
NOKEYCHECK=True
GitOrigin-RevId: 5c759f4ac60940953a4ff06a3c840efd27d4d344
| -rw-r--r-- | google/zip_reader.cc | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/google/zip_reader.cc b/google/zip_reader.cc index c6da9a8..71600bd 100644 --- a/google/zip_reader.cc +++ b/google/zip_reader.cc @@ -153,7 +153,9 @@ bool ZipReader::OpenFromString(const std::string& data) { void ZipReader::Close() { if (zip_file_) { - unzClose(zip_file_); + if (const int err = unzClose(zip_file_); err != UNZ_OK) { + LOG(ERROR) << "Error while closing ZIP archive: " << UnzipError(err); + } } Reset(); } |