diff options
| author | Noel Gordon <noel@chromium.org> | 2017-12-13 03:51:05 +0000 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2017-12-13 03:51:05 +0000 |
| commit | 9eb2a75100c6df974568b78250edf42cf6ec84bf (patch) | |
| tree | 5db777f6ec9dcdc773747e73a5323af636c95c5c /BUILD.gn | |
| parent | 91155b5d0737713fc7f0499cf0ba2c4f2af24014 (diff) | |
| download | zlib-9eb2a75100c6df974568b78250edf42cf6ec84bf.tar.gz | |
Use default optimization on Android for zlib inflate chunk copy
Speculative fix: back off from using -O3 on Android for the inflate
chunk copy code to see if -O3 caused the perf bot regression on the
Android One bot, http://bit.ly/2AfaxhG
Bug: 772870
Change-Id: I06bd941224dacbc5d7024a65934faaa53e4a4ce5
Reviewed-on: https://chromium-review.googlesource.com/823503
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Reviewed-by: Chris Blume <cblume@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#523679}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 53edf03e13a1569f146f136c9e43bc6e476bf33e
Diffstat (limited to 'BUILD.gn')
| -rw-r--r-- | BUILD.gn | 12 |
1 files changed, 7 insertions, 5 deletions
@@ -94,11 +94,13 @@ source_set("zlib_inflate_chunk_simd") { "contrib/optimizations/inflate.c", ] - if (!is_debug) { - # Use optimize_speed (-O3) to output the _smallest_ code. - configs -= [ "//build/config/compiler:default_optimization" ] - configs += [ "//build/config/compiler:optimize_speed" ] - } + # TODO(772870) back off from -O3 while investigating Android + # One perf bot PNG decode regression. + # if (!is_debug) { + # # Use optimize_speed (-O3) to output the _smallest_ code. + # configs -= [ "//build/config/compiler:default_optimization" ] + # configs += [ "//build/config/compiler:optimize_speed" ] + # } } } |