diff options
| author | Adenilson Cavalcanti <cavalcantii@chromium.org> | 2018-03-27 04:50:58 +0000 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2018-03-27 04:50:58 +0000 |
| commit | d5974a8909d817a64f41166ec6421726e6a48a95 (patch) | |
| tree | 3250c6331cc97121ad6d741e04552964c4e9a909 /BUILD.gn | |
| parent | 8c371ad77b836c02e44006dc2dc77c5d6d910861 (diff) | |
| download | zlib-d5974a8909d817a64f41166ec6421726e6a48a95.tar.gz | |
Enable compiler optimization in inflate_fast on ARM
Generate optimized code that will help ARMv8 chips (between 2
to 10% perf gain on ARMv8 little/big cores) at the expense of
a small perf regression on older chips (i.e. ARMv7).
Bug: 772870
Change-Id: Ifc47870724da9790c944f76fedcc225d0a896caf
Reviewed-on: https://chromium-review.googlesource.com/976521
Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org>
Reviewed-by: Chris Blume <cblume@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#546016}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ffc960a39d26fda610e0023667b2465118b8580a
Diffstat (limited to 'BUILD.gn')
| -rw-r--r-- | BUILD.gn | 14 |
1 files changed, 7 insertions, 7 deletions
@@ -152,13 +152,13 @@ source_set("zlib_inflate_chunk_simd") { "contrib/optimizations/inflate.c", ] - # TODO(772870) back off from -O3 while investigating Android - # One perf bot PNG decode regression. - # if (!is_debug) { - # # Use optimize_speed (-O3) to output the _smallest_ code. - # configs -= [ "//build/config/compiler:default_optimization" ] - # configs += [ "//build/config/compiler:optimize_speed" ] - # } + if (!is_debug) { + # Here we trade better performance on newer/bigger ARMv8 cores + # for less perf on ARMv7. For details, check: + # https://bugs.chromium.org/p/chromium/issues/detail?id=772870#c40 + configs -= [ "//build/config/compiler:default_optimization" ] + configs += [ "//build/config/compiler:optimize_speed" ] + } } } |