diff options
| author | Adenilson Cavalcanti <adenilson.cavalcanti@arm.com> | 2020-01-23 22:58:07 +0000 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-01-23 22:58:07 +0000 |
| commit | a0f08d65cb96917770d4e28fc3082a343de1fe39 (patch) | |
| tree | bfd6b23f2a234829aaca2493a1c188df434c8a7b /deflate.c | |
| parent | 2326c6ca3ffe2bdfc0199fcdcba22cd97d1fea5a (diff) | |
| download | zlib-a0f08d65cb96917770d4e28fc3082a343de1fe39.tar.gz | |
Using zmemzero to initialize deflate_state
Due to its history, zlib has to support building for environments
without access to basic C functions (e.g. memcpy, memset, etc) or in
environments with odd memory management patterns (e.g. MSDOS).
Therefore, it is good form to use zmemset/zmemcpy/etc for handling
memory and the same applies for initializing a memory block to zero.
Bug: 1032721
Change-Id: I8d898872ca00197cc7e961d7c49e1912073895c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016772
Reviewed-by: Chris Blume <cblume@chromium.org>
Reviewed-by: vikas soni <vikassoni@chromium.org>
Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#734686}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: bcdbc75cd3f832ad0527a00f5bf56aa437abf1f6
Diffstat (limited to 'deflate.c')
| -rw-r--r-- | deflate.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -321,7 +321,7 @@ int ZEXPORT deflateInit2_(strm, level, method, windowBits, memLevel, strategy, /* Avoid use of uninitialized value, see: * https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11360 */ - memset(s->prev, 0, s->w_size * sizeof(Pos)); + zmemzero(s->prev, s->w_size * sizeof(Pos)); s->head = (Posf *) ZALLOC(strm, s->hash_size, sizeof(Pos)); s->high_water = 0; /* nothing written to s->window yet */ |