aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorYann Collet <Cyan4973@users.noreply.github.com>2021-12-20 11:43:14 -0800
committerGitHub <noreply@github.com>2021-12-20 11:43:14 -0800
commita9e43b37d0801aa1455b5d3c024946dcb73f150b (patch)
treeaa567b97d9c46e412e7b412eea8083c87fb44468
parent85bd1e663b18d2cc8823fe15afe5aa94e03da673 (diff)
downloadzstd-a9e43b37d0801aa1455b5d3c024946dcb73f150b.tar.gz
Revert "Limit `ZSTD_maxCLevel` to 21 for 32-bit binaries."
-rw-r--r--.github/workflows/dev-short-tests.yml2
-rw-r--r--doc/zstd_manual.html2
-rw-r--r--lib/compress/clevels.h3
-rw-r--r--lib/compress/zstd_compress.c4
-rw-r--r--tests/fuzzer.c2
-rwxr-xr-xtests/playTests.sh5
6 files changed, 5 insertions, 13 deletions
diff --git a/.github/workflows/dev-short-tests.yml b/.github/workflows/dev-short-tests.yml
index b5cd2415..f06dfdb6 100644
--- a/.github/workflows/dev-short-tests.yml
+++ b/.github/workflows/dev-short-tests.yml
@@ -30,8 +30,6 @@ jobs:
steps:
- uses: actions/checkout@v2
- name: make check on 32-bit
- env:
- CHECK_CONSTRAINED_MEM: true
run: |
sudo apt update
APT_PACKAGES="gcc-multilib" make apt-install
diff --git a/doc/zstd_manual.html b/doc/zstd_manual.html
index 7d2e1c6c..3d62f595 100644
--- a/doc/zstd_manual.html
+++ b/doc/zstd_manual.html
@@ -40,7 +40,7 @@
functions.
The library supports regular compression levels from 1 up to ZSTD_maxCLevel(),
- which is 22 in most cases. Levels >= 20, labeled `--ultra`, should be used with
+ which is currently 22. Levels >= 20, labeled `--ultra`, should be used with
caution, as they require more memory. The library also offers negative
compression levels, which extend the range of speed vs. ratio preferences.
The lower the level, the faster the speed (at the cost of compression).
diff --git a/lib/compress/clevels.h b/lib/compress/clevels.h
index c2ceb638..7ed2e004 100644
--- a/lib/compress/clevels.h
+++ b/lib/compress/clevels.h
@@ -16,8 +16,7 @@
/*-===== Pre-defined compression levels =====-*/
-#define ZSTD_MAX_CLEVEL 22
-#define ZSTD_MAX_32BIT_CLEVEL 21
+#define ZSTD_MAX_CLEVEL 22
#ifdef __GNUC__
__attribute__((__unused__))
diff --git a/lib/compress/zstd_compress.c b/lib/compress/zstd_compress.c
index e3d40c54..34f8e970 100644
--- a/lib/compress/zstd_compress.c
+++ b/lib/compress/zstd_compress.c
@@ -6165,7 +6165,7 @@ size_t ZSTD_endStream(ZSTD_CStream* zcs, ZSTD_outBuffer* output)
/*-===== Pre-defined compression levels =====-*/
#include "clevels.h"
-int ZSTD_maxCLevel(void) { return MEM_32bits() ? ZSTD_MAX_32BIT_CLEVEL : ZSTD_MAX_CLEVEL; }
+int ZSTD_maxCLevel(void) { return ZSTD_MAX_CLEVEL; }
int ZSTD_minCLevel(void) { return (int)-ZSTD_TARGETLENGTH_MAX; }
int ZSTD_defaultCLevel(void) { return ZSTD_CLEVEL_DEFAULT; }
@@ -6261,7 +6261,7 @@ static ZSTD_compressionParameters ZSTD_getCParams_internal(int compressionLevel,
/* row */
if (compressionLevel == 0) row = ZSTD_CLEVEL_DEFAULT; /* 0 == default */
else if (compressionLevel < 0) row = 0; /* entry 0 is baseline for fast mode */
- else if (compressionLevel > ZSTD_maxCLevel()) row = ZSTD_maxCLevel();
+ else if (compressionLevel > ZSTD_MAX_CLEVEL) row = ZSTD_MAX_CLEVEL;
else row = compressionLevel;
{ ZSTD_compressionParameters cp = ZSTD_defaultCParameters[tableID][row];
diff --git a/tests/fuzzer.c b/tests/fuzzer.c
index c35be8e2..d168d657 100644
--- a/tests/fuzzer.c
+++ b/tests/fuzzer.c
@@ -1982,7 +1982,7 @@ static int basicUnitTests(U32 const seed, double compressibility)
int const rowLevelEnd = 8;
DISPLAYLEVEL(3, "test%3i : flat-dictionary efficiency test : \n", testNb++);
- assert(maxLevel == (MEM_32bits() ? 21 : 22));
+ assert(maxLevel == 22);
RDG_genBuffer(CNBuffer, flatdictSize + contentSize, compressibility, 0., seed);
DISPLAYLEVEL(4, "content hash : %016llx; dict hash : %016llx \n",
(unsigned long long)XXH64(contentStart, contentSize, 0),
diff --git a/tests/playTests.sh b/tests/playTests.sh
index 11240898..a772b61f 100755
--- a/tests/playTests.sh
+++ b/tests/playTests.sh
@@ -1568,11 +1568,6 @@ elif [ "$longCSize19wlog23" -gt "$optCSize19wlog23" ]; then
exit 1
fi
-if [ -n "$CHECK_CONSTRAINED_MEM" ]; then
- println "\n===> zsdt constrained memory tests "
- # shellcheck disable=SC2039
- (ulimit -Sv 500000 ; datagen -g2M | zstd -22 --single-thread --ultra > /dev/null)
-fi
if [ "$1" != "--test-large-data" ]; then
println "Skipping large data tests"