diff options
| author | Hans Wennborg <hans@chromium.org> | 2020-06-24 13:46:35 +0000 |
|---|---|---|
| committer | Copybara-Service <copybara-worker@google.com> | 2021-07-25 21:05:41 -0700 |
| commit | d5ccca824e8c5d234e607ed6a3da88671a5d09ae (patch) | |
| tree | 14d74e2ce84e5fb95322303e664531f24d6ce980 | |
| parent | 87a1494fd0aaca4b6f0dd2b406cc2abc922ddf1c (diff) | |
| download | zucchini-d5ccca824e8c5d234e607ed6a3da88671a5d09ae.tar.gz | |
Remove/replace unnecessary includes of logging.h (components/)
If the file just needs the CHECK/CHECK_OP/NOTREACHED
macros, use the appropriate header for that instead.
Or if logging.h is not needed at all, remove it.
This is both a nice cleanup (logging.h is a big header,
and including it unnecessarily has compile-time costs),
and part of the final step towards making logging.h no
longer include check.h and the others.
Bug: 1031540
Change-Id: Ibeb7cc26e331161c5a1490b84ef5a59ecd122413
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254029
Auto-Submit: Hans Wennborg <hans@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781841}
NOKEYCHECK=True
GitOrigin-RevId: 29c74d3fa1a05f3de62c3017b70c4e9e0d7fbbca
| -rw-r--r-- | algorithm.h | 2 | ||||
| -rw-r--r-- | arm_utils.h | 2 | ||||
| -rw-r--r-- | buffer_sink.h | 2 | ||||
| -rw-r--r-- | buffer_source.h | 2 | ||||
| -rw-r--r-- | buffer_view.h | 2 | ||||
| -rw-r--r-- | image_index.h | 2 | ||||
| -rw-r--r-- | patch_writer.h | 2 | ||||
| -rw-r--r-- | rel32_finder.h | 1 | ||||
| -rw-r--r-- | suffix_array.h | 2 |
9 files changed, 8 insertions, 9 deletions
diff --git a/algorithm.h b/algorithm.h index 898859f..f5d49e3 100644 --- a/algorithm.h +++ b/algorithm.h @@ -11,7 +11,7 @@ #include <type_traits> #include <vector> -#include "base/logging.h" +#include "base/check_op.h" // Collection of simple utilities used in for low-level computation. diff --git a/arm_utils.h b/arm_utils.h index eb9b343..6d8e784 100644 --- a/arm_utils.h +++ b/arm_utils.h @@ -8,7 +8,7 @@ #include <stddef.h> #include <stdint.h> -#include "base/logging.h" +#include "base/check_op.h" #include "base/macros.h" #include "components/zucchini/address_translator.h" #include "components/zucchini/buffer_view.h" diff --git a/buffer_sink.h b/buffer_sink.h index c17f040..24798af 100644 --- a/buffer_sink.h +++ b/buffer_sink.h @@ -10,7 +10,7 @@ #include <algorithm> #include <iterator> -#include "base/logging.h" +#include "base/check_op.h" #include "components/zucchini/buffer_view.h" namespace zucchini { diff --git a/buffer_source.h b/buffer_source.h index d2a05b0..7426d4e 100644 --- a/buffer_source.h +++ b/buffer_source.h @@ -11,7 +11,7 @@ #include <initializer_list> #include <type_traits> -#include "base/logging.h" +#include "base/check_op.h" #include "components/zucchini/buffer_view.h" namespace zucchini { diff --git a/buffer_view.h b/buffer_view.h index bb86a9b..661e3c3 100644 --- a/buffer_view.h +++ b/buffer_view.h @@ -11,7 +11,7 @@ #include <algorithm> #include <type_traits> -#include "base/logging.h" +#include "base/check_op.h" #include "components/zucchini/algorithm.h" namespace zucchini { diff --git a/image_index.h b/image_index.h index 6301b3a..b5acee1 100644 --- a/image_index.h +++ b/image_index.h @@ -11,7 +11,7 @@ #include <map> #include <vector> -#include "base/logging.h" +#include "base/check_op.h" #include "components/zucchini/buffer_view.h" #include "components/zucchini/image_utils.h" #include "components/zucchini/reference_set.h" diff --git a/patch_writer.h b/patch_writer.h index b698dbc..34acaf1 100644 --- a/patch_writer.h +++ b/patch_writer.h @@ -12,7 +12,7 @@ #include <utility> #include <vector> -#include "base/logging.h" +#include "base/check.h" #include "base/macros.h" #include "base/optional.h" #include "components/zucchini/buffer_sink.h" diff --git a/rel32_finder.h b/rel32_finder.h index a4691fd..b70b1be 100644 --- a/rel32_finder.h +++ b/rel32_finder.h @@ -9,7 +9,6 @@ #include <vector> -#include "base/logging.h" #include "base/macros.h" #include "base/optional.h" #include "components/zucchini/buffer_view.h" diff --git a/suffix_array.h b/suffix_array.h index ea49a43..cf9af7d 100644 --- a/suffix_array.h +++ b/suffix_array.h @@ -10,7 +10,7 @@ #include <numeric> #include <vector> -#include "base/logging.h" +#include "base/check.h" #include "base/macros.h" namespace zucchini { |