diff options
| author | Calder Kitagawa <ckitagawa@chromium.org> | 2018-07-09 18:51:54 +0000 |
|---|---|---|
| committer | Copybara-Service <copybara-worker@google.com> | 2021-07-25 20:14:35 -0700 |
| commit | 9ae7c82d685435555fab5e47d6413a26dcdd3e2b (patch) | |
| tree | 8872ed1c0fcadc8595ea1ec071db92dcf2332fc7 /disassembler_dex.cc | |
| parent | 4cf82fbaa8427012bbea30cdf8fdf23c46c9eeb9 (diff) | |
| download | zucchini-9ae7c82d685435555fab5e47d6413a26dcdd3e2b.tar.gz | |
[Zucchini] Change DCHECK in reloc_utils.cc to LOG(ERROR)
The (rva_lo_bits & 0xFFF) == rva_lo_bits DCHECK fails when the input
data is invalid. This occurs if the RelocHeader contains |rva_hi_bits|
which are mismatched from the |target_rva| for a given |ref|. This
results in |rva_lo_bits| which are invalid. Until Zucchini is
refactored to support failing to write gracefully we will just print
a loud error and skip the RVA.
This only fails in situations where the input is bad so shouldn't
occur in normal use.
Bug: 860857
Change-Id: I0472286fc54786be26b95f65e6bd18a587bc0c8b
Reviewed-on: https://chromium-review.googlesource.com/1128812
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573390}
NOKEYCHECK=True
GitOrigin-RevId: e8d1c97b22ece997e5aa5d87d29ef150b6857603
Diffstat (limited to 'disassembler_dex.cc')
0 files changed, 0 insertions, 0 deletions