[Zucchini] Zucchini-gen: Make number of CreateEquivalenceMap() generations depend on Disassembler.

The number of CreateEquivalenceMap() iterations used be constant
kNumIteraitons = 2. This CL makes the value depend on architecture.
Current assignment:
- DisassemblerNoOp: 1, since no pointers are identified (though in this
  case, CreateEquivalenceMap() should not be called).
- DisassemblerWin32: 2.
Upcoming DisassemblerDex will use 4.

Also applying generic cleanups on headers and comments.

Bug: 729154
Change-Id: Ia12d98fcba500e4c81c8a5d356ce4cadf424ffde
Reviewed-on: https://chromium-review.googlesource.com/961273
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542919}
NOKEYCHECK=True
GitOrigin-RevId: 55aea0a875b80e614464fdd157d9717471f9d64f

1 files changed, 2 insertions, 4 deletions

diff --git a/disassembler_win32.cc b/disassembler_win32.cc
index 5bdc503..a932bea 100644
--- a/disassembler_win32.cc
+++ b/disassembler_win32.cc
@@ -86,8 +86,9 @@ bool DisassemblerWin32<Traits>::QuickDetect(ConstBufferView image) {
   return ReadWin32Header<Traits>(image, &source);
 }
 
+// |num_equivalence_iterations_| = 2 for reloc -> abs32.
 template <class Traits>
-DisassemblerWin32<Traits>::DisassemblerWin32() = default;
+DisassemblerWin32<Traits>::DisassemblerWin32() : Disassembler(2) {}
 
 template <class Traits>
 DisassemblerWin32<Traits>::~DisassemblerWin32() = default;
@@ -309,9 +310,6 @@ bool DisassemblerWin32<Traits>::ParseAndStoreRelocBlocks() {
                                               &reloc_block_offsets_);
 }
 
-// TODO(huangs): Print warning if too few abs32 references are found.
-// Empirically, file size / # relocs is < 100, so take 200 as the
-// threshold for warning.
 template <class Traits>
 bool DisassemblerWin32<Traits>::ParseAndStoreAbs32() {
   if (has_parsed_abs32_)