diff options
author | Samuel Huang <huangs@chromium.org> | 2018-11-08 21:53:27 +0000 |
---|---|---|
committer | Copybara-Service <copybara-worker@google.com> | 2021-07-25 20:41:11 -0700 |
commit | fb345573ac09d9e282569d01fceadda5bb570bc4 (patch) | |
tree | 61f801918b5b63808db11af5a9cb3d2702129bd9 /element_detection.cc | |
parent | d60fe380fbf410ad935b1a7c0005e76823095b6e (diff) | |
download | zucchini-fb345573ac09d9e282569d01fceadda5bb570bc4.tar.gz |
[Zucchini] Cleanup before adding ARM support.
Update includes and comments, and remove some unused code.
In particular, remove TODO comments for figuring out whether ARM
abs32 references can be 4 bytes long: Turns out ARM absolute
references are 8 bytes long. It's rel32 refereneces that can be
4 bytes long.
Change-Id: I02dc905885f6cb5ff929efe0fb1f9a6593ee05a8
Reviewed-on: https://chromium-review.googlesource.com/c/1327559
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606612}
NOKEYCHECK=True
GitOrigin-RevId: 9076fc4939ced233b85e5f8942ba947b6143aba3
Diffstat (limited to 'element_detection.cc')
-rw-r--r-- | element_detection.cc | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/element_detection.cc b/element_detection.cc index fa5adf4..d4347c5 100644 --- a/element_detection.cc +++ b/element_detection.cc @@ -15,14 +15,14 @@ #include "components/zucchini/disassembler_dex.h" #endif // BUILDFLAG(ENABLE_DEX) -#if BUILDFLAG(ENABLE_WIN) -#include "components/zucchini/disassembler_win32.h" -#endif // BUILDFLAG(ENABLE_WIN) - #if BUILDFLAG(ENABLE_ELF) #include "components/zucchini/disassembler_elf.h" #endif // BUILDFLAG(ENABLE_ELF) +#if BUILDFLAG(ENABLE_WIN) +#include "components/zucchini/disassembler_win32.h" +#endif // BUILDFLAG(ENABLE_WIN) + #if BUILDFLAG(ENABLE_ZTF) #include "components/zucchini/disassembler_ztf.h" #endif // BUILDFLAG(ENABLE_ZTF) |