diff options
| author | Etienne Pierre-doray <etiennep@chromium.org> | 2021-10-29 14:12:23 +0000 |
|---|---|---|
| committer | Copybara-Service <copybara-worker@google.com> | 2021-10-29 07:21:52 -0700 |
| commit | 8bb965d29e918d0559589a215ff7f4bd0874bc08 (patch) | |
| tree | 5f8e62ce428ef559d57789248ed2d237e33791e8 /equivalence_map.cc | |
| parent | b90a947429fdce96b1d684b9a7af9683cb4a13c1 (diff) | |
| download | zucchini-8bb965d29e918d0559589a215ff7f4bd0874bc08.tar.gz | |
[Zucchini]: Convert OffsetMapper to deque
push_back with vector tends to cause higher memory peak than necessary.
Changing deque is a simple change that reduces memory peak at the cost
of loss of guarantee (contiguous storage).
This has no significant impact on cpu time. On MacBook pro 2017
Before:
Zucchini.TotalTime 9.95879 s
Zucchini.TotalTime 9.11599 s
Zucchini.TotalTime 9.33174 s
After:
Zucchini.TotalTime 10.5557 s
Zucchini.TotalTime 8.78599 s
Zucchini.TotalTime 8.95282 s
Bug: 1262150
Change-Id: I078a671832f2a33d5e1a3d9d971bff66d4179b89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3247092
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/main@{#936371}
NOKEYCHECK=True
GitOrigin-RevId: 7abe67cf21e8f30c0ff2499410c8d57aae9bf8fc
Diffstat (limited to 'equivalence_map.cc')
| -rw-r--r-- | equivalence_map.cc | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/equivalence_map.cc b/equivalence_map.cc index be9ec0f..b4d5e27 100644 --- a/equivalence_map.cc +++ b/equivalence_map.cc @@ -214,7 +214,7 @@ EquivalenceCandidate VisitEquivalenceSeed( /******** OffsetMapper ********/ -OffsetMapper::OffsetMapper(std::vector<Equivalence>&& equivalences, +OffsetMapper::OffsetMapper(std::deque<Equivalence>&& equivalences, offset_t old_image_size, offset_t new_image_size) : equivalences_(std::move(equivalences)), @@ -310,7 +310,7 @@ void OffsetMapper::ForwardProjectAll(std::deque<offset_t>* offsets) const { } void OffsetMapper::PruneEquivalencesAndSortBySource( - std::vector<Equivalence>* equivalences) { + std::deque<Equivalence>* equivalences) { std::sort(equivalences->begin(), equivalences->end(), [](const Equivalence& a, const Equivalence& b) { return a.src_offset < b.src_offset; @@ -368,6 +368,7 @@ void OffsetMapper::PruneEquivalencesAndSortBySource( base::EraseIf(*equivalences, [](const Equivalence& equivalence) { return equivalence.length == 0; }); + equivalences->shrink_to_fit(); } /******** EquivalenceMap ********/ |