aboutsummaryrefslogtreecommitdiff
path: root/rel32_utils.cc
diff options
context:
space:
mode:
authorCalder Kitagawa <ckitagawa@google.com>2018-04-10 20:03:08 +0000
committerEdward Lesmes <ehmaldonado@google.com>2021-07-23 22:06:59 +0000
commit07c31a327fc75fd62023d1774e900f85ce982ee7 (patch)
tree6aba922d42afda99dcc3194f0cbbda0667ef5286 /rel32_utils.cc
parenta8a2a9446ab207b7b6e401c16205adc68433fe08 (diff)
downloadzucchini-07c31a327fc75fd62023d1774e900f85ce982ee7.tar.gz
[Zucchini] Remove Marking Logic
With recent refactoring by etiennep@ marking high bits is no longer required. This removes checks for existing high bits which were previously filtered out to avoid conflicts with the marking system used. Change-Id: Iab929b19ade5c9faaf7c6be073136352170c794a Reviewed-on: https://chromium-review.googlesource.com/1002862 Commit-Queue: Calder Kitagawa <ckitagawa@google.com> Reviewed-by: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#549620} NOKEYCHECK=True GitOrigin-RevId: 79c5e3545912bb2ec527fbe61b2aafe66c6e5bc2
Diffstat (limited to 'rel32_utils.cc')
-rw-r--r--rel32_utils.cc6
1 files changed, 2 insertions, 4 deletions
diff --git a/rel32_utils.cc b/rel32_utils.cc
index fa59386..2d42975 100644
--- a/rel32_utils.cc
+++ b/rel32_utils.cc
@@ -37,10 +37,8 @@ base::Optional<Reference> Rel32ReaderX86::GetNext() {
rva_t loc_rva = location_offset_to_rva_.Convert(loc_offset);
rva_t target_rva = loc_rva + 4 + image_.read<int32_t>(loc_offset);
offset_t target_offset = target_rva_to_offset_.Convert(target_rva);
- // In rare cases, the most significant bit of |target| is set. This
- // interferes with label marking. We expect these to already be filtered out
- // from |locations|.
- DCHECK(!IsMarked(target_offset));
+ // |locations| is valid by assumption (see class description).
+ DCHECK_NE(kInvalidOffset, target_offset);
return Reference{loc_offset, target_offset};
}
return base::nullopt;