diff options
| author | Calder Kitagawa <ckitagawa@google.com> | 2018-04-10 20:03:08 +0000 |
|---|---|---|
| committer | Edward Lesmes <ehmaldonado@google.com> | 2021-07-23 22:06:59 +0000 |
| commit | 07c31a327fc75fd62023d1774e900f85ce982ee7 (patch) | |
| tree | 6aba922d42afda99dcc3194f0cbbda0667ef5286 /rel32_utils_unittest.cc | |
| parent | a8a2a9446ab207b7b6e401c16205adc68433fe08 (diff) | |
| download | zucchini-07c31a327fc75fd62023d1774e900f85ce982ee7.tar.gz | |
[Zucchini] Remove Marking Logic
With recent refactoring by etiennep@ marking high bits is no longer
required. This removes checks for existing high bits which were
previously filtered out to avoid conflicts with the marking system
used.
Change-Id: Iab929b19ade5c9faaf7c6be073136352170c794a
Reviewed-on: https://chromium-review.googlesource.com/1002862
Commit-Queue: Calder Kitagawa <ckitagawa@google.com>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549620}
NOKEYCHECK=True
GitOrigin-RevId: 79c5e3545912bb2ec527fbe61b2aafe66c6e5bc2
Diffstat (limited to 'rel32_utils_unittest.cc')
| -rw-r--r-- | rel32_utils_unittest.cc | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/rel32_utils_unittest.cc b/rel32_utils_unittest.cc index 6d90112..29e8560 100644 --- a/rel32_utils_unittest.cc +++ b/rel32_utils_unittest.cc @@ -51,7 +51,7 @@ TEST(Rel32UtilsTest, Rel32ReaderX86) { // including rel32 targets, without the full instructions. std::vector<uint8_t> bytes = { 0xFF, 0xFF, 0xFF, 0xFF, // 00030000: (Filler) - 0x00, 0x00, 0x00, 0x80, // 00030004: 80030008 Marked, so invalid. + 0xFF, 0xFF, 0xFF, 0xFF, // 0003000C: (Filler) 0x04, 0x00, 0x00, 0x00, // 00030008: 00030010 0xFF, 0xFF, 0xFF, 0xFF, // 0003000C: (Filler) 0x00, 0x00, 0x00, 0x00, // 00030010: 00030014 @@ -82,12 +82,6 @@ TEST(Rel32UtilsTest, Rel32ReaderX86) { Rel32ReaderX86 reader3(buffer, 0x000CU, 0x0018U, &rel32_locations, translator); CheckReader({{0x0010U, 0x0014U}}, &reader3); - - // Marked target encountered (error). - std::vector<offset_t> rel32_marked_locations = {0x00004U}; - Rel32ReaderX86 reader4(buffer, 0x0000U, 0x0020U, &rel32_marked_locations, - translator); - EXPECT_DCHECK_DEATH(reader4.GetNext()); } TEST(Rel32UtilsTest, Rel32WriterX86) { |