diff options
author | Etienne Pierre-doray <etiennep@chromium.org> | 2021-10-29 14:12:23 +0000 |
---|---|---|
committer | Copybara-Service <copybara-worker@google.com> | 2021-10-29 07:21:52 -0700 |
commit | 8bb965d29e918d0559589a215ff7f4bd0874bc08 (patch) | |
tree | 5f8e62ce428ef559d57789248ed2d237e33791e8 /test_reference_reader.h | |
parent | b90a947429fdce96b1d684b9a7af9683cb4a13c1 (diff) | |
download | zucchini-8bb965d29e918d0559589a215ff7f4bd0874bc08.tar.gz |
[Zucchini]: Convert OffsetMapper to deque
push_back with vector tends to cause higher memory peak than necessary.
Changing deque is a simple change that reduces memory peak at the cost
of loss of guarantee (contiguous storage).
This has no significant impact on cpu time. On MacBook pro 2017
Before:
Zucchini.TotalTime 9.95879 s
Zucchini.TotalTime 9.11599 s
Zucchini.TotalTime 9.33174 s
After:
Zucchini.TotalTime 10.5557 s
Zucchini.TotalTime 8.78599 s
Zucchini.TotalTime 8.95282 s
Bug: 1262150
Change-Id: I078a671832f2a33d5e1a3d9d971bff66d4179b89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3247092
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/main@{#936371}
NOKEYCHECK=True
GitOrigin-RevId: 7abe67cf21e8f30c0ff2499410c8d57aae9bf8fc
Diffstat (limited to 'test_reference_reader.h')
0 files changed, 0 insertions, 0 deletions