diff options
author | Samuel Huang <huangs@chromium.org> | 2018-04-29 03:36:08 +0000 |
---|---|---|
committer | Edward Lesmes <ehmaldonado@google.com> | 2021-07-23 22:16:20 +0000 |
commit | 93ffc913ec7d369818a109b9ca6de7adb278e163 (patch) | |
tree | 231de7095cb989d4220beb4a5d9f13e931a74ddc /zucchini_commands.cc | |
parent | 673bf5912068218539f524b6dfe74dfb38fe67b8 (diff) | |
download | zucchini-93ffc913ec7d369818a109b9ca6de7adb278e163.tar.gz |
[Zucchini] Fix range error for equivalence validation.
CL https://chromium-review.googlesource.com/1028836 adds patch
validation to ensure equivalence blocks for element pairs would not
span outside the regions for respective elements. The check assumes that
equivalences use absolute offsets for entire "old" or "new" archives.
This was mistaken (and missed in review), since equivalences in fact use
"local" offsets relative to the start of each element. As a result,
ensemble patching for Zucchini-apply would mistakenly trigger the check,
leading to patch failure.
This CL fixes the check. This removes the need for RangeIsInRegion()
(now removed), since RangeIsBounded() suffices.
Bug: 837096
TBR=grt@chromium.org
Change-Id: I2b1e575c4a44f112adebaf1487a41f12cf23f570
Reviewed-on: https://chromium-review.googlesource.com/1034274
Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554664}
NOKEYCHECK=True
GitOrigin-RevId: ebf95f0d9797ccf86cd59d43dec1ee58cd703c41
Diffstat (limited to 'zucchini_commands.cc')
0 files changed, 0 insertions, 0 deletions