| Age | Commit message (Collapse) | Author |
|---|
|
0d1306182f am: dd0b6e3bf2 am: 1de48bf84e
Original change: https://android-review.googlesource.com/c/platform/external/zucchini/+/1895428
Change-Id: I4f5c6a4883719a69ec8ae69173cb1a1be6362af5
|
|
0d1306182f am: dd0b6e3bf2
Original change: https://android-review.googlesource.com/c/platform/external/zucchini/+/1895428
Change-Id: Id00baf17a5e0ed9850acb726af82cca3c5dcd09f
|
|
Original change: https://android-review.googlesource.com/c/platform/external/zucchini/+/1895428
Change-Id: I210ab6c049b54c4bbe9863c5bed9db964ee8b4d1
|
|
Original change: https://android-review.googlesource.com/c/platform/external/zucchini/+/1895428
Change-Id: I77ea31ad8ffc528e7c3b7566a9b90c9bb2be5ef8
|
|
CL
* 261f4df0 Update callsites to use WIN_-prefixed base::File flags.
cause build failure on android, because AOSP's copy of libchrome doesn't
have WIN_ prefix. To address that I added
Change-Id: I5457ae8b784b86644f0ae86182bcb0422629bfd3
|
|
This CL moves zucchini::{kMajorVersion, kMinorVersion, kInvalidVersion}
to a standalone file version_info.h. The location should remain stable.
Stability is important so that:
* External tools can determine Zucchini versoin from source, i.e., the
file serves as an implicit API.
* Running 'git log' on version_info.h will point to CLs that implement
or enable patch break changes.
Bug: 1231882
Change-Id: I13243a5627870a31d8789d3579f1a50cc0e52bd5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3287124
Commit-Queue: Samuel Huang <huangs@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/main@{#942645}
NOKEYCHECK=True
GitOrigin-RevId: 0b4473c4e1683729ac9f81257ba48e1d3e34418f
|
|
The flags have been renamed to make it clear that they only
apply to Windows (see associated bug).
If you're reviewing this CL, please verify your code's usage
of the flag to ensure that the behavior is as intended. Thanks!
This CL was uploaded by git cl split.
R=huangs@chromium.org
Bug: 1244149
Change-Id: I08d4f6e886a699d852470e08025edb85b0a695ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3279224
Auto-Submit: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/main@{#942295}
NOKEYCHECK=True
GitOrigin-RevId: 9f7f7c8f781c5b7946dc9be3f80cc28cda9e971c
|
|
am: ddc43dc959 am: d9eed84a58 am: 58b4d19a6b am: 7be4275909
Original change: https://android-review.googlesource.com/c/platform/external/zucchini/+/1877854
Change-Id: Ifdb1f7882cc237258a3395d28158d50bb4b43136
|
|
am: ddc43dc959 am: d9eed84a58 am: 58b4d19a6b
Original change: https://android-review.googlesource.com/c/platform/external/zucchini/+/1877854
Change-Id: I31da7b51c793e73f8a66b1fd4ca9be90ae6e6df2
|
|
am: ddc43dc959 am: d9eed84a58
Original change: https://android-review.googlesource.com/c/platform/external/zucchini/+/1877854
Change-Id: I7de3d8374e868066777abb326d3e20c1e4b44803
|
|
am: ddc43dc959
Original change: https://android-review.googlesource.com/c/platform/external/zucchini/+/1877854
Change-Id: Id5e02db627de075e9548615777d76b927e7fed56
|
|
Original change: https://android-review.googlesource.com/c/platform/external/zucchini/+/1877854
Change-Id: I6d96f25563c195a2eeb3f4b7fbe00fc2becabcd6
|
|
This performs a merge on upstream zucchini.
Change-Id: I8a4844407558d6f1e439939ee634fe17ed7a4e55
|
|
push_back with vector tends to cause higher memory peak than necessary.
Changing deque is a simple change that reduces memory peak at the cost
of loss of guarantee (contiguous storage).
This has no significant impact on cpu time. On MacBook pro 2017
Before:
Zucchini.TotalTime 9.95879 s
Zucchini.TotalTime 9.11599 s
Zucchini.TotalTime 9.33174 s
After:
Zucchini.TotalTime 10.5557 s
Zucchini.TotalTime 8.78599 s
Zucchini.TotalTime 8.95282 s
Bug: 1262150
Change-Id: I078a671832f2a33d5e1a3d9d971bff66d4179b89
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3247092
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/main@{#936371}
NOKEYCHECK=True
GitOrigin-RevId: 7abe67cf21e8f30c0ff2499410c8d57aae9bf8fc
|
|
This is a breaking change to zucchini patch format:
Zucchini 1.0, see changelog.
Add major/minor patch-wide version, and element version.
Also add VerifyPatch() API and command line option to verify
patch compatibility.
Design: go/zucchini-versions
Bug: 1231882
Change-Id: I19f1fbe2ee866c23f0814ffe6a912fb72812edbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3140224
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#936096}
NOKEYCHECK=True
GitOrigin-RevId: 559d77a9741428a48add017d389d104e431e6de7
|
|
shrink_to_fit with vector tends to cause high memory peak.
Changing deque is a simple change that reduces memory peak at the cost of
loss of guarantee (contiguous storage).
Similar to https://chromium-review.googlesource.com/c/chromium/src/+/2830864
which dramatically reduced crach rate
https://crash.corp.google.com/browse?q=product_name%3D%27Chrome%27+AND+EXISTS+%28SELECT+1+FROM+UNNEST%28CrashedStackTrace.StackFrame%29+WHERE+FunctionName%3D%27installer%3A%3AArchivePatchHelper%3A%3AZucchiniEnsemblePatch%27%29+AND+expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27%5BOut+of+Memory%5D+zucchini%3A%3ADisassemblerWin32%3Czucchini%3A%3AWin32X64Traits%3E%3A%3AParseAndStoreRel32%27
An alternative is to look ahead to determine vector size. The is hard to do
with SortAndUniquify, which performs in-place modifications.
Bug: 1247633
Change-Id: I624c360ee1f2bf18bd584d1aafdde0f0c2ffb61e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3149810
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/main@{#921292}
NOKEYCHECK=True
GitOrigin-RevId: 380557e6b592531eb360513791968dd7ab0ee77d
|
|
Bug: 794619
Change-Id: Ic842b420403fe932525fb5878d2e1d4e81577c32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3141022
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/main@{#919333}
NOKEYCHECK=True
GitOrigin-RevId: bef7bc52a0e081b382fd660a2ea3adc49500cac3
|
|
DEX Version 39 added:
* const-method-handle containing a method_handle@BBBB reference
* const-method-type containing a proto@BBBB reference
This CL
* Updates CodeToProtoId for const-method-type
* Adds CodeToMethodHandle and WriteMethodHandle
Fuzzed about 500k iterations locally and uploaded new samples to
the clusterfuzz bucket. 97% coverage.
Manually tested on hand-written dex files using smali as well as the
dexdump test corpus.
Bug: 1231885
Change-Id: Id8ab09ac8d3331902c5e6f92ac39ebd26d36e79b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3060660
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/main@{#918948}
NOKEYCHECK=True
GitOrigin-RevId: d08c50abf7b49f3a5b97a03d5bb79bce9fdb7fad
|
|
Use template read/write functions instead of repeated versions.
Change-Id: Ie87d307ebd7b297fe802216fe07aa820d7b1fa4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3082253
Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/main@{#918237}
NOKEYCHECK=True
GitOrigin-RevId: d64aec31e8bb5e1acb9a2da1e6e92fbd5e59d5f6
|
|
DEX Version 38 added:
* CallSiteId & CallSite items
* MethodHandle items
* invoke-polymorphic containing meth@BBBB and proto@HHHH references
* invoke-custom containing a call_site@BBBB reference
This CL:
* Adds CallSiteIdToCallSite
* Adds MethodHandleTo{MethodId, FieldId}
* Adds CodeToProtoId16 for invoke-polymorphic
* Adds CodeToCallSiteId16 and WriteCallSiteId16 for invoke-custom
* Updates CodeToMethodId16 for invoke-polymorphic
Fuzzed about 1 million iterations locally and uploaded new samples to
the clusterfuzz bucket. 97% coverage.
Manually tested on hand-written dex files using smali as well as the
dexdump test corpus.
Bug: 1231885
Change-Id: Icd885be2cfd433d0befe689d16c4a1e99573ca6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3060745
Reviewed-by: Samuel Huang <huangs@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/main@{#918119}
NOKEYCHECK=True
GitOrigin-RevId: 9cc600ef0b60ff1ec76683a2bfb98a6bdbb05d1e
|
|
b93686f638 am: 919a460e14 am: 4ec021d209
Original change: https://android-review.googlesource.com/c/platform/external/zucchini/+/1804859
Change-Id: Ib13dfffd26bc27c051937a8301a5b523061a6c38
|
|
external/zucchini" am: 9a5bb38ec1 am: ea284963cb -s ours am: 484dc74b29 -s ours am: 7213edacb8 -s ours am: 98057f33f8 -s ours
am skip reason: Merged-In I16d1c2fb3282ec8317c8d48bf2816e922ab98be8 with SHA-1 4c6f1f860b is already in history
Original change: https://android-review.googlesource.com/c/platform/external/zucchini/+/1804267
Change-Id: Ie590e2048147780dce5b56e38ce670921d632ab6
|
|
b93686f638 am: 919a460e14
Original change: https://android-review.googlesource.com/c/platform/external/zucchini/+/1804859
Change-Id: Id5e28b9a54ea6dbec9a8ef6548f1a347e1db8d2b
|
|
external/zucchini" am: 9a5bb38ec1 am: ea284963cb -s ours am: 484dc74b29 -s ours am: 7213edacb8 -s ours
am skip reason: Merged-In I16d1c2fb3282ec8317c8d48bf2816e922ab98be8 with SHA-1 4c6f1f860b is already in history
Original change: https://android-review.googlesource.com/c/platform/external/zucchini/+/1804267
Change-Id: I9af8fd0792e0571f324b5e8c6ece223d0571d82f
|
|
b93686f638
Original change: https://android-review.googlesource.com/c/platform/external/zucchini/+/1804859
Change-Id: I7a545f2a27b711d937f64a50e6021f76297d5d21
|
|
external/zucchini" am: 9a5bb38ec1 am: ea284963cb -s ours am: 484dc74b29 -s ours
am skip reason: Merged-In I16d1c2fb3282ec8317c8d48bf2816e922ab98be8 with SHA-1 4c6f1f860b is already in history
Original change: https://android-review.googlesource.com/c/platform/external/zucchini/+/1804267
Change-Id: Icd72aaecf3054a1f3c6e375a7c31b98bc7a539ec
|
|
Original change: https://android-review.googlesource.com/c/platform/external/zucchini/+/1804859
Change-Id: Ie0340f4589041dfdf9c5aaf452e10593ba6c8d8f
|
|
external/zucchini" am: 9a5bb38ec1 am: ea284963cb -s ours
am skip reason: Merged-In I16d1c2fb3282ec8317c8d48bf2816e922ab98be8 with SHA-1 4c6f1f860b is already in history
Original change: https://android-review.googlesource.com/c/platform/external/zucchini/+/1804267
Change-Id: If0ddf7a185da601d36bcb03a1346bcfe39ee387b
|
|
Original change: https://android-review.googlesource.com/c/platform/external/zucchini/+/1804859
Change-Id: Id7a836436fcb9b27ee1c9cc9edb17c8ac57d7ceb
|
|
Original change: https://android-review.googlesource.com/c/platform/external/zucchini/+/1804267
Change-Id: I5f03cf680ab86bb1d3e965e2f238573efa5676c2
|
|
|
|
|
|
Test: build
Change-Id: Ifa02e31a68cca26876f6b860a0c8701c4a1be497
|
|
6137065d63 am: 2fd020eeb1 am: 122bcb4807
Original change: https://android-review.googlesource.com/c/platform/external/zucchini/+/1802617
Change-Id: Ief3f71dc4dfca229fd2e2cbb6d7a3c6c15bbc9f5
|
|
6137065d63 am: 2fd020eeb1
Original change: https://android-review.googlesource.com/c/platform/external/zucchini/+/1802617
Change-Id: I440ff7b4bc96b6587355aba69d08a6c3b924917a
|
|
6137065d63
Original change: https://android-review.googlesource.com/c/platform/external/zucchini/+/1802617
Change-Id: I4b3102803a716b2a7e66793bf66f922333fec29f
|
|
Original change: https://android-review.googlesource.com/c/platform/external/zucchini/+/1802617
Change-Id: I6684e496c6899ac5ba4a869ffaf2abc39035c449
|
|
Original change: https://android-review.googlesource.com/c/platform/external/zucchini/+/1802617
Change-Id: I37d66d5515ded0ada262545be92bab2c69b6e9cb
|
|
When marking libzucchini as recovery_available, build system tries to
glob all header files in exported include dir. This fails because the
symlink points to a parent directory, which also contains the symlink
itself. Therefore the glob fails due to infinite recursion.
Test: th
Bug: 194237829
Change-Id: I49eb64b2c31f3446f17db6139803f81e2a39148b
|
|
am: 6579b46ac9 am: dbdbb7e79b
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/zucchini/+/15646253
Change-Id: Ic552568b3f2640b3a9e1655821a4bc83984833e1
|
|
am: 6579b46ac9
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/zucchini/+/15646253
Change-Id: I5c47c578901c7f35d4ad56f1f996862b31543abe
|
|
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/zucchini/+/15646253
Change-Id: I5ea1df71e2c7b2efd726a09da9492bc8fad99011
|
|
Original change: https://android-review.googlesource.com/c/platform/external/zucchini/+/1802618
Change-Id: I94a69915cecc358c6559051996c8787592c1f7a3
|
|
Added legacy_notice to:
Android.bp
Bug: 68860345
Bug: 151177513
Bug: 151953481
Test: m all
Exempt-From-Owner-Approval: janitorial work
Merged-in: I16d1c2fb3282ec8317c8d48bf2816e922ab98be8
Change-Id: I5283ad5beb8cc403269961181e69cbfcd2410091
|
|
Original change: https://android-review.googlesource.com/c/platform/external/zucchini/+/1802618
Change-Id: I01662dc36cd8b640b2dbf00761efb346c54248fa
|
|
sc-dev-plus-aosp am: 4b33ae0280 am: dcfb18de1c am: 517c2ded85
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/zucchini/+/15619506
Change-Id: I92213df7e841329ea8d6c05e46d03ef40ac5cadf
|
|
sc-dev-plus-aosp am: 4b33ae0280 am: dcfb18de1c
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/zucchini/+/15619506
Change-Id: I76f0d8dbfd61f59c6a0378be00ff6681b830ee8d
|
|
sc-dev-plus-aosp am: 4b33ae0280
Original change: https://googleplex-android-review.googlesource.com/c/platform/external/zucchini/+/15619506
Change-Id: Ib0361e2068aaecbd679a44a889d9ecfd4dbb518b
|
|
zucchini might need to run on host w/o android repo(for testing
purposes). Therefore statically link the binary.
Test: th
Change-Id: Ic3847cbf4694418fa43270580596bf7d5cc70f8e
|
|
|
