| Age | Commit message (Collapse) | Author |
|---|
|
This CL adds an optional file descriptor to LoggingSettings, which can
be used to initialize logging to an already open file. Previously,
logging to a file required passing a path and letting the logging
system open() it for append. Passing a file-descriptor means that a
process can be sandboxed to have no access to the log directory, but
can still be passed a file-descriptor to log to.
This is needed for the Network Service on ChromeOS, whose logging needs
to be reinitialized to a new location after it's already started.
Bug: 977415
Change-Id: I2d07dc13a7e9f0f57d0802e4816628c181f183cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699477
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688754}
NOKEYCHECK=True
GitOrigin-RevId: 8bf4984f3ad0fb5fc8981f02ce9b96078a98632f
|
|
* Separate LOG_TO_SYSTEM_DEBUG_LOG into two cases, LOG_TO_STDERR and
LOG_TO_SYSTEM_DEBUG_LOG as before.
* Provide the option to only write to system specific logs, write to
stderr or both, reducing redundant logs for systems which have log
services, such as with Fuchsia.
* For all systems, logs with severity ERROR and above will continue to
be written to stderr.
* All systems except Fuchsia have the same behaviour and defaults as
before.
* Update default logging destination for Fuchsia to system logs only.
Bug: 960882
Change-Id: Ib0f27d194226ac5584609a3e8e4bc561828deed8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601467
Commit-Queue: Sharon Yang <yangsharon@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#661446}
NOKEYCHECK=True
GitOrigin-RevId: 7cb919a9b3f78d642f8a98e8a81140ef13e2fec2
|
|
(Use "git log --follow" to see older revisions of files).
/components/ is the most logical place to put Zucchini, which only
depends on /base and /testing/gtest. This move also enables Zucchini to
be used by the Component Updater. Details:
- Move all files; run the following to change deps and guards:
sed 's/chrome\/installer/components/' *.cc *.h -i
sed 's/CHROME_INSTALLER/COMPONENTS/' *.cc *.h -i
- Sorting works out pretty well!
- Change all 'chrome/installer/zucchini' to 'components/zucchini'
throughout other parts of the repo; sort if necessary.
- Fix 6 'git cl lint' errors.
- Change 1 Bind() usage to BindRepeated().
- Update OWNER.
Bug: 729154
Change-Id: I50c5a7d411ea85f707b5994ab319dfb2a1acccf7
Reviewed-on: https://chromium-review.googlesource.com/954923
Reviewed-by: Greg Thompson <grt@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Samuel Huang <huangs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542857}
NOKEYCHECK=True
GitOrigin-RevId: 577ef6c435e8d43be6e3e60ccbcbd1881780f4ec
|
