From fb345573ac09d9e282569d01fceadda5bb570bc4 Mon Sep 17 00:00:00 2001 From: Samuel Huang Date: Thu, 8 Nov 2018 21:53:27 +0000 Subject: [Zucchini] Cleanup before adding ARM support. Update includes and comments, and remove some unused code. In particular, remove TODO comments for figuring out whether ARM abs32 references can be 4 bytes long: Turns out ARM absolute references are 8 bytes long. It's rel32 refereneces that can be 4 bytes long. Change-Id: I02dc905885f6cb5ff929efe0fb1f9a6593ee05a8 Reviewed-on: https://chromium-review.googlesource.com/c/1327559 Reviewed-by: Etienne Pierre-Doray Reviewed-by: Samuel Huang Commit-Queue: Samuel Huang Cr-Commit-Position: refs/heads/master@{#606612} NOKEYCHECK=True GitOrigin-RevId: 9076fc4939ced233b85e5f8942ba947b6143aba3 --- disassembler_elf.h | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to 'disassembler_elf.h') diff --git a/disassembler_elf.h b/disassembler_elf.h index d8012db..866c3b6 100644 --- a/disassembler_elf.h +++ b/disassembler_elf.h @@ -67,8 +67,6 @@ struct Elf64IntelTraits : public Elf64Traits { template class DisassemblerElf : public Disassembler { public: - using HeaderVector = std::vector; - // Applies quick checks to determine whether |image| *may* point to the start // of an executable. Returns true iff the check passes. static bool QuickDetect(ConstBufferView image); @@ -110,9 +108,8 @@ class DisassemblerElf : public Disassembler { // Processes rel32 data after they are extracted from executable sections. virtual void PostProcessRel32() = 0; - // The parsing routines below return true on success, and false on failure. - // Parses ELF header and section headers, and performs basic validation. + // Returns whether parsing was successful. bool ParseHeader(); // Extracts and stores section headers that we need. -- cgit v1.2.3