From aff408603b3db5b7974c522db2ad8c5ce2a0f3c1 Mon Sep 17 00:00:00 2001 From: Etienne Pierre-doray Date: Tue, 14 Sep 2021 17:31:51 +0000 Subject: [zucchini]: Convert TargetPool to deque. shrink_to_fit with vector tends to cause high memory peak. Changing deque is a simple change that reduces memory peak at the cost of loss of guarantee (contiguous storage). Similar to https://chromium-review.googlesource.com/c/chromium/src/+/2830864 which dramatically reduced crach rate https://crash.corp.google.com/browse?q=product_name%3D%27Chrome%27+AND+EXISTS+%28SELECT+1+FROM+UNNEST%28CrashedStackTrace.StackFrame%29+WHERE+FunctionName%3D%27installer%3A%3AArchivePatchHelper%3A%3AZucchiniEnsemblePatch%27%29+AND+expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27%5BOut+of+Memory%5D+zucchini%3A%3ADisassemblerWin32%3Czucchini%3A%3AWin32X64Traits%3E%3A%3AParseAndStoreRel32%27 An alternative is to look ahead to determine vector size. The is hard to do with SortAndUniquify, which performs in-place modifications. Bug: 1247633 Change-Id: I624c360ee1f2bf18bd584d1aafdde0f0c2ffb61e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3149810 Commit-Queue: Etienne Pierre-Doray Reviewed-by: Samuel Huang Cr-Commit-Position: refs/heads/main@{#921292} NOKEYCHECK=True GitOrigin-RevId: 380557e6b592531eb360513791968dd7ab0ee77d --- equivalence_map.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'equivalence_map.h') diff --git a/equivalence_map.h b/equivalence_map.h index 8b716a1..2a8b7de 100644 --- a/equivalence_map.h +++ b/equivalence_map.h @@ -128,7 +128,7 @@ class OffsetMapper { // Given sorted |offsets|, applies a projection in-place of all offsets that // are part of a pruned equivalence from |old_image| to |new_image|. Other // offsets are removed from |offsets|. - void ForwardProjectAll(std::vector* offsets) const; + void ForwardProjectAll(std::deque* offsets) const; // Accessor for testing. const std::vector equivalences() const { return equivalences_; } -- cgit v1.2.3