1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
|
// Copyright 2017 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "components/zucchini/rel32_finder.h"
#include <stddef.h>
#include <stdint.h>
#include <algorithm>
#include <iterator>
#include <string>
#include <utility>
#include <vector>
#include "base/check_op.h"
#include "base/format_macros.h"
#include "base/strings/stringprintf.h"
#include "components/zucchini/buffer_view.h"
#include "components/zucchini/image_utils.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace zucchini {
TEST(Abs32GapFinderTest, All) {
const size_t kRegionTotal = 99;
std::vector<uint8_t> buffer(kRegionTotal);
ConstBufferView image(buffer.data(), buffer.size());
// Common test code that returns the resulting segments as a string.
auto run_test = [&](size_t rlo, size_t rhi,
std::vector<offset_t> abs32_locations,
std::ptrdiff_t abs32_width) -> std::string {
CHECK_LE(rlo, kRegionTotal);
CHECK_LE(rhi, kRegionTotal);
CHECK(std::is_sorted(abs32_locations.begin(), abs32_locations.end()));
CHECK_GT(abs32_width, 0);
ConstBufferView region =
ConstBufferView::FromRange(image.begin() + rlo, image.begin() + rhi);
Abs32GapFinder gap_finder(image, region, abs32_locations, abs32_width);
std::string out_str;
for (auto gap = gap_finder.GetNext(); gap; gap = gap_finder.GetNext()) {
size_t lo = static_cast<size_t>(gap->begin() - image.begin());
size_t hi = static_cast<size_t>(gap->end() - image.begin());
out_str.append(base::StringPrintf("[%" PRIuS ",%" PRIuS ")", lo, hi));
}
return out_str;
};
// Empty regions yield empty segments.
EXPECT_EQ("", run_test(0, 0, std::vector<offset_t>(), 4));
EXPECT_EQ("", run_test(9, 9, std::vector<offset_t>(), 4));
EXPECT_EQ("", run_test(8, 8, {8}, 4));
EXPECT_EQ("", run_test(8, 8, {0, 12}, 4));
// If no abs32 locations exist then the segment is the main range.
EXPECT_EQ("[0,99)", run_test(0, 99, std::vector<offset_t>(), 4));
EXPECT_EQ("[20,21)", run_test(20, 21, std::vector<offset_t>(), 4));
EXPECT_EQ("[51,55)", run_test(51, 55, std::vector<offset_t>(), 4));
// abs32 locations found near start of main range.
EXPECT_EQ("[10,20)", run_test(10, 20, {5}, 4));
EXPECT_EQ("[10,20)", run_test(10, 20, {6}, 4));
EXPECT_EQ("[11,20)", run_test(10, 20, {7}, 4));
EXPECT_EQ("[12,20)", run_test(10, 20, {8}, 4));
EXPECT_EQ("[13,20)", run_test(10, 20, {9}, 4));
EXPECT_EQ("[14,20)", run_test(10, 20, {10}, 4));
EXPECT_EQ("[10,11)[15,20)", run_test(10, 20, {11}, 4));
// abs32 locations found near end of main range.
EXPECT_EQ("[10,15)[19,20)", run_test(10, 20, {15}, 4));
EXPECT_EQ("[10,16)", run_test(10, 20, {16}, 4));
EXPECT_EQ("[10,17)", run_test(10, 20, {17}, 4));
EXPECT_EQ("[10,18)", run_test(10, 20, {18}, 4));
EXPECT_EQ("[10,19)", run_test(10, 20, {19}, 4));
EXPECT_EQ("[10,20)", run_test(10, 20, {20}, 4));
EXPECT_EQ("[10,20)", run_test(10, 20, {21}, 4));
// Main range completely eclipsed by abs32 location.
EXPECT_EQ("", run_test(10, 11, {7}, 4));
EXPECT_EQ("", run_test(10, 11, {8}, 4));
EXPECT_EQ("", run_test(10, 11, {9}, 4));
EXPECT_EQ("", run_test(10, 11, {10}, 4));
EXPECT_EQ("", run_test(10, 12, {8}, 4));
EXPECT_EQ("", run_test(10, 12, {9}, 4));
EXPECT_EQ("", run_test(10, 12, {10}, 4));
EXPECT_EQ("", run_test(10, 13, {9}, 4));
EXPECT_EQ("", run_test(10, 13, {10}, 4));
EXPECT_EQ("", run_test(10, 14, {10}, 4));
EXPECT_EQ("", run_test(10, 14, {8, 12}, 4));
// Partial eclipses.
EXPECT_EQ("[24,25)", run_test(20, 25, {20}, 4));
EXPECT_EQ("[20,21)", run_test(20, 25, {21}, 4));
EXPECT_EQ("[20,21)[25,26)", run_test(20, 26, {21}, 4));
// abs32 location outside main range.
EXPECT_EQ("[40,60)", run_test(40, 60, {36, 60}, 4));
EXPECT_EQ("[41,61)", run_test(41, 61, {0, 10, 20, 30, 34, 62, 68, 80}, 4));
// Change abs32 width.
EXPECT_EQ("[10,11)[12,14)[16,19)", run_test(10, 20, {9, 11, 14, 15, 19}, 1));
EXPECT_EQ("", run_test(10, 11, {10}, 1));
EXPECT_EQ("[18,23)[29,31)", run_test(17, 31, {15, 23, 26, 31}, 3));
EXPECT_EQ("[17,22)[25,26)[29,30)", run_test(17, 31, {14, 22, 26, 30}, 3));
EXPECT_EQ("[10,11)[19,20)", run_test(10, 20, {11}, 8));
// Mixed cases with abs32 width = 4.
EXPECT_EQ("[10,15)[19,20)[24,25)", run_test(8, 25, {2, 6, 15, 20, 27}, 4));
EXPECT_EQ("[0,25)[29,45)[49,50)", run_test(0, 50, {25, 45}, 4));
EXPECT_EQ("[10,20)[28,50)", run_test(10, 50, {20, 24}, 4));
EXPECT_EQ("[49,50)[54,60)[64,70)[74,80)[84,87)",
run_test(49, 87, {10, 20, 30, 40, 50, 60, 70, 80, 90}, 4));
EXPECT_EQ("[0,10)[14,20)[24,25)[29,50)", run_test(0, 50, {10, 20, 25}, 4));
}
namespace {
// A mock Rel32Finder to inject next search result on Scan().
class TestRel32Finder : public Rel32Finder {
public:
using Rel32Finder::Rel32Finder;
// Rel32Finder:
NextIterators Scan(ConstBufferView region) override { return next_result; }
bool GetNext() { return FindNext(); }
NextIterators next_result;
};
} // namespace
TEST(Rel32FinderTest, Scan) {
const size_t kRegionTotal = 99;
std::vector<uint8_t> buffer(kRegionTotal);
ConstBufferView image(buffer.data(), buffer.size());
TestRel32Finder finder;
finder.SetRegion(image);
auto check_finder_state = [&](const TestRel32Finder& finder,
size_t expected_cursor,
size_t expected_accept_it) {
CHECK_LE(expected_cursor, kRegionTotal);
CHECK_LE(expected_accept_it, kRegionTotal);
EXPECT_EQ(image.begin() + expected_cursor, finder.region().begin());
EXPECT_EQ(image.begin() + expected_accept_it, finder.accept_it());
};
check_finder_state(finder, 0, 0);
finder.next_result = {image.begin() + 1, image.begin() + 1};
EXPECT_TRUE(finder.GetNext());
check_finder_state(finder, 1, 1);
finder.next_result = {image.begin() + 2, image.begin() + 2};
EXPECT_TRUE(finder.GetNext());
check_finder_state(finder, 2, 2);
finder.next_result = {image.begin() + 5, image.begin() + 6};
EXPECT_TRUE(finder.GetNext());
check_finder_state(finder, 5, 6);
finder.Accept();
check_finder_state(finder, 6, 6);
finder.next_result = {image.begin() + 7, image.begin() + 7};
EXPECT_TRUE(finder.GetNext());
check_finder_state(finder, 7, 7);
finder.next_result = {image.begin() + 8, image.begin() + 8};
EXPECT_TRUE(finder.GetNext());
check_finder_state(finder, 8, 8);
finder.next_result = {image.begin() + 99, image.begin() + 99};
EXPECT_TRUE(finder.GetNext());
check_finder_state(finder, 99, 99);
finder.next_result = {nullptr, nullptr};
EXPECT_FALSE(finder.GetNext());
check_finder_state(finder, 99, 99);
}
TEST(Rel32FinderX86Test, FindNext) {
constexpr uint8_t data[] = {
0x55, // 00: push ebp
0x8B, 0xEC, // 01: mov ebp,esp
0xE8, 0x00, 0x00, 0x00, 0x00, // 03: call 08
0xE9, 0x00, 0x00, 0x00, 0x00, // 08: jmp 0D
0x0F, 0x80, 0x00, 0x00, 0x00, 0x00, // 0D: jo 13
0x0F, 0x81, 0x00, 0x00, 0x00, 0x00, // 13: jno 19
0x0F, 0x82, 0x00, 0x00, 0x00, 0x00, // 19: jb 1F
0x0F, 0x83, 0x00, 0x00, 0x00, 0x00, // 1F: jae 25
0x0F, 0x84, 0x00, 0x00, 0x00, 0x00, // 25: je 2B
0x0F, 0x85, 0x00, 0x00, 0x00, 0x00, // 2B: jne 31
0x0F, 0x86, 0x00, 0x00, 0x00, 0x00, // 31: jbe 37
0x0F, 0x87, 0x00, 0x00, 0x00, 0x00, // 37: ja 3D
0x0F, 0x88, 0x00, 0x00, 0x00, 0x00, // 3D: js 43
0x0F, 0x89, 0x00, 0x00, 0x00, 0x00, // 43: jns 49
0x0F, 0x8A, 0x00, 0x00, 0x00, 0x00, // 49: jp 4F
0x0F, 0x8B, 0x00, 0x00, 0x00, 0x00, // 4F: jnp 55
0x0F, 0x8C, 0x00, 0x00, 0x00, 0x00, // 55: jl 5B
0x0F, 0x8D, 0x00, 0x00, 0x00, 0x00, // 5B: jge 61
0x0F, 0x8E, 0x00, 0x00, 0x00, 0x00, // 61: jle 67
0x0F, 0x8F, 0x00, 0x00, 0x00, 0x00, // 67: jg 6D
0x5D, // 6D: pop ebp
0xC3, // C3: ret
};
ConstBufferView image =
ConstBufferView::FromRange(std::begin(data), std::end(data));
Rel32FinderX86 rel_finder;
rel_finder.SetRegion(image);
// List of expected locations as pairs of {cursor offset, rel32 offset}.
std::vector<std::pair<size_t, size_t>> expected_locations = {
{0x04, 0x04}, {0x09, 0x09}, {0x0E, 0x0F}, {0x14, 0x15}, {0x1A, 0x1B},
{0x20, 0x21}, {0x26, 0x27}, {0x2C, 0x2D}, {0x32, 0x33}, {0x38, 0x39},
{0x3E, 0x3F}, {0x44, 0x45}, {0x4A, 0x4B}, {0x50, 0x51}, {0x56, 0x57},
{0x5C, 0x5D}, {0x62, 0x63}, {0x68, 0x69},
};
for (auto location : expected_locations) {
auto result = rel_finder.GetNext();
EXPECT_TRUE(result.has_value());
EXPECT_EQ(location.first,
size_t(rel_finder.region().begin() - image.begin()));
EXPECT_EQ(location.second, size_t(result->location - image.begin()));
EXPECT_EQ(result->location + 4, rel_finder.accept_it());
EXPECT_FALSE(result->can_point_outside_section);
rel_finder.Accept();
}
EXPECT_EQ(base::nullopt, rel_finder.GetNext());
}
TEST(Rel32FinderX86Test, Accept) {
constexpr uint8_t data[] = {
0xB9, 0x00, 0x00, 0x00, 0xE9, // 00: mov E9000000
0xE8, 0x00, 0x00, 0x00, 0xE9, // 05: call E900000A
0xE8, 0x00, 0x00, 0x00, 0xE9, // 0A: call E900000F
};
ConstBufferView image =
ConstBufferView::FromRange(std::begin(data), std::end(data));
auto next_location = [&](Rel32FinderX86& rel_finder) -> size_t {
auto result = rel_finder.GetNext();
EXPECT_TRUE(result.has_value());
return result->location - image.begin();
};
Rel32FinderX86 rel_finder;
rel_finder.SetRegion(image);
EXPECT_EQ(0x05U, next_location(rel_finder)); // False positive.
rel_finder.Accept();
// False negative: shadowed by 0x05
// EXPECT_EQ(0x06, next_location(rel_finder));
EXPECT_EQ(0x0AU, next_location(rel_finder)); // False positive.
EXPECT_EQ(0x0BU, next_location(rel_finder)); // Found if 0x0A is discarded.
}
TEST(Rel32FinderX64Test, FindNext) {
constexpr uint8_t data[] = {
0x55, // 00: push ebp
0x8B, 0xEC, // 01: mov ebp,esp
0xE8, 0x00, 0x00, 0x00, 0x00, // 03: call 08
0xE9, 0x00, 0x00, 0x00, 0x00, // 08: jmp 0D
0x0F, 0x80, 0x00, 0x00, 0x00, 0x00, // 0D: jo 13
0x0F, 0x81, 0x00, 0x00, 0x00, 0x00, // 13: jno 19
0x0F, 0x82, 0x00, 0x00, 0x00, 0x00, // 19: jb 1F
0x0F, 0x83, 0x00, 0x00, 0x00, 0x00, // 1F: jae 25
0x0F, 0x84, 0x00, 0x00, 0x00, 0x00, // 25: je 2B
0x0F, 0x85, 0x00, 0x00, 0x00, 0x00, // 2B: jne 31
0x0F, 0x86, 0x00, 0x00, 0x00, 0x00, // 31: jbe 37
0x0F, 0x87, 0x00, 0x00, 0x00, 0x00, // 37: ja 3D
0x0F, 0x88, 0x00, 0x00, 0x00, 0x00, // 3D: js 43
0x0F, 0x89, 0x00, 0x00, 0x00, 0x00, // 43: jns 49
0x0F, 0x8A, 0x00, 0x00, 0x00, 0x00, // 49: jp 4F
0x0F, 0x8B, 0x00, 0x00, 0x00, 0x00, // 4F: jnp 55
0x0F, 0x8C, 0x00, 0x00, 0x00, 0x00, // 55: jl 5B
0x0F, 0x8D, 0x00, 0x00, 0x00, 0x00, // 5B: jge 61
0x0F, 0x8E, 0x00, 0x00, 0x00, 0x00, // 61: jle 67
0x0F, 0x8F, 0x00, 0x00, 0x00, 0x00, // 67: jg 6F
0xFF, 0x15, 0x00, 0x00, 0x00, 0x00, // 6D: call [rip+00]
0xFF, 0x25, 0x00, 0x00, 0x00, 0x00, // 73: jmp [rip+00]
0x8B, 0x05, 0x00, 0x00, 0x00, 0x00, // 79: mov eax,[rip+00]
0x8B, 0x3D, 0x00, 0x00, 0x00, 0x00, // 7F: mov edi,[rip+00]
0x8D, 0x05, 0x00, 0x00, 0x00, 0x00, // 85: lea eax,[rip+00]
0x8D, 0x3D, 0x00, 0x00, 0x00, 0x00, // 8B: lea edi,[rip+00]
0x48, 0x8B, 0x05, 0x00, 0x00, 0x00, 0x00, // 91: mov rax,[rip+00]
0x48, 0x8B, 0x3D, 0x00, 0x00, 0x00, 0x00, // 98: mov rdi,[rip+00]
0x48, 0x8D, 0x05, 0x00, 0x00, 0x00, 0x00, // 9F: lea rax,[rip+00]
0x48, 0x8D, 0x3D, 0x00, 0x00, 0x00, 0x00, // A6: lea rdi,[rip+00]
0x4C, 0x8B, 0x05, 0x00, 0x00, 0x00, 0x00, // AD: mov r8,[rip+00]
0x4C, 0x8B, 0x3D, 0x00, 0x00, 0x00, 0x00, // B4: mov r15,[rip+00]
0x4C, 0x8D, 0x05, 0x00, 0x00, 0x00, 0x00, // BB: lea r8,[rip+00]
0x4C, 0x8D, 0x3D, 0x00, 0x00, 0x00, 0x00, // C2: lea r15,[rip+00]
0x66, 0x8B, 0x05, 0x00, 0x00, 0x00, 0x00, // C9: mov ax,[rip+00]
0x66, 0x8B, 0x3D, 0x00, 0x00, 0x00, 0x00, // D0: mov di,[rip+00]
0x66, 0x8D, 0x05, 0x00, 0x00, 0x00, 0x00, // D7: lea ax,[rip+00]
0x66, 0x8D, 0x3D, 0x00, 0x00, 0x00, 0x00, // DE: lea di,[rip+00]
0x5D, // E5: pop ebp
0xC3, // E6: ret
};
ConstBufferView image =
ConstBufferView::FromRange(std::begin(data), std::end(data));
Rel32FinderX64 rel_finder;
rel_finder.SetRegion(image);
// Lists of expected locations as pairs of {cursor offset, rel32 offset}.
std::vector<std::pair<size_t, size_t>> expected_locations = {
{0x04, 0x04}, {0x09, 0x09}, {0x0E, 0x0F}, {0x14, 0x15}, {0x1A, 0x1B},
{0x20, 0x21}, {0x26, 0x27}, {0x2C, 0x2D}, {0x32, 0x33}, {0x38, 0x39},
{0x3E, 0x3F}, {0x44, 0x45}, {0x4A, 0x4B}, {0x50, 0x51}, {0x56, 0x57},
{0x5C, 0x5D}, {0x62, 0x63}, {0x68, 0x69},
};
std::vector<std::pair<size_t, size_t>> expected_locations_rip = {
{0x6E, 0x6F}, {0x74, 0x75}, {0x7A, 0x7B}, {0x80, 0x81}, {0x86, 0x87},
{0x8C, 0x8D}, {0x93, 0x94}, {0x9A, 0x9B}, {0xA1, 0xA2}, {0xA8, 0xA9},
{0xAF, 0xB0}, {0xB6, 0xB7}, {0xBD, 0xBE}, {0xC4, 0xC5}, {0xCB, 0xCC},
{0xD2, 0xD3}, {0xD9, 0xDA}, {0xE0, 0xE1},
};
// Jump instructions, which cannot point outside section.
for (auto location : expected_locations) {
auto result = rel_finder.GetNext();
EXPECT_TRUE(result.has_value());
EXPECT_EQ(location.first,
size_t(rel_finder.region().begin() - image.begin()));
EXPECT_EQ(location.second, size_t(result->location - image.begin()));
EXPECT_EQ(result->location + 4, rel_finder.accept_it());
EXPECT_FALSE(result->can_point_outside_section);
rel_finder.Accept();
}
// PC-relative data access instructions, which can point outside section.
for (auto location : expected_locations_rip) {
auto result = rel_finder.GetNext();
EXPECT_TRUE(result.has_value());
EXPECT_EQ(location.first,
size_t(rel_finder.region().begin() - image.begin()));
EXPECT_EQ(location.second, size_t(result->location - image.begin()));
EXPECT_EQ(result->location + 4, rel_finder.accept_it());
EXPECT_TRUE(result->can_point_outside_section);
rel_finder.Accept();
}
EXPECT_EQ(base::nullopt, rel_finder.GetNext());
}
// TODO(huangs): Test that integrates Abs32GapFinder and Rel32Finder.
} // namespace zucchini
|
