summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMikhail Naganov <mnaganov@google.com>2017-10-24 14:44:43 -0700
committerandroid-build-team Robot <android-build-team-robot@google.com>2017-11-28 03:28:33 +0000
commitde7f50ee76ed5ed70d9174f23175287c1035b383 (patch)
tree9a4cb6a139e9da079f5670b38236b581e24ce16f
parentdd3ca4d6b81a9ae2ddf358b7b93d2f8c010921f5 (diff)
downloadav-de7f50ee76ed5ed70d9174f23175287c1035b383.tar.gz
Add EFFECT_CMD_SET_PARAM parameter checking to Preset Reverb
Bug: 67647856 Test: Added CTS tests Change-Id: I027ce8f7a1cdb8406ca423aaae7c45b6b76617f0 (cherry picked from commit ee804dfa15cc2d34e5d67a9b437cd023349d633b)
-rw-r--r--media/libeffects/lvm/wrapper/Reverb/EffectReverb.cpp4
1 files changed, 4 insertions, 0 deletions
diff --git a/media/libeffects/lvm/wrapper/Reverb/EffectReverb.cpp b/media/libeffects/lvm/wrapper/Reverb/EffectReverb.cpp
index ee9406dfd0..3d8e982132 100644
--- a/media/libeffects/lvm/wrapper/Reverb/EffectReverb.cpp
+++ b/media/libeffects/lvm/wrapper/Reverb/EffectReverb.cpp
@@ -1889,6 +1889,10 @@ int Reverb_setParameter (ReverbContext *pContext, void *pParam, void *pValue, in
if (param != REVERB_PARAM_PRESET) {
return -EINVAL;
}
+ if (vsize < (int)sizeof(uint16_t)) {
+ android_errorWriteLog(0x534e4554, "67647856");
+ return -EINVAL;
+ }
uint16_t preset = *(uint16_t *)pValue;
ALOGV("set REVERB_PARAM_PRESET, preset %d", preset);