diff options
author | Jean Chalard <jchalard@google.com> | 2023-02-09 02:20:20 +0000 |
---|---|---|
committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2023-02-09 02:20:20 +0000 |
commit | 5aa02e185cf452b84353eeb7cab1fde857a7421c (patch) | |
tree | 1669bb9dcd4aae2c44c706226ff239368e31aa82 | |
parent | af2ed4d5792622c6cbefd5076079d6f6fa5a5c84 (diff) | |
parent | 47283cc626d4abf5c0dfebdb0b1e095d9454cb8c (diff) | |
download | net-5aa02e185cf452b84353eeb7cab1fde857a7421c.tar.gz |
Merge "Remove expectCapabilitiesWith and without"
-rw-r--r-- | common/tests/unit/src/com/android/testutils/TestableNetworkCallbackTest.kt | 20 | ||||
-rw-r--r-- | common/testutils/devicetests/com/android/testutils/TestableNetworkCallback.kt | 14 |
2 files changed, 14 insertions, 20 deletions
diff --git a/common/tests/unit/src/com/android/testutils/TestableNetworkCallbackTest.kt b/common/tests/unit/src/com/android/testutils/TestableNetworkCallbackTest.kt index 5acdb347..d36f52a3 100644 --- a/common/tests/unit/src/com/android/testutils/TestableNetworkCallbackTest.kt +++ b/common/tests/unit/src/com/android/testutils/TestableNetworkCallbackTest.kt @@ -140,20 +140,28 @@ class TestableNetworkCallbackTest { val meteredNc = NetworkCapabilities() val unmeteredNc = NetworkCapabilities().addCapability(NOT_METERED) // Check that expecting caps (with or without) fails when no callback has been received. - assertFails { mCallback.expectCapabilitiesWith(NOT_METERED, matcher, SHORT_TIMEOUT_MS) } - assertFails { mCallback.expectCapabilitiesWithout(NOT_METERED, matcher, SHORT_TIMEOUT_MS) } + assertFails { + mCallback.expectCaps(matcher, SHORT_TIMEOUT_MS) { it.hasCapability(NOT_METERED) } + } + assertFails { + mCallback.expectCaps(matcher, SHORT_TIMEOUT_MS) { !it.hasCapability(NOT_METERED) } + } // Add NOT_METERED and check that With succeeds and Without fails. mCallback.onCapabilitiesChanged(net, unmeteredNc) - mCallback.expectCapabilitiesWith(NOT_METERED, matcher) + mCallback.expectCaps(matcher) { it.hasCapability(NOT_METERED) } mCallback.onCapabilitiesChanged(net, unmeteredNc) - assertFails { mCallback.expectCapabilitiesWithout(NOT_METERED, matcher, SHORT_TIMEOUT_MS) } + assertFails { + mCallback.expectCaps(matcher, SHORT_TIMEOUT_MS) { !it.hasCapability(NOT_METERED) } + } // Don't add NOT_METERED and check that With fails and Without succeeds. mCallback.onCapabilitiesChanged(net, meteredNc) - assertFails { mCallback.expectCapabilitiesWith(NOT_METERED, matcher, SHORT_TIMEOUT_MS) } + assertFails { + mCallback.expectCaps(matcher, SHORT_TIMEOUT_MS) { it.hasCapability(NOT_METERED) } + } mCallback.onCapabilitiesChanged(net, meteredNc) - mCallback.expectCapabilitiesWithout(NOT_METERED, matcher) + mCallback.expectCaps(matcher) { !it.hasCapability(NOT_METERED) } } @Test diff --git a/common/testutils/devicetests/com/android/testutils/TestableNetworkCallback.kt b/common/testutils/devicetests/com/android/testutils/TestableNetworkCallback.kt index d58d5824..533ec224 100644 --- a/common/testutils/devicetests/com/android/testutils/TestableNetworkCallback.kt +++ b/common/testutils/devicetests/com/android/testutils/TestableNetworkCallback.kt @@ -592,20 +592,6 @@ open class TestableNetworkCallback private constructor( valid: (NetworkCapabilities) -> Boolean ) = expect<CapabilitiesChanged>(ANY_NETWORK, tmt) { valid(it.caps) }.caps - @JvmOverloads - fun expectCapabilitiesWith( - capability: Int, - n: HasNetwork, - timeoutMs: Long = defaultTimeoutMs - ) = expectCaps(n, timeoutMs) { it.hasCapability(capability) } - - @JvmOverloads - fun expectCapabilitiesWithout( - capability: Int, - n: HasNetwork, - timeoutMs: Long = defaultTimeoutMs - ) = expectCaps(n, timeoutMs) { !it.hasCapability(capability) } - fun expectBlockedStatusCallback(expectBlocked: Boolean, n: HasNetwork) { expectBlockedStatusCallback(expectBlocked, n.network, defaultTimeoutMs) } |