aboutsummaryrefslogtreecommitdiff
path: root/java/com/android
diff options
context:
space:
mode:
authorKiwon Park <kiwonp@google.com>2022-10-05 01:59:43 +0000
committerKiwon Park <kiwonp@google.com>2022-10-06 15:31:51 -0700
commiteb47437d856a998e52692272c45439ffabd4d877 (patch)
tree66e22c5a3724f1d3882a1f9a4275c6d39ef22fe5 /java/com/android
parentcbcefac55fc855a5343697b300af608e340ac4d8 (diff)
downloadservice_entitlement-eb47437d856a998e52692272c45439ffabd4d877.tar.gz
Simplify debug HTTP response logging.
The full HTTP response content is already logged in getHttpResponse. Bug: 251302721 Test: m Change-Id: Ibbfd73b27455f5745fcd8bfeffc15115e458e6c1
Diffstat (limited to 'java/com/android')
-rw-r--r--java/com/android/libraries/entitlement/http/HttpClient.java2
-rw-r--r--java/com/android/libraries/entitlement/http/HttpResponse.java21
2 files changed, 22 insertions, 1 deletions
diff --git a/java/com/android/libraries/entitlement/http/HttpClient.java b/java/com/android/libraries/entitlement/http/HttpClient.java
index 39275e8..b501ffe 100644
--- a/java/com/android/libraries/entitlement/http/HttpClient.java
+++ b/java/com/android/libraries/entitlement/http/HttpClient.java
@@ -84,7 +84,7 @@ public class HttpClient {
}
mConnection.connect(); // This is to trigger SocketTimeoutException early
HttpResponse response = getHttpResponse(mConnection);
- Log.d(TAG, "HttpClient.response : " + response);
+ Log.d(TAG, "HttpClient.response : " + response.toShortDebugString());
if (mSaveHistory) {
mHistory.add(response.toString());
}
diff --git a/java/com/android/libraries/entitlement/http/HttpResponse.java b/java/com/android/libraries/entitlement/http/HttpResponse.java
index f76fdd6..142639e 100644
--- a/java/com/android/libraries/entitlement/http/HttpResponse.java
+++ b/java/com/android/libraries/entitlement/http/HttpResponse.java
@@ -73,4 +73,25 @@ public abstract class HttpResponse {
.setResponseMessage("")
.setCookies(ImmutableList.of());
}
+
+ /**
+ * Returns a short string representation for debugging purposes. Doesn't include the cookie or
+ * full body to prevent leaking sensitive data.
+ */
+ public String toShortDebugString() {
+ return new StringBuilder("HttpResponse{")
+ .append("contentType=")
+ .append(contentType())
+ .append(" body=(")
+ .append(body().length())
+ .append(" characters)")
+ .append(" responseCode=")
+ .append(responseCode())
+ .append(" responseMessage=")
+ .append(responseMessage())
+ .append(" cookies=[")
+ .append(cookies().size())
+ .append(" cookies]}")
+ .toString();
+ }
}