diff options
author | Felipe Leme <felipeal@google.com> | 2017-08-25 10:15:01 -0700 |
---|---|---|
committer | Felipe Leme <felipeal@google.com> | 2017-08-25 10:18:15 -0700 |
commit | 7fb8dee8e4a52771790b8e94a020579168615872 (patch) | |
tree | a2fcf20effc9a0fb10df096e5ee621aee67a2c5c | |
parent | 086a02a25f4e24be436411d7cbe86307ae0a6ad7 (diff) | |
download | native-7fb8dee8e4a52771790b8e94a020579168615872.tar.gz |
Fixed dumpstate_test_fixture so it runs on 64 bits as well.
Test: mmm -j32 frameworks/native/cmds/dumpstate/ && adb sync && \
adb shell /data/nativetest/dumpstate_test/dumpstate_test && \
adb shell /data/nativetest64/dumpstate_test/dumpstate_test
Fixes: 64954094
Change-Id: I47fa6a6dcee0c3386c5a9b574583d84b20d30661
-rw-r--r-- | cmds/dumpstate/Android.mk | 27 | ||||
-rw-r--r-- | cmds/dumpstate/tests/dumpstate_test.cpp | 2 | ||||
-rw-r--r-- | cmds/dumpstate/tests/testdata/empty-file.txt (renamed from cmds/dumpstate/testdata/empty-file.txt) | 0 | ||||
-rw-r--r-- | cmds/dumpstate/tests/testdata/multiple-lines-with-newline.txt (renamed from cmds/dumpstate/testdata/multiple-lines-with-newline.txt) | 0 | ||||
-rw-r--r-- | cmds/dumpstate/tests/testdata/multiple-lines.txt (renamed from cmds/dumpstate/testdata/multiple-lines.txt) | 0 | ||||
-rw-r--r-- | cmds/dumpstate/tests/testdata/single-line-with-newline.txt (renamed from cmds/dumpstate/testdata/single-line-with-newline.txt) | 0 | ||||
-rw-r--r-- | cmds/dumpstate/tests/testdata/single-line.txt (renamed from cmds/dumpstate/testdata/single-line.txt) | 0 | ||||
-rw-r--r-- | cmds/dumpstate/tests/testdata/stats-invalid-1st-NAN.txt (renamed from cmds/dumpstate/testdata/stats-invalid-1st-NAN.txt) | 0 | ||||
-rw-r--r-- | cmds/dumpstate/tests/testdata/stats-invalid-1st-negative.txt (renamed from cmds/dumpstate/testdata/stats-invalid-1st-negative.txt) | 0 | ||||
-rw-r--r-- | cmds/dumpstate/tests/testdata/stats-invalid-1st-too-big.txt (renamed from cmds/dumpstate/testdata/stats-invalid-1st-too-big.txt) | 0 | ||||
-rw-r--r-- | cmds/dumpstate/tests/testdata/stats-invalid-2nd-NAN.txt (renamed from cmds/dumpstate/testdata/stats-invalid-2nd-NAN.txt) | 0 | ||||
-rw-r--r-- | cmds/dumpstate/tests/testdata/stats-invalid-2nd-negative.txt (renamed from cmds/dumpstate/testdata/stats-invalid-2nd-negative.txt) | 0 | ||||
-rw-r--r-- | cmds/dumpstate/tests/testdata/stats-invalid-2nd-too-big.txt (renamed from cmds/dumpstate/testdata/stats-invalid-2nd-too-big.txt) | 0 | ||||
-rw-r--r-- | cmds/dumpstate/tests/testdata/stats-invalid-both-NAN.txt (renamed from cmds/dumpstate/testdata/stats-invalid-both-NAN.txt) | 0 | ||||
-rw-r--r-- | cmds/dumpstate/tests/testdata/stats-one-run-no-newline.txt (renamed from cmds/dumpstate/testdata/stats-one-run-no-newline.txt) | 0 | ||||
-rw-r--r-- | cmds/dumpstate/tests/testdata/stats-two-runs.txt (renamed from cmds/dumpstate/testdata/stats-two-runs.txt) | 0 |
16 files changed, 2 insertions, 27 deletions
diff --git a/cmds/dumpstate/Android.mk b/cmds/dumpstate/Android.mk index a96033309c..ea5fbf1ae2 100644 --- a/cmds/dumpstate/Android.mk +++ b/cmds/dumpstate/Android.mk @@ -17,31 +17,6 @@ LOCAL_ADDITIONAL_DEPENDENCIES := $(LOCAL_PATH)/Android.mk LOCAL_SRC_FILES := \ tests/dumpstate_test_fixture.cpp -LOCAL_MODULE_CLASS := NATIVE_TESTS - -dumpstate_tests_intermediates := $(local-intermediates-dir)/DATA -dumpstate_tests_subpath_from_data := nativetest/dumpstate_test_fixture -dumpstate_tests_root_in_device := /data/$(dumpstate_tests_subpath_from_data) -dumpstate_tests_root_for_test_zip := $(dumpstate_tests_intermediates)/$(dumpstate_tests_subpath_from_data) -testdata_files := $(call find-subdir-files, testdata/*) - -# Copy test data files to intermediates/DATA for use with LOCAL_PICKUP_FILES -GEN := $(addprefix $(dumpstate_tests_root_for_test_zip)/, $(testdata_files)) -$(GEN): PRIVATE_PATH := $(LOCAL_PATH) -$(GEN): PRIVATE_CUSTOM_TOOL = cp $< $@ -$(GEN): $(dumpstate_tests_root_for_test_zip)/testdata/% : $(LOCAL_PATH)/testdata/% - $(transform-generated-source) -LOCAL_GENERATED_SOURCES += $(GEN) - -# Copy test data files again to $OUT/data so the tests can be run with adb sync -# TODO: the build system should do this automatically -GEN := $(addprefix $(TARGET_OUT_DATA)/$(dumpstate_tests_subpath_from_data)/, $(testdata_files)) -$(GEN): PRIVATE_PATH := $(LOCAL_PATH) -$(GEN): PRIVATE_CUSTOM_TOOL = cp $< $@ -$(GEN): $(TARGET_OUT_DATA)/$(dumpstate_tests_subpath_from_data)/testdata/% : $(LOCAL_PATH)/testdata/% - $(transform-generated-source) -LOCAL_GENERATED_SOURCES += $(GEN) - -LOCAL_PICKUP_FILES := $(dumpstate_tests_intermediates) +LOCAL_TEST_DATA := $(call find-test-data-in-subdirs, $(LOCAL_PATH), *, tests/testdata) include $(BUILD_NATIVE_TEST) diff --git a/cmds/dumpstate/tests/dumpstate_test.cpp b/cmds/dumpstate/tests/dumpstate_test.cpp index 1c192680fe..a94cf9978a 100644 --- a/cmds/dumpstate/tests/dumpstate_test.cpp +++ b/cmds/dumpstate/tests/dumpstate_test.cpp @@ -94,7 +94,7 @@ class DumpstateBaseTest : public Test { protected: const std::string kTestPath = dirname(android::base::GetExecutablePath().c_str()); const std::string kFixturesPath = kTestPath + "/../dumpstate_test_fixture/"; - const std::string kTestDataPath = kFixturesPath + "/testdata/"; + const std::string kTestDataPath = kFixturesPath + "tests/testdata/"; const std::string kSimpleCommand = kFixturesPath + "dumpstate_test_fixture"; const std::string kEchoCommand = "/system/bin/echo"; diff --git a/cmds/dumpstate/testdata/empty-file.txt b/cmds/dumpstate/tests/testdata/empty-file.txt index e69de29bb2..e69de29bb2 100644 --- a/cmds/dumpstate/testdata/empty-file.txt +++ b/cmds/dumpstate/tests/testdata/empty-file.txt diff --git a/cmds/dumpstate/testdata/multiple-lines-with-newline.txt b/cmds/dumpstate/tests/testdata/multiple-lines-with-newline.txt index 7b7a187ff4..7b7a187ff4 100644 --- a/cmds/dumpstate/testdata/multiple-lines-with-newline.txt +++ b/cmds/dumpstate/tests/testdata/multiple-lines-with-newline.txt diff --git a/cmds/dumpstate/testdata/multiple-lines.txt b/cmds/dumpstate/tests/testdata/multiple-lines.txt index bead1030b9..bead1030b9 100644 --- a/cmds/dumpstate/testdata/multiple-lines.txt +++ b/cmds/dumpstate/tests/testdata/multiple-lines.txt diff --git a/cmds/dumpstate/testdata/single-line-with-newline.txt b/cmds/dumpstate/tests/testdata/single-line-with-newline.txt index cb48c8263d..cb48c8263d 100644 --- a/cmds/dumpstate/testdata/single-line-with-newline.txt +++ b/cmds/dumpstate/tests/testdata/single-line-with-newline.txt diff --git a/cmds/dumpstate/testdata/single-line.txt b/cmds/dumpstate/tests/testdata/single-line.txt index 2f64046c45..2f64046c45 100644 --- a/cmds/dumpstate/testdata/single-line.txt +++ b/cmds/dumpstate/tests/testdata/single-line.txt diff --git a/cmds/dumpstate/testdata/stats-invalid-1st-NAN.txt b/cmds/dumpstate/tests/testdata/stats-invalid-1st-NAN.txt index dad9fe8182..dad9fe8182 100644 --- a/cmds/dumpstate/testdata/stats-invalid-1st-NAN.txt +++ b/cmds/dumpstate/tests/testdata/stats-invalid-1st-NAN.txt diff --git a/cmds/dumpstate/testdata/stats-invalid-1st-negative.txt b/cmds/dumpstate/tests/testdata/stats-invalid-1st-negative.txt index 4facef9518..4facef9518 100644 --- a/cmds/dumpstate/testdata/stats-invalid-1st-negative.txt +++ b/cmds/dumpstate/tests/testdata/stats-invalid-1st-negative.txt diff --git a/cmds/dumpstate/testdata/stats-invalid-1st-too-big.txt b/cmds/dumpstate/tests/testdata/stats-invalid-1st-too-big.txt index 42508f143c..42508f143c 100644 --- a/cmds/dumpstate/testdata/stats-invalid-1st-too-big.txt +++ b/cmds/dumpstate/tests/testdata/stats-invalid-1st-too-big.txt diff --git a/cmds/dumpstate/testdata/stats-invalid-2nd-NAN.txt b/cmds/dumpstate/tests/testdata/stats-invalid-2nd-NAN.txt index a23ba2c76a..a23ba2c76a 100644 --- a/cmds/dumpstate/testdata/stats-invalid-2nd-NAN.txt +++ b/cmds/dumpstate/tests/testdata/stats-invalid-2nd-NAN.txt diff --git a/cmds/dumpstate/testdata/stats-invalid-2nd-negative.txt b/cmds/dumpstate/tests/testdata/stats-invalid-2nd-negative.txt index dd529b4d50..dd529b4d50 100644 --- a/cmds/dumpstate/testdata/stats-invalid-2nd-negative.txt +++ b/cmds/dumpstate/tests/testdata/stats-invalid-2nd-negative.txt diff --git a/cmds/dumpstate/testdata/stats-invalid-2nd-too-big.txt b/cmds/dumpstate/tests/testdata/stats-invalid-2nd-too-big.txt index b148b46614..b148b46614 100644 --- a/cmds/dumpstate/testdata/stats-invalid-2nd-too-big.txt +++ b/cmds/dumpstate/tests/testdata/stats-invalid-2nd-too-big.txt diff --git a/cmds/dumpstate/testdata/stats-invalid-both-NAN.txt b/cmds/dumpstate/tests/testdata/stats-invalid-both-NAN.txt index 4a9466d5d7..4a9466d5d7 100644 --- a/cmds/dumpstate/testdata/stats-invalid-both-NAN.txt +++ b/cmds/dumpstate/tests/testdata/stats-invalid-both-NAN.txt diff --git a/cmds/dumpstate/testdata/stats-one-run-no-newline.txt b/cmds/dumpstate/tests/testdata/stats-one-run-no-newline.txt index 0aef60ca08..0aef60ca08 100644 --- a/cmds/dumpstate/testdata/stats-one-run-no-newline.txt +++ b/cmds/dumpstate/tests/testdata/stats-one-run-no-newline.txt diff --git a/cmds/dumpstate/testdata/stats-two-runs.txt b/cmds/dumpstate/tests/testdata/stats-two-runs.txt index 9af123310d..9af123310d 100644 --- a/cmds/dumpstate/testdata/stats-two-runs.txt +++ b/cmds/dumpstate/tests/testdata/stats-two-runs.txt |