summaryrefslogtreecommitdiff
path: root/services/surfaceflinger
AgeCommit message (Collapse)Author
2020-01-21CE: Cleanups for conversion warningsLloyd Pique
1) If converting from float to int, adds an explicit cast as well as considers rounding. 2) Adjust some arguments from int32_t to uint32_t where that makes sense. 3) Adds explicit casts from int32_t to uint32_t where a cast is necessary. 4) Converts constants used in the tests to the right type (float instead of double, unsigned instead of signed). Test: Builds with "-Wconversion" enabled locally Bug: 129481165 Change-Id: I405af72c22f37865537bdefa3f589b4b2930f56c
2020-01-18Revert "Revert "[TimeStats] Add callback for global stats""Alec Mouri
This reverts commit de64c56f39b03f4908200d1ed2fdc9561f86fe2a. Reason for revert: Rolling forward with fix Test: adb shell cmd stats pull-source 10062 Change-Id: I981b12a1c5e69aad0c0d3a409d8b90b3399401f4
2020-01-18Merge "Plumb getClientTargetProperty API."Peiyong Lin
2020-01-17Merge "Adding support for the setFrameRate() API to SurfaceFlinger path"Steven Thomas
2020-01-16Adding support for the setFrameRate() API to SurfaceFlinger pathSteven Thomas
- When choosing the max refresh rate in Layer History, check if the layer has the bit set, if so use it. - Disable touch boost/choosing config with max refresh rate, when the layer has framerate set. Test: Run unit test. Observe logs. Test: Extend unit test to 10sec. Tap on screen while it's running. Observe logs. Tap, should not reset the max refresh rate. Change-Id: Ibe2689964c9f92788ace1b08c3521f156cb47524
2020-01-17Merge "Make setActiveConfig() private, remove plumbing"Steven Thomas
2020-01-16SurfaceFlinger: disable -Wconversion for SetFrameRate_test.cppAdy Abraham
Test: build Bug: 147835296 Change-Id: Iffa7674a4e1d92b9e5a84fac49806daac7feed5d
2020-01-17Merge "Add plumbing for upcoming setFrameRate() api"Steven Thomas
2020-01-16SurfaceFlinger: disable -Wconversion for RefreshRateSelectionTest.cppAdy Abraham
Test: build Bug: 147835296 Change-Id: I7b53296cfc31ea5cef88448f8480ad67842741bd
2020-01-16Merge "SurfaceFlinger: Enable -WConversion in Android.bp"Ady Abraham
2020-01-16Add plumbing for upcoming setFrameRate() apiSteven Thomas
Add plumbing from the app to surface flinger for the ANativeWindow_setFrameRate() and ASurfaceTransaction_setFrameRate() api calls we'll be adding soon. We don't do anything in surface flinger with this data yet. Bug: 143912624 Test: Added a new test, SetFrameRateTest. Change-Id: I1cab87f3ce5afca4591a39d8e7a42cb1e86a368f
2020-01-16Merge "SF Generalization of Refresh Rates: Adding layer priority hint"Ana Krulec
2020-01-16Revert "[TimeStats] Add callback for global stats"Alec Mouri
This reverts commit d5065451af373b954ee660d26d0fbf7b68f4c539. Reason for revert: submission of I6d395237082337a22f37190343a1fc59703d39bf raced with this change's presubmit, causing a build breakage. Change-Id: I5fbb1b0e93340b6a4cd99e4731d69e0fb17e5c14
2020-01-15[TimeStats] Add callback for global statsAlec Mouri
Now that the new statsd api is completed, we can implement the puller logic in TimeStats instead of in statsd's code. Bug: 119885568 Test: adb shell cmd stats pull-source 10062 Change-Id: Ic90ec5ddc082160bd7e784becf8bf3c3a99ef971
2020-01-15SF Generalization of Refresh Rates: Adding layer priority hintAna Krulec
Test: Device boots. Observe logs for errors. Test: Open Swappy and Chrome in split screen, tap between apps, SF prints the correct priority. Test: Open Chrome, play video. SF prints correct priority. Test: SF prints the correct priority received. Bug: 142507166 Change-Id: I5fa8a857c950db01f42a380a72d098039badc289
2020-01-15Merge "SF: VSyncReactor: correct distribute timestamp"TreeHugger Robot
2020-01-15Merge "Add steventhomas to surface flinger owners file" am: 451f3b5175 am: ↵Automerger Merge Worker
00007148ce am: 33b06fe7e9 Change-Id: I9c5760115794b46559f62cf1aacdadffc9b3966a
2020-01-15Merge "Add steventhomas to surface flinger owners file" am: 451f3b5175 am: ↵Automerger Merge Worker
00007148ce Change-Id: Ie98e973e09760862c919cc16a0c43b232c191960
2020-01-15SurfaceFlinger: Enable -WConversion in Android.bpAdy Abraham
Enable global -WConversion in Android.bp and turn it off in individual files. This is the first step to enable -WConversion in SurfaceFlinger. Test: boot Bug: 129481165 Change-Id: Ia752df39ef380bde71705a32582d618242c466f7
2020-01-15Merge "Reapply Avoid sending powerhint right after GPU composition."TreeHugger Robot
2020-01-15SF: VSyncReactor: correct distribute timestampKevin DuBois
Timestamp being distributed via the choreographer callback was the anticipated vsync timestamp. This might make sense in the future, but the correct legacy behavior was to distribute the event timestamp. (code with problem was flagged off) Test: correction of 2 unit tests Test: boot to home Test: uibench scroll, jitter not observed. Fixes: 147487378 Change-Id: I142a6eaf849479dfe5b754db138f55d9e5870afd
2020-01-15Merge "TimeStats: refactor libtimestats blueprint interface"TreeHugger Robot
2020-01-15Merge "Don't add offscreen layer twice to proto."Chavi Weingarten
2020-01-14Reapply Avoid sending powerhint right after GPU composition.Lloyd Pique
The change in 8ec87f8c6d72084c919d99680ee770bf1635cd26 was unintentionally dropped in moving the code to CompositionEngine. Bug: 147398431 Test: atest libcomposition_test Test: go/wm-smoke Test CtsColorModeTestCases CtsDisplayTestCases CtsGraphicsTestCases CtsMediaTestCases CtsUiRenderingTestCases CtsViewTestCases Change-Id: Ia652c04abf6e5094b399483948553f2aaffd0aea
2020-01-14Don't add offscreen layer twice to proto.chaviw
Fixes: 147691800 Test: Only one offscreen layer per id in dump Change-Id: I9c741e87531ec0ed166dd1cdafc0961e243d1c96
2020-01-14Add steventhomas to surface flinger owners fileSteven Thomas
Bug: - Test: -
2020-01-14Merge "Add layers to proto by traversing children"Chavi Weingarten
2020-01-13TimeStats: refactor libtimestats blueprint interfaceYiwei Zhang
Test: build, flash and boot Change-Id: I7c3a3a4496a1d0c031abeff23f8dad07f804baf4
2020-01-14Merge "ui: Deduplicate rotation types"TreeHugger Robot
2020-01-13Plumb getClientTargetProperty API.Peiyong Lin
getClientTargetProperty will give hardware composer the ability to request some properties of the client target that hardware composer wants. Prior to this API, the client will does its best to produce the client target of which the properties are pretty much fixed. This patch implements the parsing of SET_CLIENT_TARGET_PROPERTY command in order to get the client target property from hardware composer. BUG: b/145968912 Test: m -j32 Change-Id: I3e738b2617e4472c7876aa283c0964e2240b144b
2020-01-13Add layers to proto by traversing childrenchaviw
There are currently some layers that end up missing from the proto dumps since their relativeOf layer has been deleted. That means the layers are still in memory, but not traversable since we skip layers that have a relativeOf when traversing. Instead, we can traverse the children directly. Test: Layers will missing relativeOf are adding to proto Change-Id: I571ef677de0544dfe7459080cf97ff193e8666e6
2020-01-13Merge "SF: VSyncReactor ensure period change confirmation"TreeHugger Robot
2020-01-13Merge "Add vhau@ to OWNERS of SurfaceFlinger" am: dd3a7cd6a7 am: 15647a6295 ↵Automerger Merge Worker
am: 977d9d528d Change-Id: Icad040fee6e94b7c02e8161c0e2fc92841f0f552
2020-01-13Merge "SurfaceFlinger: Make LayerHistory virtual class"TreeHugger Robot
2020-01-13Merge "Add vhau@ to OWNERS of SurfaceFlinger" am: dd3a7cd6a7 am: 15647a6295Automerger Merge Worker
Change-Id: Id892f625af2171cf1153379f4208909fd4a1086a
2020-01-11Merge "unlinkToDeath only when the listener has no more callbacks"TreeHugger Robot
2020-01-11SurfaceFlinger: Make LayerHistory virtual classAdy Abraham
This is a base CL for refresh rate selection algorithm enhancements by allowing a different implementation of LayerHistory which will be controlled by a switch. Test: watch 24fps video and observe refresh rate at 60Hz Bug: 147516364 Change-Id: Ifd12f6683bc96cd5aba04a8960b9235729820b49
2020-01-11Merge "SurfaceFlinger: plumb composer 2.4 onSeamlessPossible"Ady Abraham
2020-01-10Add vhau@ to OWNERS of SurfaceFlingerValerie Hau
Bug: N/A Test: N/A
2020-01-10SF: VSyncReactor ensure period change confirmationKevin DuBois
(Code being corrected is flagged off, no production problems) When a period change is happening, system turns on hwvsync and uses the first vsync signal timed at the new vsync rate as confirmation that the rate has indeed changed (and then things like modifying the offsets occurs). If a presentation fence was added to the VSyncReactor system before the first hwvsync sample arrived, this would result in the period never being confirmed, and would result in incorrect offsets and period estimations, resulting in bad jank scores. Test: 3 unit tests Test: uibench run Fixes: 147321414 Change-Id: Idbc87529e60333df5180de585dbba3525396562b
2020-01-10Merge "Force send callbacks when layer is detached"Valerie Hau
2020-01-10Merge "[TimeStats] clear frame duration and renderengine histograms"TreeHugger Robot
2020-01-10unlinkToDeath only when the listener has no more callbacksValerie Hau
Bug: N/A Test: build, boot, SurfaceFlinger_test Change-Id: I2bbca0f781897967a18731ade3a3b4724f16d361
2020-01-10Merge "SurfaceFlinger: use margin when comparing fps in PhaseOffsets"TreeHugger Robot
2020-01-10Merge "SurfaceFlinger: relative size RefreshRateOverlay"TreeHugger Robot
2020-01-10Merge "Revert "Add RefreshRateRangeTest to presubmit""Ana Krulec
2020-01-09Force send callbacks when layer is detachedValerie Hau
Bug: 141706317 Test: build, boot, ASurfaceControlTest, SurfaceFlinger_test, libsurfaceflinger_unittest, manual Change-Id: Ib3566905a2e46cbbf88a1c80300744db03c3b7c7
2020-01-09SurfaceFlinger: plumb composer 2.4 onSeamlessPossibleAdy Abraham
Plumb onSeamlessPossible callback to SurfaceFlinger. Test: rev up composer to 2.4 Bug: 141329414 Change-Id: I2166b8ea066002c76781aacbcc985f85f7c255a8
2020-01-09Revert "Add RefreshRateRangeTest to presubmit"Ana Krulec
This reverts commit c11a37b701dddced4e024b4312597f80d7ff1dcf. Reason for revert: - should be in the code Change-Id: Ifae80b9b2e60d2b7a32275b9620b5df3a0e78637
2020-01-09Merge "Extend ADataspace."Peiyong Lin