diff options
| author | Andy McFadden <fadden@android.com> | 2011-08-02 13:29:17 -0700 |
|---|---|---|
| committer | Andy McFadden <fadden@android.com> | 2011-08-02 13:29:17 -0700 |
| commit | 0304a16e191a2e2af8289c6e7e1ad9734a0dc06d (patch) | |
| tree | aa48a7b076116cae603cb9ee8abfbb58ca7424a5 | |
| parent | dce6a0a89883ab3e76212a11a5a889407887718f (diff) | |
| download | calendar-0304a16e191a2e2af8289c6e7e1ad9734a0dc06d.tar.gz | |
Fix a comment
RFC 5545 says the behavior is unspecified. This just updates
the comments (no code changes).
Bug 5075775
Change-Id: I87d131c260570e2990bb05f624c90f7d78a1eb89
| -rw-r--r-- | src/com/android/calendarcommon/RecurrenceProcessor.java | 5 | ||||
| -rw-r--r-- | tests/src/com/android/calendarcommon/RecurrenceProcessorTest.java | 2 |
2 files changed, 3 insertions, 4 deletions
diff --git a/src/com/android/calendarcommon/RecurrenceProcessor.java b/src/com/android/calendarcommon/RecurrenceProcessor.java index c3ebc29..577ac49 100644 --- a/src/com/android/calendarcommon/RecurrenceProcessor.java +++ b/src/com/android/calendarcommon/RecurrenceProcessor.java @@ -747,9 +747,8 @@ bysetpos: // inside the loop. It is important that count gets incremented exactly // once here or in the loop for dtstart. // - // TODO: this is only correct if DTSTART is synchronized with the recurrence rule. - // If e.g. DSTART is 2011/07/01 (a Friday), and the rule includes only "BYDAY=SA,SU", - // this will insert an incorrect entry. (Why is this being done?) + // NOTE: if DTSTART is not synchronized with the recurrence rule, the first instance + // we return will not fit the RRULE pattern. if (add && dtstartDateValue >= rangeStartDateValue && dtstartDateValue < rangeEndDateValue) { out.add(dtstartDateValue); diff --git a/tests/src/com/android/calendarcommon/RecurrenceProcessorTest.java b/tests/src/com/android/calendarcommon/RecurrenceProcessorTest.java index 2ca2d35..21d2d52 100644 --- a/tests/src/com/android/calendarcommon/RecurrenceProcessorTest.java +++ b/tests/src/com/android/calendarcommon/RecurrenceProcessorTest.java @@ -378,7 +378,7 @@ public class RecurrenceProcessorTest extends TestCase { null /* rdate */, null /* exrule */, null /* exdate */, "20060101T000000", "20101231T000000", new String[]{ - "20060101T100000", // TODO: this is wrong (bug in recurrence gen) + "20060101T100000", "20060113T100000", "20061013T100000", "20070413T100000", |