aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBrad Ebinger <breadley@google.com>2018-05-24 09:48:47 -0700
committerBrad Ebinger <breadley@google.com>2018-05-24 13:26:45 -0700
commitdf97867f425c58af459da176b0220354a3ee38a0 (patch)
tree463d61ce11d7f25a04e3b4aa77d70febb9fcc338
parent63ab34e7f5fad0230b48aa2717566f98ac06cbb7 (diff)
downloadims-df97867f425c58af459da176b0220354a3ee38a0.tar.gz
Fix editable roaming mode query bugpie-dev
We were querying whether or not the WFC mode was editable, instead of the WFC roaming mode. This was causing the issue where the user was unable to set WiFi preferred mode when the WFC mode was not editable. Bug: 80168790 Test: Manual Change-Id: I8895ee97e7917192305e8ad53fd4de9ce1bfca01
-rw-r--r--src/java/com/android/ims/ImsManager.java18
1 files changed, 7 insertions, 11 deletions
diff --git a/src/java/com/android/ims/ImsManager.java b/src/java/com/android/ims/ImsManager.java
index 7b22bebd..590ab5ac 100644
--- a/src/java/com/android/ims/ImsManager.java
+++ b/src/java/com/android/ims/ImsManager.java
@@ -995,17 +995,13 @@ public class ImsManager {
}
if (DBG) log("getWfcMode - setting=" + setting);
} else {
- // The WFC roaming mode is not editable, return the default setting in the
- // CarrierConfig, not the user set value.
- if (!getBooleanCarrierConfig(CarrierConfigManager.KEY_EDITABLE_WFC_MODE_BOOL)) {
- setting = getIntCarrierConfig(
- CarrierConfigManager.KEY_CARRIER_DEFAULT_WFC_IMS_ROAMING_MODE_INT);
-
- } else {
- setting = getSettingFromSubscriptionManager(
- SubscriptionManager.WFC_IMS_ROAMING_MODE,
- CarrierConfigManager.KEY_CARRIER_DEFAULT_WFC_IMS_ROAMING_MODE_INT);
- }
+ // The WFC roaming mode is set in the Settings UI to be the same as the WFC mode if the
+ // roaming mode is set to not "editable" (see
+ // CarrierConfigManager.KEY_EDITABLE_WFC_ROAMING_MODE_BOOL for explanation), so can't
+ // override those settings here by setting the WFC roaming mode to default, like above.
+ setting = getSettingFromSubscriptionManager(
+ SubscriptionManager.WFC_IMS_ROAMING_MODE,
+ CarrierConfigManager.KEY_CARRIER_DEFAULT_WFC_IMS_ROAMING_MODE_INT);
if (DBG) log("getWfcMode (roaming) - setting=" + setting);
}
return setting;