diff options
author | Brad Ebinger <breadley@google.com> | 2018-03-08 13:14:38 -0800 |
---|---|---|
committer | Brad Ebinger <breadley@google.com> | 2018-03-13 17:56:43 +0000 |
commit | 9ffeebf0c18148d2064d22cca8e548863163b9c6 (patch) | |
tree | 1ec9a0a0e4a14d0b8daf1787eaeb0a63f8ffe678 | |
parent | 84f10d7b6cb438dfcb82d8a585033db1f31701e3 (diff) | |
download | ims-9ffeebf0c18148d2064d22cca8e548863163b9c6.tar.gz |
Do not Lock on Registration and Config Query
ImsRegistration and ImsConfig interfaces do not
need to be locked on because they access a
TelephonyManager API independent of MmTelFeature
state.
Bug: 74119196
Test: Telephony Unit Tests
Change-Id: I458db42cd815f87f57eab6b13878532105297180
-rw-r--r-- | src/java/com/android/ims/MmTelFeatureConnection.java | 18 |
1 files changed, 6 insertions, 12 deletions
diff --git a/src/java/com/android/ims/MmTelFeatureConnection.java b/src/java/com/android/ims/MmTelFeatureConnection.java index 276688c4..5679591b 100644 --- a/src/java/com/android/ims/MmTelFeatureConnection.java +++ b/src/java/com/android/ims/MmTelFeatureConnection.java @@ -484,22 +484,16 @@ public class MmTelFeatureConnection { } public IImsConfig getConfigInterface() throws RemoteException { - synchronized (mLock) { - checkServiceIsReady(); - return getConfig(); - } + return getConfig(); } public @ImsRegistrationImplBase.ImsRegistrationTech int getRegistrationTech() - throws RemoteException { - synchronized (mLock) { - checkServiceIsReady(); - IImsRegistration registration = getRegistration(); - if (registration != null) { + throws RemoteException { + IImsRegistration registration = getRegistration(); + if (registration != null) { return registration.getRegistrationTechnology(); - } else { - return ImsRegistrationImplBase.REGISTRATION_TECH_NONE; - } + } else { + return ImsRegistrationImplBase.REGISTRATION_TECH_NONE; } } |