From 634f6e6ce92776ecc62640affc5267ab9f31e2e1 Mon Sep 17 00:00:00 2001 From: Atneya Nair Date: Tue, 17 May 2022 19:25:46 -0400 Subject: Update AudioEffect caller to new interface Test: Compiles Bug: 199156212 Change-Id: I55def4d5eda53f0e6867d882ff099d31f931fccd --- src/jni/rtp/AudioGroup.cpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/jni/rtp/AudioGroup.cpp b/src/jni/rtp/AudioGroup.cpp index eb3b18f..08e8933 100644 --- a/src/jni/rtp/AudioGroup.cpp +++ b/src/jni/rtp/AudioGroup.cpp @@ -855,10 +855,9 @@ bool AudioGroup::DeviceThread::threadLoop() if (mGroup->platformHasAec()) { aec = new AudioEffect(mGroup->mAttributionSource); aec->set(FX_IID_AEC, - NULL, - 0, - 0, - 0, + nullptr, // uid + 0, // priority + nullptr, // callback record->getSessionId(), AUDIO_IO_HANDLE_NONE); // record sessionId is sufficient. status_t status = aec->initCheck(); -- cgit v1.2.3 From e49db91a6fec61106f0604ec5eb19a3f5d89f0ce Mon Sep 17 00:00:00 2001 From: Michael Groover Date: Tue, 4 Oct 2022 17:11:32 -0500 Subject: Add unaudited exported flag to exposed runtime receivers Android T allows apps to declare a runtime receiver as not exported by invoking registerReceiver with a new RECEIVER_NOT_EXPORTED flag; receivers registered with this flag will only receive broadcasts from the platform and the app itself. However to ensure developers can properly protect their receivers, all apps targeting U or later registering a receiver for non-system broadcasts must specify either the exported or not exported flag when invoking #registerReceiver; if one of these flags is not provided, the platform will throw a SecurityException. This commit updates all the exposed receivers with a new RECEIVER_EXPORTED_UNAUDITED flag to maintain the existing behavior of exporting the receiver while also flagging the receiver for audit before the U release. Bug: 234659204 Test: Build Change-Id: Ie64de4dfa3dbe20e389539be1ba4105eb789b3ef --- src/java/com/android/server/sip/SipWakeupTimer.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/java/com/android/server/sip/SipWakeupTimer.java b/src/java/com/android/server/sip/SipWakeupTimer.java index 8122070..7ec8689 100644 --- a/src/java/com/android/server/sip/SipWakeupTimer.java +++ b/src/java/com/android/server/sip/SipWakeupTimer.java @@ -55,7 +55,7 @@ class SipWakeupTimer extends BroadcastReceiver { context.getSystemService(Context.ALARM_SERVICE); IntentFilter filter = new IntentFilter(getAction()); - context.registerReceiver(this, filter); + context.registerReceiver(this, filter, Context.RECEIVER_EXPORTED_UNAUDITED); mExecutor = executor; } -- cgit v1.2.3 From 3471f4cbb265bc98e3a8f4e8e4a600c2923d81e1 Mon Sep 17 00:00:00 2001 From: Tyler Gunn Date: Sat, 18 Feb 2023 01:15:31 +0000 Subject: Set logging for SipAudioCall to FALSE. This prevents potentially logging pii related to SIP. Test: Manual test. Fixes: 233606950 Change-Id: I93ffc133f4f4338d99ba625f17b96fe01c2284f7 --- src/java/android/net/sip/SipAudioCall.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/java/android/net/sip/SipAudioCall.java b/src/java/android/net/sip/SipAudioCall.java index 4d70017..fdbe7ba 100644 --- a/src/java/android/net/sip/SipAudioCall.java +++ b/src/java/android/net/sip/SipAudioCall.java @@ -61,7 +61,7 @@ import java.net.UnknownHostException; */ public class SipAudioCall { private static final String LOG_TAG = SipAudioCall.class.getSimpleName(); - private static final boolean DBG = true; + private static final boolean DBG = false; private static final boolean RELEASE_SOCKET = true; private static final boolean DONT_RELEASE_SOCKET = false; private static final int SESSION_TIMEOUT = 5; // in seconds -- cgit v1.2.3 From 572bfdb0380e304d023aedc42e3bb5fe4729c05f Mon Sep 17 00:00:00 2001 From: Andrew Solovay Date: Thu, 13 Apr 2023 21:16:19 +0000 Subject: docs: Fixing typos in doc comments Need to make some doc edits to verify our instructions for making reference doc fixes, so I ran the common_typos linter to identify some fixes to make. Only typo fixes, no meaningful changes to doc content (and no changes to code). Still worth making these changes, since the typos linter will raise warnings every time we try to publish updated docs. Bug: 278120741 Change-Id: I02c9eb59eabf16a5b862ae78670d31db6e1fc15f Test: [ABTD docs build: https://android-build.googleplex.com/builds/abtd/run/L39300000959916024] --- src/java/android/net/sip/SipAudioCall.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/java/android/net/sip/SipAudioCall.java b/src/java/android/net/sip/SipAudioCall.java index fdbe7ba..9894056 100644 --- a/src/java/android/net/sip/SipAudioCall.java +++ b/src/java/android/net/sip/SipAudioCall.java @@ -68,7 +68,7 @@ public class SipAudioCall { private static final int TRANSFER_TIMEOUT = 15; // in seconds /** Listener for events relating to a SIP call, such as when a call is being - * recieved ("on ringing") or a call is outgoing ("on calling"). + * received ("on ringing") or a call is outgoing ("on calling"). *

Many of these events are also received by {@link SipSession.Listener}.

*/ public static class Listener { -- cgit v1.2.3