diff options
| author | Maurice Lam <yukl@google.com> | 2016-11-23 11:37:38 -0800 |
|---|---|---|
| committer | Maurice Lam <yukl@google.com> | 2016-12-12 19:15:44 +0000 |
| commit | 63cdc5ccb7f1f61d0e752e38d7e57c690658a0ac (patch) | |
| tree | 34230542c2c90044ed27a92d804db8699b00b49e /library/main/res/values/styles.xml | |
| parent | e57bdc10c8e4a348c1410234e45346cf31215a34 (diff) | |
| download | setupwizard-63cdc5ccb7f1f61d0e752e38d7e57c690658a0ac.tar.gz | |
[SuwLib] Turn on fatal lint
Fix (or suppress) lint warnings and make it fatal again in the build
process.
Additionally, warnings are treated as errors now. If there are
warnings that are not applicable, add @SuppressLint or tools:ignore
to suppress the warning, so code reviewers can be aware of the lint
issue too.
Test: ./gradlew lint
Change-Id: I63c83ff1b95a0817dc2ac777adce0fa9f9ebd45a
Diffstat (limited to 'library/main/res/values/styles.xml')
| -rw-r--r-- | library/main/res/values/styles.xml | 20 |
1 files changed, 13 insertions, 7 deletions
diff --git a/library/main/res/values/styles.xml b/library/main/res/values/styles.xml index 731f5a1..e248515 100644 --- a/library/main/res/values/styles.xml +++ b/library/main/res/values/styles.xml @@ -28,7 +28,8 @@ <!-- Content styles --> - <style name="SuwContentFrame"> + <!-- Ignore UnusedResources: Used by clients --> + <style name="SuwContentFrame" tools:ignore="UnusedResources"> <item name="android:clipToPadding">false</item> <item name="android:paddingTop">@dimen/suw_content_frame_padding_top</item> <item name="android:paddingLeft">?attr/suwMarginSides</item> @@ -36,7 +37,8 @@ <item name="android:paddingBottom">@dimen/suw_content_frame_padding_bottom</item> </style> - <style name="SuwDescription"> + <!-- Ignore UnusedResources: Used by clients --> + <style name="SuwDescription" tools:ignore="UnusedResources"> <!-- Before Honeycomb, layout_gravity is needed for FrameLayout to apply the margins --> <item name="android:layout_gravity">top</item> <item name="android:layout_marginBottom">@dimen/suw_description_margin_bottom</item> @@ -45,7 +47,8 @@ <item name="android:textAppearance">@style/TextAppearance.SuwDescription</item> </style> - <style name="SuwDescription.Glif" parent="SuwDescription"> + <!-- Ignore UnusedResources: Used by clients --> + <style name="SuwDescription.Glif" parent="SuwDescription" tools:ignore="UnusedResources"> <item name="android:layout_marginTop">@dimen/suw_description_glif_margin_top</item> </style> @@ -57,7 +60,8 @@ <item name="android:textColor">?android:attr/textColorSecondary</item> </style> - <style name="SuwRadioButton"> + <!-- Ignore UnusedResources: Used by clients --> + <style name="SuwRadioButton" tools:ignore="UnusedResources"> <item name="android:layout_marginBottom">@dimen/suw_radio_button_margin_bottom</item> <item name="android:layout_marginLeft">@dimen/suw_radio_button_margin_start</item> <item name="android:layout_marginStart" tools:ignore="NewApi">@dimen/suw_radio_button_margin_start</item> @@ -68,7 +72,8 @@ <item name="android:textAppearance">@style/TextAppearance.SuwDescription</item> </style> - <style name="SuwCheckBox"> + <!-- Ignore UnusedResources: used by clients --> + <style name="SuwCheckBox" tools:ignore="UnusedResources"> <item name="android:layout_marginBottom">@dimen/suw_check_box_margin_bottom</item> <item name="android:layout_marginLeft">@dimen/suw_check_box_margin_start</item> <item name="android:layout_marginStart" tools:ignore="NewApi">@dimen/suw_check_box_margin_start</item> @@ -79,7 +84,8 @@ <item name="android:textAppearance">@style/TextAppearance.SuwDescription</item> </style> - <style name="SuwCheckBox.Multiline" parent="SuwCheckBox"> + <!-- Ignore UnusedResources: used by clients --> + <style name="SuwCheckBox.Multiline" parent="SuwCheckBox" tools:ignore="UnusedResources"> <item name="android:gravity">top</item> </style> @@ -103,7 +109,7 @@ <style name="SuwGlifCardContainer"> <item name="android:background">?android:attr/colorBackground</item> - <item name="android:elevation" tools:ignore="NewApi">5dp</item> + <item name="android:elevation" tools:ignore="NewApi">@dimen/suw_glif_card_elevation</item> </style> <!-- Header layout (for phones) --> |