summaryrefslogtreecommitdiff
path: root/tools
diff options
context:
space:
mode:
authorMaurice Lam <yukl@google.com>2017-05-12 18:05:25 -0700
committerMaurice Lam <yukl@google.com>2017-05-17 17:05:16 +0000
commit9395f90b26e072b2748db315aaffef27c257a82d (patch)
treeb0d16ef5339ce8391be36e7be922555dddb68b3d /tools
parent2da78450d5e9723ca93fa39bfdc3f8dd27b41e89 (diff)
downloadsetupwizard-9395f90b26e072b2748db315aaffef27c257a82d.tar.gz
Add IllustrationVideoView to setup wizard library
- Upstreamed setup wizard's IllustrationVideoView to SuwLib - Modified the view to automatically listen to window focus changes to play and pause the video - The view will now release the MediaPlayer as well in onSurfaceTextureDestroyed - Added checkstyle_suppression XML so it will ignore the "__constructor__" magic method name from the style check. Bug: 36584499 Test: ./gradlew connectedAndroidTest test Change-Id: Id045467d5d544a5f54464a0c938d3d56e758e455
Diffstat (limited to 'tools')
-rw-r--r--tools/checkstyle/checkstyle.xml20
-rw-r--r--tools/checkstyle/checkstyle_suppression.xml14
2 files changed, 34 insertions, 0 deletions
diff --git a/tools/checkstyle/checkstyle.xml b/tools/checkstyle/checkstyle.xml
new file mode 100644
index 0000000..0dbccae
--- /dev/null
+++ b/tools/checkstyle/checkstyle.xml
@@ -0,0 +1,20 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE module PUBLIC "-//Puppy Crawl//DTD Check Configuration 1.3//EN" "http://www.puppycrawl.com/dtds/configuration_1_3.dtd" [
+ <!ENTITY defaultCopyrightCheck SYSTEM "../../../../../prebuilts/checkstyle/default-copyright-check.xml">
+ <!ENTITY defaultJavadocChecks SYSTEM "../../../../../prebuilts/checkstyle/default-javadoc-checks.xml">
+ <!ENTITY defaultTreewalkerChecks SYSTEM "../../../../../prebuilts/checkstyle/default-treewalker-checks.xml">
+ <!ENTITY defaultModuleChecks SYSTEM "../../../../../prebuilts/checkstyle/default-module-checks.xml">
+]>
+
+<module name="Checker">
+ &defaultModuleChecks;
+ &defaultCopyrightCheck;
+ <module name="TreeWalker">
+ &defaultJavadocChecks;
+ &defaultTreewalkerChecks;
+ </module>
+
+ <module name="SuppressionFilter">
+ <property name="file" value="tools/checkstyle/checkstyle_suppression.xml" />
+ </module>
+</module>
diff --git a/tools/checkstyle/checkstyle_suppression.xml b/tools/checkstyle/checkstyle_suppression.xml
new file mode 100644
index 0000000..6bf7b21
--- /dev/null
+++ b/tools/checkstyle/checkstyle_suppression.xml
@@ -0,0 +1,14 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!DOCTYPE suppressions PUBLIC "-//Puppy Crawl//DTD Suppressions 1.1//EN" "http://www.puppycrawl.com/dtds/suppressions_1_1.dtd">
+<suppressions>
+
+ <!-- Note: Checkstyle puts the absolute path of files through the suppress filter, so the
+ patterns below will match sub-directories. Notably, for overlays where the path is
+ something like overlay/frameworks/opt/setupwizard will match the regex filter
+ "frameworks/opt/setupwizard". This is probably OK for most cases since they are overlay
+ of the original app and should have the same coding style. -->
+
+ <!-- Robolectric uses magic method names like `__constructor__` -->
+ <suppress files="/robotest/" checks="MethodName" />
+
+</suppressions>