Fix concurrency issues in ImsPhoneCall.

The class had a couple places where getFirstConnection() was referenced,
but it was possible for concurrent access to take place on the connection
between when getFirstConnection() was first called and when the return
value from it was referenced.  This was easy to fix by just storing the
instance of ImsPhoneConnection returned.

Fixes: 156168243
Test: Manual regression test for IMS phone calls.
Test: Add unit tests for get methods in question; can't really test the
concurrency in the test but can test basic operation.

Change-Id: I341fabf6e7cde869a7a8075f18ed15b593206471

1 files changed, 26 insertions, 0 deletions

diff --git a/tests/telephonytests/src/com/android/internal/telephony/imsphone/ImsPhoneCallTest.java b/tests/telephonytests/src/com/android/internal/telephony/imsphone/ImsPhoneCallTest.java
index 335f5a4a85..31fbfad319 100644
--- a/tests/telephonytests/src/com/android/internal/telephony/imsphone/ImsPhoneCallTest.java
+++ b/tests/telephonytests/src/com/android/internal/telephony/imsphone/ImsPhoneCallTest.java
@@ -30,6 +30,8 @@ import android.test.suitebuilder.annotation.SmallTest;
 
 import androidx.test.filters.FlakyTest;
 
+import com.android.ims.ImsCall;
+import com.android.ims.ImsException;
 import com.android.internal.telephony.Call;
 import com.android.internal.telephony.TelephonyTest;
 
@@ -183,4 +185,28 @@ public class ImsPhoneCallTest extends TelephonyTest {
         mImsCallUT.isMultiparty();
         verify(mImsCall, times(1)).isMultiparty();
     }
+
+    @Test
+    @SmallTest
+    public void testGetImsCall() {
+        doReturn(mImsCall).when(mConnection1).getImsCall();
+        mImsCallUT.attach(mConnection1, Call.State.ACTIVE);
+
+        ImsCall imsCall = mImsCallUT.getImsCall();
+        assertEquals(mImsCall, imsCall);
+    }
+
+    @Test
+    @SmallTest
+    public void testSetMute() {
+        doReturn(mImsCall).when(mConnection1).getImsCall();
+        mImsCallUT.attach(mConnection1, Call.State.ACTIVE);
+
+        mImsCallUT.setMute(true);
+        try {
+            verify(mImsCall).setMute(eq(true));
+        } catch (ImsException e) {
+            fail("Exception unexpected");
+        }
+    }
 }