diff options
| author | Chih-Hung Hsieh <chh@google.com> | 2016-07-01 11:05:04 -0700 |
|---|---|---|
| committer | Chih-Hung Hsieh <chh@google.com> | 2016-07-01 11:05:04 -0700 |
| commit | 4fcef498e1508f2f3a0b9332ea89b0064c2dc6e9 (patch) | |
| tree | 22b771cec7ec8afb72e3a631de1049baf8512f11 /driver | |
| parent | 428ea3e51e9e03069570db1c5f4fc61e29a9b0cb (diff) | |
| download | rs-4fcef498e1508f2f3a0b9332ea89b0064c2dc6e9.tar.gz | |
Fix clang-tidy warnings in frameworks/rs.
* Declare explicit conversion constructors.
* Add parentheses around macro arguments beside operators.
Bug: 28341362
Bug: 28705665
Change-Id: I2eef68ab0edd33f765bcc5dd73f6baf25b6f7585
Test: build with clang-tidy
Diffstat (limited to 'driver')
| -rw-r--r-- | driver/rsdShader.h | 2 | ||||
| -rw-r--r-- | driver/rsdShaderCache.h | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/driver/rsdShader.h b/driver/rsdShader.h index caccc099..dc31c245 100644 --- a/driver/rsdShader.h +++ b/driver/rsdShader.h @@ -70,7 +70,7 @@ protected: class StateBasedKey { public: - StateBasedKey(uint32_t texCount) : mShaderID(0) { + explicit StateBasedKey(uint32_t texCount) : mShaderID(0) { mTextureTargets = new uint32_t[texCount]; } ~StateBasedKey() { diff --git a/driver/rsdShaderCache.h b/driver/rsdShaderCache.h index 29f91bb6..884b1c81 100644 --- a/driver/rsdShaderCache.h +++ b/driver/rsdShaderCache.h @@ -78,7 +78,7 @@ protected: int32_t writtenLength; int32_t arraySize; uint32_t type; - UniformQueryData(uint32_t maxName) { + explicit UniformQueryData(uint32_t maxName) { name = nullptr; nameLength = maxName; if (nameLength > 0 ) { |