diff options
author | Gyumin Sim <gyumin@google.com> | 2019-06-03 14:56:45 +0100 |
---|---|---|
committer | Gyumin Sim <gyumin@google.com> | 2019-06-04 09:47:23 +0100 |
commit | 226c2df70397130b397830299c3302b42c8820f5 (patch) | |
tree | a915f53fc926e0d3700ac57fd732c5fbdc7fea7b | |
parent | b19ce308676537ac2cc5bd399ac4bb9c9aed7e0c (diff) | |
download | support-226c2df70397130b397830299c3302b42c8820f5.tar.gz |
Check integer key existence of MediaFormat
It fixes the failing test MediaControllerCallbackTest#testOnSubtitleData
Bug: 134375069
Test: ./media2/session/version-compat-tests/runtest.sh 1 &&
./gradlew :media2:media2-session:connectedCheck
Change-Id: Idc7adad1177927ea81f4238bd3931c4f92387fae
3 files changed, 7 insertions, 5 deletions
diff --git a/media2/common/src/main/java/androidx/media2/common/SessionPlayer.java b/media2/common/src/main/java/androidx/media2/common/SessionPlayer.java index 1ff0189a15e..f16d5b378da 100644 --- a/media2/common/src/main/java/androidx/media2/common/SessionPlayer.java +++ b/media2/common/src/main/java/androidx/media2/common/SessionPlayer.java @@ -1169,7 +1169,13 @@ public abstract class SessionPlayer implements AutoCloseable { } private boolean intEquals(String key, MediaFormat format1, MediaFormat format2) { - return format1.getInteger(key) == format2.getInteger(key); + boolean exists1 = format1.containsKey(key); + boolean exists2 = format2.containsKey(key); + if (exists1 && exists2) { + return format1.getInteger(key) == format2.getInteger(key); + } else { + return !exists1 && !exists2; + } } private void parcelIntValue(String key) { diff --git a/media2/session/src/androidTest/java/androidx/media2/session/MediaControllerTest.java b/media2/session/src/androidTest/java/androidx/media2/session/MediaControllerTest.java index 77aeccd9daa..649af1b65c2 100644 --- a/media2/session/src/androidTest/java/androidx/media2/session/MediaControllerTest.java +++ b/media2/session/src/androidTest/java/androidx/media2/session/MediaControllerTest.java @@ -65,7 +65,6 @@ import androidx.testutils.PollingCheck; import org.junit.After; import org.junit.Before; -import org.junit.Ignore; import org.junit.Test; import org.junit.runner.RunWith; @@ -1721,7 +1720,6 @@ public class MediaControllerTest extends MediaSessionTestBase { assertNull(controller.getSelectedTrack(testTrackType)); } - @Ignore("b/134375069") @Test public void testOnSubtitleData() throws InterruptedException { prepareLooper(); diff --git a/media2/session/version-compat-tests/current/client/src/androidTest/java/androidx/media2/test/client/tests/MediaControllerCallbackTest.java b/media2/session/version-compat-tests/current/client/src/androidTest/java/androidx/media2/test/client/tests/MediaControllerCallbackTest.java index b8403f3fc58..e37fc041acd 100644 --- a/media2/session/version-compat-tests/current/client/src/androidTest/java/androidx/media2/test/client/tests/MediaControllerCallbackTest.java +++ b/media2/session/version-compat-tests/current/client/src/androidTest/java/androidx/media2/test/client/tests/MediaControllerCallbackTest.java @@ -63,7 +63,6 @@ import androidx.test.filters.SdkSuppress; import org.junit.After; import org.junit.Before; -import org.junit.Ignore; import org.junit.Test; import org.junit.runner.RunWith; @@ -943,7 +942,6 @@ public class MediaControllerCallbackTest extends MediaSessionTestBase { assertTrue(latch.await(TIMEOUT_MS, TimeUnit.MILLISECONDS)); } - @Ignore("b/134375069") @Test public void testOnSubtitleData() throws InterruptedException { prepareLooper(); |