diff options
author | Oussama Ben Abdelbaki <obenabde@google.com> | 2018-11-30 07:57:15 -0500 |
---|---|---|
committer | Oussama Ben Abdelbaki <obenabde@google.com> | 2018-12-03 09:07:38 -0500 |
commit | fdd7a812e1dca4cf4bb8efa6224883cd65a4077f (patch) | |
tree | faa977bcc35ea021d5da575be8f3935c76b95c01 /fragment | |
parent | 07a3440bea523eb39d5b8ca090c767fddbffb2e0 (diff) | |
download | support-fdd7a812e1dca4cf4bb8efa6224883cd65a4077f.tar.gz |
Enable lintMinDepVersions in buildOnServer
Runs lintMinDepVersionsDebug as part of buildOnServer. Aside from
enforcing the classic lint rules, lint will be more strict with
the RestrictedApi check given that a bug prevented it from
detecting those when depending on a local project version of a
library, but as we move more towards depending on versioned
artifacts, the check will start detecting restricted api
violations.
Current violations have been suppressed, and should be addressed
in the future.
Test: ./gradlew bOS and ./gradlew lintMinDepVersionsDebug
Change-Id: I18cf2799ac84f28db5b5b19baeec04c4c26d0732
Diffstat (limited to 'fragment')
7 files changed, 14 insertions, 2 deletions
diff --git a/fragment/src/main/java/androidx/fragment/app/BackStackRecord.java b/fragment/src/main/java/androidx/fragment/app/BackStackRecord.java index f4eb53c3f55..f3055706a21 100644 --- a/fragment/src/main/java/androidx/fragment/app/BackStackRecord.java +++ b/fragment/src/main/java/androidx/fragment/app/BackStackRecord.java @@ -16,6 +16,7 @@ package androidx.fragment.app; +import android.annotation.SuppressLint; import android.util.Log; import android.view.View; @@ -549,6 +550,7 @@ final class BackStackRecord extends FragmentTransaction implements return setReorderingAllowed(allowOptimization); } + @SuppressLint("RestrictedApi") int commitInternal(boolean allowStateLoss) { if (mCommitted) throw new IllegalStateException("commit already called"); if (FragmentManagerImpl.DEBUG) { diff --git a/fragment/src/main/java/androidx/fragment/app/Fragment.java b/fragment/src/main/java/androidx/fragment/app/Fragment.java index 6f9a5c5ed97..1523af3bfe0 100644 --- a/fragment/src/main/java/androidx/fragment/app/Fragment.java +++ b/fragment/src/main/java/androidx/fragment/app/Fragment.java @@ -524,7 +524,7 @@ public class Fragment implements ComponentCallbacks, OnCreateContextMenuListener } @Override - @SuppressLint("UnknownNullness") + @SuppressLint({"UnknownNullness", "RestrictedApi"}) public String toString() { StringBuilder sb = new StringBuilder(128); DebugUtils.buildShortClassTag(this, sb); diff --git a/fragment/src/main/java/androidx/fragment/app/FragmentActivity.java b/fragment/src/main/java/androidx/fragment/app/FragmentActivity.java index f357b55a611..bd07f53724b 100644 --- a/fragment/src/main/java/androidx/fragment/app/FragmentActivity.java +++ b/fragment/src/main/java/androidx/fragment/app/FragmentActivity.java @@ -151,7 +151,7 @@ public class FragmentActivity extends ComponentActivity implements } return; } - + @SuppressLint("RestrictedApi") ActivityCompat.PermissionCompatDelegate delegate = ActivityCompat.getPermissionCompatDelegate(); if (delegate != null && delegate.onActivityResult(this, requestCode, resultCode, data)) { diff --git a/fragment/src/main/java/androidx/fragment/app/FragmentController.java b/fragment/src/main/java/androidx/fragment/app/FragmentController.java index 208639201ed..729909dbdf0 100644 --- a/fragment/src/main/java/androidx/fragment/app/FragmentController.java +++ b/fragment/src/main/java/androidx/fragment/app/FragmentController.java @@ -53,6 +53,7 @@ public class FragmentController { * Returns a {@link FragmentController}. */ @NonNull + @SuppressLint("RestrictedApi") public static FragmentController createController(@NonNull FragmentHostCallback<?> callbacks) { return new FragmentController(checkNotNull(callbacks, "callbacks == null")); } diff --git a/fragment/src/main/java/androidx/fragment/app/FragmentHostCallback.java b/fragment/src/main/java/androidx/fragment/app/FragmentHostCallback.java index f9d820f08f3..dcc86191aa8 100644 --- a/fragment/src/main/java/androidx/fragment/app/FragmentHostCallback.java +++ b/fragment/src/main/java/androidx/fragment/app/FragmentHostCallback.java @@ -58,6 +58,7 @@ public abstract class FragmentHostCallback<E> extends FragmentContainer { this(activity, activity /*context*/, new Handler(), 0 /*windowAnimations*/); } + @SuppressLint("RestrictedApi") FragmentHostCallback(@Nullable Activity activity, @NonNull Context context, @NonNull Handler handler, int windowAnimations) { mActivity = activity; diff --git a/fragment/src/main/java/androidx/fragment/app/FragmentManagerImpl.java b/fragment/src/main/java/androidx/fragment/app/FragmentManagerImpl.java index b70f69776c6..8d22a17cfdc 100644 --- a/fragment/src/main/java/androidx/fragment/app/FragmentManagerImpl.java +++ b/fragment/src/main/java/androidx/fragment/app/FragmentManagerImpl.java @@ -22,6 +22,7 @@ import android.animation.AnimatorListenerAdapter; import android.animation.AnimatorSet; import android.animation.PropertyValuesHolder; import android.animation.ValueAnimator; +import android.annotation.SuppressLint; import android.app.Activity; import android.content.Context; import android.content.res.Configuration; @@ -197,6 +198,7 @@ final class FragmentManagerImpl extends FragmentManager implements LayoutInflate && modifiesAlpha(anim); } + @SuppressLint("RestrictedApi") private void throwException(RuntimeException ex) { Log.e(TAG, ex.getMessage()); Log.e(TAG, "Activity state:"); @@ -424,6 +426,7 @@ final class FragmentManagerImpl extends FragmentManager implements LayoutInflate } @Override + @SuppressLint("RestrictedApi") public String toString() { StringBuilder sb = new StringBuilder(128); sb.append("FragmentManager{"); @@ -2415,6 +2418,7 @@ final class FragmentManagerImpl extends FragmentManager implements LayoutInflate restoreSaveState(state); } + @SuppressLint("RestrictedApi") void restoreSaveState(Parcelable state) { // If there is no saved state at all, then there's nothing else to do if (state == null) return; diff --git a/fragment/testing/src/main/java/androidx/fragment/app/testing/FragmentScenario.java b/fragment/testing/src/main/java/androidx/fragment/app/testing/FragmentScenario.java index b146da77568..26c8ce00f1f 100644 --- a/fragment/testing/src/main/java/androidx/fragment/app/testing/FragmentScenario.java +++ b/fragment/testing/src/main/java/androidx/fragment/app/testing/FragmentScenario.java @@ -21,6 +21,7 @@ import static androidx.core.util.Preconditions.checkNotNull; import static androidx.core.util.Preconditions.checkState; import static androidx.test.core.app.ApplicationProvider.getApplicationContext; +import android.annotation.SuppressLint; import android.content.ComponentName; import android.content.Intent; import android.os.Bundle; @@ -267,6 +268,7 @@ public final class FragmentScenario<F extends Fragment> { } @NonNull + @SuppressLint("RestrictedApi") private static <F extends Fragment> FragmentScenario<F> internalLaunch( @NonNull final Class<F> fragmentClass, final @Nullable Bundle fragmentArgs, final int themeResId, @Nullable final FragmentFactory factory, @@ -321,6 +323,7 @@ public final class FragmentScenario<F extends Fragment> { * This method cannot be called from the main thread. */ @NonNull + @SuppressLint("RestrictedApi") public FragmentScenario<F> moveToState(@NonNull State newState) { if (newState == State.DESTROYED) { mActivityScenario.onActivity( @@ -400,6 +403,7 @@ public final class FragmentScenario<F extends Fragment> { * This method cannot be called from the main thread. */ @NonNull + @SuppressLint("RestrictedApi") public FragmentScenario<F> onFragment(@NonNull final FragmentAction<F> action) { mActivityScenario.onActivity( new ActivityScenario.ActivityAction<EmptyFragmentActivity>() { |