diff options
author | Primiano Tucci <primiano@google.com> | 2014-10-27 18:24:26 +0000 |
---|---|---|
committer | Primiano Tucci <primiano@google.com> | 2014-10-27 18:24:26 +0000 |
commit | a329f6b47075066d779fe3b020d971cd66a3bf5f (patch) | |
tree | 1fa15eaa7af8eca329298e4e13b66bf0c167fd4b | |
parent | 89b33e2103cee15b08a31a48b379b846bc690891 (diff) | |
download | webview-a329f6b47075066d779fe3b020d971cd66a3bf5f.tar.gz |
Enable minimalistic crash handler for WebView.
This complements crrev.com/678763005. It enables the handler that dumps
out the WebView version in logcat in the case of a crash.
The previous handlers are chained and reinstalled after the print.
Change-Id: I2068d7925bb73c95cf0b5471936aa728280e1588
-rw-r--r-- | chromium/java/com/android/webview/chromium/WebViewChromiumFactoryProvider.java | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/chromium/java/com/android/webview/chromium/WebViewChromiumFactoryProvider.java b/chromium/java/com/android/webview/chromium/WebViewChromiumFactoryProvider.java index 1b10971..9f9c3aa 100644 --- a/chromium/java/com/android/webview/chromium/WebViewChromiumFactoryProvider.java +++ b/chromium/java/com/android/webview/chromium/WebViewChromiumFactoryProvider.java @@ -16,6 +16,7 @@ package com.android.webview.chromium; +import android.content.pm.PackageInfo; import android.content.pm.PackageManager; import android.content.res.Resources; import android.app.ActivityManager; @@ -122,6 +123,13 @@ public class WebViewChromiumFactoryProvider implements WebViewFactoryProvider { Trace.traceBegin(Trace.TRACE_TAG_WEBVIEW, "AwBrowserProcess.loadLibrary()"); AwBrowserProcess.loadLibrary(); Trace.traceEnd(Trace.TRACE_TAG_WEBVIEW); + + final PackageInfo packageInfo = WebViewFactory.getLoadedPackageInfo(); + + // Register the handler that will append the WebView version to logcat in case of a crash. + AwContentsStatics.registerCrashHandler( + "Version " + packageInfo.versionName + " (code " + packageInfo.versionCode + ")"); + // Load glue-layer support library. System.loadLibrary("webviewchromium_plat_support"); @@ -129,7 +137,7 @@ public class WebViewChromiumFactoryProvider implements WebViewFactoryProvider { mWebViewPrefs = ActivityThread.currentApplication().getSharedPreferences( CHROMIUM_PREFS_NAME, Context.MODE_PRIVATE); int lastVersion = mWebViewPrefs.getInt(VERSION_CODE_PREF, 0); - int currentVersion = WebViewFactory.getLoadedPackageInfo().versionCode; + int currentVersion = packageInfo.versionCode; if (lastVersion > currentVersion) { // The WebView package has been downgraded since we last ran in this application. // Delete the WebView data directory's contents. |