aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJohan Hovold <johan@kernel.org>2016-11-01 11:49:56 +0100
committerWilly Tarreau <w@1wt.eu>2017-02-10 11:04:00 +0100
commit6d97f02a6c0faa8cef0bae45cc2f16fbaf38332a (patch)
tree1c64d1cd6cd6134c933dc2996c2567f4ea293546
parent26b5a4a56fd60530d0ab3b51a7fda5841d4f9316 (diff)
downloadedison-v3.10-6d97f02a6c0faa8cef0bae45cc2f16fbaf38332a.tar.gz
PM / sleep: fix device reference leak in test_suspend
commit ceb75787bc75d0a7b88519ab8a68067ac690f55a upstream. Make sure to drop the reference taken by class_find_device() after opening the RTC device. Fixes: 77437fd4e61f (pm: boot time suspend selftest) Signed-off-by: Johan Hovold <johan@kernel.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Willy Tarreau <w@1wt.eu>
-rw-r--r--kernel/power/suspend_test.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/kernel/power/suspend_test.c b/kernel/power/suspend_test.c
index 269b097e78e..743615bfdce 100644
--- a/kernel/power/suspend_test.c
+++ b/kernel/power/suspend_test.c
@@ -169,8 +169,10 @@ static int __init test_suspend(void)
/* RTCs have initialized by now too ... can we use one? */
dev = class_find_device(rtc_class, NULL, NULL, has_wakealarm);
- if (dev)
+ if (dev) {
rtc = rtc_class_open(dev_name(dev));
+ put_device(dev);
+ }
if (!rtc) {
printk(warn_no_rtc);
goto done;