summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAnkit Goyal <layog@google.com>2022-03-16 11:23:19 -0700
committerSiddharth Kapoor <ksiddharth@google.com>2022-03-24 07:13:05 +0000
commit6dd183e4b7277097e469f280696e4e8c824d6266 (patch)
treeea490370fd090eeca3dbb8059c5665f510dd6d09
parent757551b6b4d168794e818e89fe44090ea087a260 (diff)
downloadgchips-6dd183e4b7277097e469f280696e4e8c824d6266.tar.gz
Remove redundant canFree argument to reference release
Bug: 207450311 Test: Boots to home Change-Id: Id870c95b2505dd942d91af71a9b9d46de6c10525 Merged-In: I1ef63ce87cf60ff9bad325a38883b4c9f6f5e4cf
-rw-r--r--gralloc4/src/core/mali_gralloc_reference.cpp4
-rw-r--r--gralloc4/src/core/mali_gralloc_reference.h2
-rw-r--r--gralloc4/src/hidl_common/Mapper.cpp2
3 files changed, 4 insertions, 4 deletions
diff --git a/gralloc4/src/core/mali_gralloc_reference.cpp b/gralloc4/src/core/mali_gralloc_reference.cpp
index 67dd4f9..e9636ea 100644
--- a/gralloc4/src/core/mali_gralloc_reference.cpp
+++ b/gralloc4/src/core/mali_gralloc_reference.cpp
@@ -89,7 +89,7 @@ int mali_gralloc_reference_map(buffer_handle_t handle) {
return retval;
}
-int mali_gralloc_reference_release(buffer_handle_t handle, bool canFree)
+int mali_gralloc_reference_release(buffer_handle_t handle)
{
if (private_handle_t::validate(handle) < 0)
{
@@ -111,7 +111,7 @@ int mali_gralloc_reference_release(buffer_handle_t handle, bool canFree)
{
hnd->ref_count--;
- if (hnd->ref_count == 0 && canFree)
+ if (hnd->ref_count == 0)
{
mali_gralloc_buffer_free(handle);
}
diff --git a/gralloc4/src/core/mali_gralloc_reference.h b/gralloc4/src/core/mali_gralloc_reference.h
index 85bc1c9..acf8e82 100644
--- a/gralloc4/src/core/mali_gralloc_reference.h
+++ b/gralloc4/src/core/mali_gralloc_reference.h
@@ -22,7 +22,7 @@
#include "gralloc_priv.h"
int mali_gralloc_reference_retain(buffer_handle_t handle);
-int mali_gralloc_reference_release(buffer_handle_t handle, bool canFree);
+int mali_gralloc_reference_release(buffer_handle_t handle);
int mali_gralloc_reference_validate(buffer_handle_t handle);
int mali_gralloc_reference_map(buffer_handle_t handle);
diff --git a/gralloc4/src/hidl_common/Mapper.cpp b/gralloc4/src/hidl_common/Mapper.cpp
index 80ea7e1..e8f5b10 100644
--- a/gralloc4/src/hidl_common/Mapper.cpp
+++ b/gralloc4/src/hidl_common/Mapper.cpp
@@ -90,7 +90,7 @@ static Error unregisterBuffer(buffer_handle_t bufferHandle)
return Error::BAD_BUFFER;
}
- const int status = mali_gralloc_reference_release(bufferHandle, true);
+ const int status = mali_gralloc_reference_release(bufferHandle);
if (status != 0)
{
MALI_GRALLOC_LOGE("Unable to release buffer:%p", bufferHandle);