aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-12-11gfxstream: nuke profilerGurchetan Singh
Looks like Emulator doesn't run the tests anymore: https://googleplex-android-review.git.corp.google.com/c/device/generic/goldfish/+/25134388 BUG=296903491 TEST=presubmit Change-Id: Ie5a9fbb1ae92e881e2827594f17f572f745a987a
2023-12-11Add notes on how to run dEQP with Gfxstream ICDJason Macnak
Bug: b/315317383 Test: n/a Change-Id: Ib1c8a5a9fdb275c7b3e4db2b52d5fc516402970d
2023-12-11Merge "Fix background dimming bug." into mainTreehugger Robot
2023-12-11Sort and dedup physical device extensionsJason Macnak
... to avoid issues when running dEQP. The Vulkan Loader's trampoline functions will remove duplicates as well but this can lead to lead errors if Gfxstream's function returns VK_SUCCESS with N elements (including a duplicate) but the Vulkan Loader's trampoline function returns N-1 when querying the extension count. Then, Gfxstream will return VK_INCOMPLETE the second time the application queries for the actual structs with an array sized N-1. Bug: b/315317383 Test: deqp-vk w/ Gfxstream ICD Change-Id: I684b6aeef40e025a90fa687f4a2d902b13d84bdf
2023-12-11Use a nested Vulkan Loader when GFXSTREAM_VK_ env var foundJason Macnak
... and add script to build a version of the Vulkan Loader which uses "GFXSTREAM" prefixed env vars and logging. Bug: b/315317383 Test: deqp-vk w/ Gfxstream ICD Change-Id: I7202379dbc27a9519b55434e889139810078020d
2023-12-11Reorganize Vulkan Loader library findingJason Macnak
... to try to simplify the number of functions reading the same envvars. Bug: b/315317383 Test: cvd start --gpu_mode=gfxstream Change-Id: I58ae665573f494c97196d75749fa66777c7b7cf5
2023-12-09Fix background dimming bug.Joshua Duong
We accidentally skipped the HWC2_COMPOSITION_SOLID_COLOR layer because we saw an invalid colorbuffer handle. But HWC2_COMPOSITION_SOLID_COLOR should not have a colorbuffer backing. Bug: 315308358 Bug: 289117017 Test: Open App Info for any app, click "Force stop". There should be a background dimming effect under the confirmation dialog. WIP integration test. Change-Id: Iddf65f26602c51f8bea95cdce37f38139b99f4c7
2023-12-08Merge "Wrap some classes in "namespace gfxstream::guest {}"" into mainJason Macnak
2023-12-08Wrap some classes in "namespace gfxstream::guest {}"Jason Macnak
... to avoid more duplicate symbol definitions when building Gfxstream VK ICD. Bug: b/315317383 Test: deqp-vk w/ Gfxstream ICD Change-Id: I96b31b8fadec428c94ecc3d5572741cba230c75f
2023-12-08Merge "Add dispatch magic for Gfxstream linux ICD" into main am: 099f9bdc97Jason Macnak
Original change: https://android-review.googlesource.com/c/platform/hardware/google/gfxstream/+/2863316 Change-Id: Iae34195d81f33bf5c17f00c323e0a02d4ec56c0e Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-07Merge "Add dispatch magic for Gfxstream linux ICD" into mainJason Macnak
2023-12-07Add dispatch magic for Gfxstream linux ICDJason Macnak
Bug: b/315317383 Test: deqp-vk w/ Gfxstream ICD Change-Id: I6fba6a1fcd6cc33264d53c46d89a8fbaf41914a4
2023-12-07gfxstream: codegen EXT_swapchain_maintenance1 + KHR_swapchain host only am: ↵Gurchetan Singh
e7fc3575c7 Original change: https://android-review.googlesource.com/c/platform/hardware/google/gfxstream/+/2863313 Change-Id: I3421ee503f050ffde1c0ec317310e3fa2a4acc21 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-07gfxstream: cereal: SUPPORTED_WRAPPERS --> SUPPORTED_MODULES am: 45803ea243Gurchetan Singh
Original change: https://android-review.googlesource.com/c/platform/hardware/google/gfxstream/+/2863312 Change-Id: I67de65c5f33dc545e314b5ba160475534c886514 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-07gfxstream: cereal: [moduleType] --> [(moduleType, moduleName)] am: 17b16a984aGurchetan Singh
Original change: https://android-review.googlesource.com/c/platform/hardware/google/gfxstream/+/2863311 Change-Id: I016cc5295d82236f2d06ce0c5ebcd1f0c9a5ec70 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-07Snap for 11189608 from 5fb04a3237a2e8fee84d005cd04f001ca8fe7fc8 to ↵Android Build Coastguard Worker
emu-34-release Change-Id: I3e27a7742e949aab98de07562ec6042d8ececf02
2023-12-07gfxstream: codegen EXT_swapchain_maintenance1 + KHR_swapchain host onlyGurchetan Singh
We really shouldn't be encoding/decoding EXT_swapchain_maintenance1 or KHR_swapchain at all, for Android. The driver needs to expose VK_ANDROID_native_buffer and Android's libvulkan implements swapchain in terms of that. However, Android's libvulkan doesn't filter out structs or definitions related to those extensions, and for U, niether does gfxstream. That means older images pass down the extensions. Newer versions of gfxstream guest should do filtering and in fact we have some host side filtering logic too. So isolate the extensions host side for now. This also removes an abort(..) in unwrap_VkBindImageMemorySwapchainInfoKHR. Since were aren't auto-generating KHR_swapchain anymore, so things don't get copied, and the abort(..) gets triggered. However, as gfxstream is not a validation layer, removing the abort is harmless. BUG=315319874 TEST=launch_cvd --gpu_mode=gfxstream_guest_angle Change-Id: I1aad28d38841b3a7d7ffa920848f87af730f32a8
2023-12-07gfxstream: cereal: SUPPORTED_WRAPPERS --> SUPPORTED_MODULESGurchetan Singh
Wrappers are used to generate host and guest variants of modules. Thus, modules allow differentiation between guest and host codegen, which wrappers do not. BUG=315319874 TEST=launch_cvd --gpu_mode=gfxstream_guest_angle Change-Id: I524b75506acd5f23d217df6402539ba1ed3f8907
2023-12-07gfxstream: cereal: [moduleType] --> [(moduleType, moduleName)]Gurchetan Singh
It would be great if we could get the moduleName from a moduleType, but couldn't determine how it's done. So just create a tuple. BUG=315319874 TEST=launch_cvd --gpu_mode=gfxstream_guest_angle Change-Id: I8eefe1999413b1d5fc4ad58d774bf20ca1560d53
2023-12-06Re-enable logger setupYahan Zhou
We need more logs in crash reports to debug graphics initialization failures. Bug: 314841455 Change-Id: Id40871b439de4a16885ac3673443db37b95ccecf
2023-12-05Merge "Use old en/decoding for vkQueueSignalReleaseImage" into main am: ↵Yahan Zhou
5fb04a3237 Original change: https://android-review.googlesource.com/c/platform/hardware/google/gfxstream/+/2857730 Change-Id: Ie26a8713b75082817389008dd27449eb7a5b0999 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-05Merge "Use old en/decoding for vkQueueSignalReleaseImage" into mainYahan Zhou
2023-12-05Merge "Reapply "Fix Event.h variable names"" into main am: 1617b374f0Jason Macnak
Original change: https://android-review.googlesource.com/c/platform/hardware/google/gfxstream/+/2855063 Change-Id: I00ff60137b5eeaa5e03cd63a4e4ccf4d8f6ba48a Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-05Merge "Reapply "Fix Event.h variable names"" into mainJason Macnak
2023-12-04gfxstream: Ensure thread-local state is initialized am: 723593fbfbAaron Ruby
Original change: https://android-review.googlesource.com/c/platform/hardware/google/gfxstream/+/2857665 Change-Id: I25c8853ddecc3ac289f56b9b9506be780b4243b6 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-04Use old en/decoding for vkQueueSignalReleaseImageYahan Zhou
We accidentially changed the xml definition for vkQueueSignalReleaseImageANDROID. As a result it changed its encoding and decoding, which breaks Android emulator when launching old system images (API level 29~32). To fix this, we overwrite it with the old definition so that it keeps using the old encoding/decoding. Note that API 33+ uses vkQueueSignalReleaseImageANDROIDAsyncGOOGLE which does not have this problem. Bug: 314333200 Test: API 29 on Mac m1 launch chrome Change-Id: If3c5b9cb880ba7a415c98a172dd0fb43215f9b98
2023-12-04ELF TLS is the default now. am: e2796481b0Elliott Hughes
Original change: https://android-review.googlesource.com/c/platform/hardware/google/gfxstream/+/2855055 Change-Id: I4c424b01032758f5a4e070d9cbfc6cebd7e8833b Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-12-04gfxstream: Ensure thread-local state is initializedAaron Ruby
In platformCreateSharedContext, run EGL make current to guarantee thread local state in initialized. BUG=314803608 TEST=no bugs running gfxstream guest Linux Change-Id: Ifff6823f30a27123776419700a168a3d34aec2d1
2023-12-01Reapply "Fix Event.h variable names"Jason Macnak
View the diff against patchset 0 to see changes since the revert. This reverts commit 97f0fef83d8ab9fd43c628867273a4b753de63ef. ... to avoid errors like /host/testlibs/Event.h:80:33: error: declaration of ‘Event::KeyEvent Event::<unnamed union>::Key’ changes meaning of ‘Key’ [-Wchanges- ... /host/testlibs/Event.h:30:9: note: used here to mean ‘enum Key’ 30 | Key Code; | ^~~ Bug: n/a Test: cd hardware/google/gfxstream mkdir build cd build cmake .. -G Ninja ninja Test: emulator-mac_x64_gfxstream on ATBD (see checks tab) Change-Id: Ie420aa2166db2ee09efea660b49b3e132a39c72f
2023-12-01ELF TLS is the default now.Elliott Hughes
Test: treehugger Change-Id: Ibe9f1cb97b649718a0f2c5b9b52247ceaf6120c3
2023-11-30Snap for 11160028 from 15472c968f2eaf55d9e5463dcc20fc8a979b7613 to ↵Android Build Coastguard Worker
emu-34-release Change-Id: Iad06969dc2e671685fc82884e6d60ca0ac63139f
2023-11-29Merge "Revert "Fix Event.h variable names"" into main am: 15472c968fMehdi Alizadeh
Original change: https://android-review.googlesource.com/c/platform/hardware/google/gfxstream/+/2853028 Change-Id: I6bb83d08a4f18b7ca40822a933fd00a6652e163e Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-11-29Merge "Revert "Fix Event.h variable names"" into mainMehdi Alizadeh
2023-11-29Revert "Fix Event.h variable names"Mehdi Alizadeh
This reverts commit 2b885511137cc49e542bcbb818d7676291de5c47. Reason for revert: Build failure on mac_x64_gfxstream Change-Id: Idb4ba7be5bf2672f06d8b796a49e9d983881d1c5
2023-11-29Merge "Fix Event.h variable names" into main am: 18861a3629Jason Macnak
Original change: https://android-review.googlesource.com/c/platform/hardware/google/gfxstream/+/2850157 Change-Id: I4b747c9b0f31941984b0648830bcd4d1904a799a Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-11-29Merge "Fix Event.h variable names" into mainJason Macnak
2023-11-29Merge "gfxstream: meson: use system headers if possible" into main am: ↵Treehugger Robot
a4c3da69e9 Original change: https://android-review.googlesource.com/c/platform/hardware/google/gfxstream/+/2850224 Change-Id: Id413d117d3f268889e837ff9f8737602d799a153 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-11-29Merge "gfxstream: meson: use system headers if possible" into mainTreehugger Robot
2023-11-29Merge "gfxstream: meson: fix path to gl-host-common" into main am: edda921ce0Treehugger Robot
Original change: https://android-review.googlesource.com/c/platform/hardware/google/gfxstream/+/2850223 Change-Id: I660d694c0c08e475f179a2cf089f7ebfbde8ac4c Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-11-29Merge "gfxstream: meson: fix path to gl-host-common" into mainTreehugger Robot
2023-11-29Merge "Move vk_enum_string_header.h into gfxstream_vulkan_headers" into main ↵Jason Macnak
am: e593b2f6cc Original change: https://android-review.googlesource.com/c/platform/hardware/google/gfxstream/+/2850215 Change-Id: Ie6e17d516a3ba9c3ea5e2aff331cc99fee8f0207 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-11-29Consolidate the 3 copies of etc am: a985153574Jason Macnak
Original change: https://android-review.googlesource.com/c/platform/hardware/google/gfxstream/+/2850212 Change-Id: I3b9eb8a6304f6e9ba5185e2fd491bb6cdc787397 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-11-29Merge "Move vk_enum_string_header.h into gfxstream_vulkan_headers" into mainJason Macnak
2023-11-28gfxstream: meson: use system headers if possibleGurchetan Singh
Special thanks for marcandre.lureau@ for pointing this out. BUG=273561059 TEST=compile Change-Id: I221f1c78dfaeddf2e4e49c1f2a90b9dc598cf849
2023-11-28gfxstream: meson: fix path to gl-host-commonGurchetan Singh
BUG=n/a TEST=mkdir amd64-build meson amd64-build ninja -C amd64-build/ Change-Id: I74a4e534e8546f823154516736fd2553720591e7
2023-11-28Fix Event.h variable namesJason Macnak
... to avoid errors like /host/testlibs/Event.h:80:33: error: declaration of ‘Event::KeyEvent Event::<unnamed union>::Key’ changes meaning of ‘Key’ [-Wchanges- ... /host/testlibs/Event.h:30:9: note: used here to mean ‘enum Key’ 30 | Key Code; | ^~~ Bug: n/a Test: cd hardware/google/gfxstream mkdir build cd build cmake .. -G Ninja ninja Change-Id: Id972576505fb86905c480c3f1e6ed3cc1fc0fe99
2023-11-28Move vk_enum_string_header.h into gfxstream_vulkan_headersJason Macnak
Bug: n/a Test: cd hardware/google/gfxstream && mma Test: cd hardware/google/gfxstream mkdir build cd build cmake .. -G Ninja ninja Change-Id: I0afc62835fab9636cd30c2bc6f5a3b094849eb6d
2023-11-28Consolidate the 3 copies of etcJason Macnak
Bug: n/a Test: cd hardware/google/gfxstream && mma Test: cd hardware/google/gfxstream mkdir build cd build cmake .. -G Ninja ninja Test: python android/build/python/cmake.py --feature no-rust Test: python android/build/python/cmake.py --feature no-rust --gfxstream Change-Id: I26ebfbc4e41fef081d95461cec87664e2c079a6c
2023-11-28Merge "Move gl-host-common into host" into main am: 4beb79d463Jason Macnak
Original change: https://android-review.googlesource.com/c/platform/hardware/google/gfxstream/+/2843838 Change-Id: Ife76a02c14063bfd5a8de116969573f2c4175920 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-11-28Merge "Move gl-host-common into host" into mainJason Macnak