summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-08-04Snap for 10609607 from 725767cf6e14059d901e94f8e2b0a29a0c6ef42d to ↵aml_uwb_341710010aml_uwb_341513070aml_uwb_341511050aml_uwb_341310300aml_uwb_341310030aml_uwb_341111010aml_uwb_341011000android14-mainline-uwb-releaseAndroid Build Coastguard Worker
mainline-uwb-release Change-Id: I4ca939fb836b95db478d0258b32487c2db5c235d
2023-07-19libhwc2.1: revert behavior of setLayerCompositionType() am: f6f0318b90Wiwit Rifa'i
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/google/graphics/common/+/24004824 Change-Id: I7308c5e43fa6c2763f8437c428e65192efbcab5f Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-07-15libhwc2.1: revert behavior of setLayerCompositionType()Wiwit Rifa'i
This is partial revert of ag/23598344. This will fix power regression & disappearing cursor issues caused by that patch. In ag/23598344, we didn't set mGeometryChanged if the composition is changed back to the original composition (initially set by setLayerCompositionType()) after falling back to client composition in the previous frame. But, it causes some regressions, e.g. power jump and disappearing cursor issues. Thus, this will revert to the previous behavior i.e. to always set mGeometryChanged as dirty whenever we change mCompositionType. Bug: 289010449 Test: v2/android-power-te/functional_media_test_suite/* Test: Use mouse and the cursor shouldn't disappear unexpectedly Change-Id: If73dc0353c9e3ede93ff02e675aa879bc54287e4
2023-07-07Snap for 10453563 from 48b1ff4a7f7c1b3fade987ac1c303c9724adf0f7 to ↵Android Build Coastguard Worker
mainline-uwb-release Change-Id: I9847b89be790f1715809464ef2f2267663031bb2
2023-06-16Merge "libhwc2.1: Skip redundant onRefresh in histogramSample" into udc-dev ↵Treehugger Robot
am: f1de980659 Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/google/graphics/common/+/23485216 Change-Id: Ie67cb2cf94c08b6595149384f1722671866278a7 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-16Merge "libhwc2.1: Skip redundant onRefresh in histogramSample" into udc-devandroid14-devTreehugger Robot
2023-06-15libhwc2.1: use mRequestedCompositionType to check indicator layer am: 8c34de5710Wiwit Rifa'i
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/google/graphics/common/+/23598345 Change-Id: Icaf207617a3b775f476adbce9460f169ec11bec1 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-15libhwc2.1: mark as non-frame update for reverting composition to original ↵Wiwit Rifa'i
am: ba60527e79 Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/google/graphics/common/+/23598344 Change-Id: I1159ca78481b551292b50837e042a9fae06cfb03 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-07libhwc2.1: use mRequestedCompositionType to check indicator layerWiwit Rifa'i
Instead of checking (mCompositionType == REFRESH_RATE_INDICATOR), we should check mRequestedCompositionType to check whether a layer is for refresh rate indicator or not. This is because mCompositionType can be changed to CLIENT when acceptDisplayChanges() is called. Thus, we should use mRequestedCompositionType that will only be changed by setLayerCompositionType(). Bug: 283352279 Test: refresh rate indicator can enter idle after play HDR video on YT Change-Id: I5381157107550ed380c9671fe712285b1b53f814
2023-06-06libhwc2.1: mark as non-frame update for reverting composition to originalWiwit Rifa'i
When some layers fallback to CLIENT composition, mCompositionType will be set to CLIENT during acceptDisplayChanges() since SF will update its state according to the validated type. But, SF may revert the requested composition back to the original composition (e.g. DEVICE), so HWC should not consider it as a frame update if there's no other update. This will prevent refresh rate indicator to increase unexpectedly when updating the refresh rate indicator but there are some layers fallback to client composition. Bug: 277999360 Bug: 283352279 Test: refresh rate indicator can enter idle on wallpaper & style Change-Id: Iaa33fbad555d7a0de65d77edc2a287c8e8940dc3 Merged-In: Iaa33fbad555d7a0de65d77edc2a287c8e8940dc3
2023-06-06libhwc2.1: Skip redundant onRefresh in histogramSampleLeo Chen
DPU driver maintains always-on histogram engine state with up to date histogram data. Therefore we don't have explicitly to trigger onRefresh in case histogram configuration does not change. Test: aidl_hist_client 500 500 1000 1999 340 340 344 POST 1000000 Bug: 261376040 Change-Id: I44824ee836adb66aeb214c371a11ed350d13b069 Signed-off-by: Leo Chen <yinchiuan@google.com>
2023-05-26Merge "libhwc2.1: correct refresh rate reference at toggling lhbm" into ↵Shiyong Li
udc-dev am: a5f01d4ae9 Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/google/graphics/common/+/23404897 Change-Id: Ib741f25f8d864c38432b2dde49093b67cbaf5022 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-26Merge "libhwc2.1: correct refresh rate reference at toggling lhbm" into udc-devShiyong Li
2023-05-26libhwc2.1: histogram: fix race condition am: 97e8efb676Oleg Matcovschi
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/google/graphics/common/+/23436076 Change-Id: Ibbf6b9d7e797434b9761069badc375a8487e81d3 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-26libhwc2.1: histogram: pass parameters as references am: 8c9370f42fOleg Matcovschi
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/google/graphics/common/+/23393336 Change-Id: I80faf8481b9212cea1b94d4489f1ebebb418071e Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-26libhwc2.1: histogram: fix race conditionOleg Matcovschi
Fix potential race condition when data is received before setHistrogramControl() returns and mHistReq_pending is set to true. TODO: Implement timeout for requestHist(). Bug: 261376040 Bug: 277948998 Change-Id: Idd8b191508af19f1ce9bdd63d7fdf6a39fe0bd6e Merged-In: Idd8b191508af19f1ce9bdd63d7fdf6a39fe0bd6e Signed-off-by: Oleg Matcovschi <omatcovschi@google.com>
2023-05-26libhwc2.1: histogram: pass parameters as referencesOleg Matcovschi
Bug: 277948998 Bug: 261376040 Change-Id: I7021e0445e4b938b98eaa7dab54d5622ada2957b Merged-In: I7021e0445e4b938b98eaa7dab54d5622ada2957b Signed-off-by: Oleg Matcovschi <omatcovschi@google.com>
2023-05-26libhwc2.1: correct refresh rate reference at toggling lhbmShiyong Li
The refresh rate associated with mActiveConfig takes one or more frames to actually becomre effective on hardware, and can't be used as reference to decide if it's needed to set new refresh rate while toggling lhbm. Use drm value instead, which can't be blocked by enableConfigSetting() and takes 1 frame at most to reflect on hardware. Bug: 280727927 Test: check udfps enrollment failure rate Signed-off-by: Shiyong Li <shiyongli@google.com> Change-Id: Ie2f39f73761cc6f9fe51637aa3ebf8e5d85026e5
2023-05-19Merge "libhwc2.1 : reset assigned resource when a layer is destroyed" into ↵Long Ling
udc-dev am: 2a4e22ebcc Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/google/graphics/common/+/23269235 Change-Id: Ic49f98ce96f3f486c2f130373ae09f2610bd3bb8 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-19Merge "libhwc2.1 : reset assigned resource when a layer is destroyed" into ↵Long Ling
udc-dev
2023-05-19Merge "libhwc2.1: add trace for setActiveConfigWithConstraints()" into ↵Joen Chen
udc-dev am: dc56f0b0cf Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/google/graphics/common/+/23240759 Change-Id: I3b93cd0fd361ba70029db584f0c730fa16f14a8f Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-19Merge "libhwc2.1: add trace for setActiveConfigWithConstraints()" into udc-devJoen Chen
2023-05-19libhwc2.1: add trace for setActiveConfigWithConstraints()Joen Chen
HWC adds trace for setActiveConfigWithConstraints() to show the desire time and isConfigEnabled() Bug: 280460655 Test: run vts VtsHalGraphicsComposerV2_4TargetTest -t Per Instance/GraphicsComposerHidlTest#setActiveConfigWith Constraints_Delayed/0_default Change-Id: I6796d054f463982050b48a70b9e4300d1ddc9ac4
2023-05-18libhwc2.1: each display should have respective boot property am: fcbbd30ad1Joen Chen
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/google/graphics/common/+/23269800 Change-Id: Ibc7dd2de1bfb0ec5ad06fc45c4376e12b5554923 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-17libhwc2.1: each display should have respective boot propertyJoen Chen
HWC should provide each display with a respective boot property. Considering OTA, we keep the property string for display with id 0, and give another property string for other displays. Bug: 282126684 Test: VTS “run vts -m VtsHalGraphicsComposer3_TargetTest -t PerInstance/GraphicsComposerAidlTest#GetPreferredBootDisplay Config/0_android_hardware_graphics_composer3_IComposer_default” Change-Id: Ieb00906bdf4ad949710e3469476cab0df734b9b4
2023-05-16libhwc2.1 : reset assigned resource when a layer is destroyedMuncheol Park
HWC service is crashed due to accessing memory which is already freed. In destroyLayer, it only delete layer object and pointer in ExynosDisplay. But ExynosMPP still have pointer of deleted layer object in mAssignedSource. So when validateDisplay called, it refers the freed memory in resetAssignedState() layer->resetAssignedResource() is added before delete layer object so that remove layer info in ExynosMPP. Bug: 264510390 Test: stop surfaceflinger by command "setprop ctl.stop surfaceflinger" Change-Id: I5191ae334c7566c8fe503c06784aae0e6be1ea81 (cherry picked from commit 261c8ec1328812c2e99e9cac86c635ba875990bb)
2023-05-16Merge "FBManager: use dedicated map for caching M2M secure layers" into ↵Midas Chien
udc-dev am: 90179609ed Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/google/graphics/common/+/23158888 Change-Id: I6fb1c4918f72534c0492ce694c85343370466a77 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-16Merge "FBManager: use dedicated map for caching M2M secure layers" into udc-devMidas Chien
2023-05-15Merge "libhwc2.1: update IDisplay version to 8" into udc-dev am: 61e9eb75caWeizhung Ding
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/google/graphics/common/+/23162701 Change-Id: Iac3c41e8da399b534b158f524c3fba8f2bbaea02 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-15Merge "libhwc2.1: update IDisplay version to 8" into udc-devWeizhung Ding
2023-05-15FBManager: use dedicated map for caching M2M secure layersMidas Chien
The quota of secure memory is rare and limited. HWC should release it once it is inused quickly. Itʼs easier to use a dedicated map to control the life cycle of cached M2M secure buffers. Bug: 278836996 Test: play secure video with various resolutions and rotate screen Test: play video with various resolutions and rotate screen Test: camera, record, chrome, AOD Change-Id: Ic7a83773b43fcd27737ff514cf67754fdb1750d0
2023-05-15libhwc2.1: disconnect link between plane and crtc after power on am: 72c453d6e9joenchen
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/google/graphics/common/+/22954325 Change-Id: I3ead375e4c9e3dd2d01c54df556667ec7366640f Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-15libhwc2.1: skip to disable unsupported plane am: 466f2a9cfeYongWook Shin
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/google/graphics/common/+/22963017 Change-Id: Ice2b65aaa9523a68e5fc5703a5960bc585352ebb Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-12libhwc2.1: disconnect link between plane and crtc after power onjoenchen
HWC cannot just assign a plane’s crtc from crtc-0 to crtc-1 directly, and it must turn off the plane first Bug: 277874775 Test: enable/disable DDC in translation app Change-Id: I7771821fc618528f63610449c506ed93ec8a8ddc
2023-05-12libhwc2.1: update IDisplay version to 8Weizhung Ding
Bug: 281630752 Test: build Change-Id: I2366eeb95fdf5767d75944d65061af25d39c78a4
2023-05-10libhwc2.1: skip to disable unsupported planeYongWook Shin
When disable unused planes, the planes which are unsupported by CRTC should be skipped to avoid abnormal configurations. Bug: 238373481 Bug: 263989425 Test: power on/off display Change-Id: Ib14f03446b855d87c5f660775c6e803abb596339 Signed-off-by: YongWook Shin <yongwook.shin@samsung.com> Signed-off-by: Petri Gynther <pgynther@google.com> Merged-In: I627afe439e0a744532ff3aa4cf094dc4fd9d4b1d
2023-05-10Merge "libhwc2.1: skip async_off if multiple displays are enabled" into ↵Weizhung Ding
udc-dev am: 25001f3ea7 Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/google/graphics/common/+/22873650 Change-Id: I60dbef2a3282f944a1067bdf9af189d1c3c8f767 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-10Merge "libhwc2.1: skip async_off if multiple displays are enabled" into udc-devWeizhung Ding
2023-05-10libhwc2.1: skip async_off if multiple displays are enabledWeizhung Ding
Bug: 271818029 Test: display on/off Change-Id: Id1de11148e988fc3c6a831c40c6fc0de42aa04b8
2023-05-08libhwc2.1: add lock protection in checkBtsReassignResource am: d6bd3d5d55Midas Chien
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/google/graphics/common/+/23053818 Change-Id: I67c18d4bdbbadb9b868fb0709684294c005e4cbd Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-05-05libhwc2.1: add lock protection in checkBtsReassignResourceMidas Chien
Add mutex lock when accessing mLayers to avoid race condition. Bug: 271198385 Test: rr switch, AOD, video, camera Change-Id: I50985f896883e4001ffc08a582800ebde625fe97
2023-04-26libhwc2.1: actively set lhbm desired refresh rate during lhbm period am: ↵Shiyong Li
8878047697 Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/google/graphics/common/+/22540744 Change-Id: I028089ab9215114169ff440bbc22f154e4a814d7 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-26libhwc2.1: add getRefreshRate() and getVsyncPeriod() functions am: 8582373b32Shiyong Li
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/google/graphics/common/+/22862781 Change-Id: I9a80147a4936b6fc31d715bdebf64653fe056559 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-25libhwc2.1: actively set lhbm desired refresh rate during lhbm periodShiyong Li
- set lhbm desired refresh rate at enabling lhbm and restore SF desired one at disabling if needed. - always notify SF with it's desired Vsync if SF's refresh rate != lhbm's Bug: 250979028 Test: udfps auth with SmoothDisplay=on/off, check perfetto trace Signed-off-by: Shiyong Li <shiyongli@google.com> Change-Id: If011dbf12c1f979a50988cc375e74c7f53617d68
2023-04-25libhwc2.1: add getRefreshRate() and getVsyncPeriod() functionsShiyong Li
Bug: 250979028 Change-Id: I66c9fbc05b42c6376ec852ee1555b2655ea9635b Signed-off-by: Shiyong Li <shiyongli@google.com>
2023-04-10Fix formatting when _FILE_OFFSET_BITS=64 am: 1d1544b52cColin Cross
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/google/graphics/common/+/22400284 Change-Id: I6eb99ff9ec863d860d7a6ad50798b9c8dfcc9a69 Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-10Fix formatting when _FILE_OFFSET_BITS=64Colin Cross
_FILE_OFFSET_BITS=64 can change off_t to be larger than a long. Cast to intmax_t and print with %jd or switch to ptrdiff_t and print with %td. Bug: 275601166 Test: builds Change-Id: I011cc53f108aaa7f773b0d09511728864f602429
2023-03-31Merge "Remove references to MULTI_THREADED_PRESENT" into udc-dev am: 775f35376eBrian Johnson
Original change: https://googleplex-android-review.googlesource.com/c/platform/hardware/google/graphics/common/+/22238687 Change-Id: I2775a5189e7e43dbf9a3ee6a8a4034e3ebb47bfe Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-31Merge "Remove references to MULTI_THREADED_PRESENT" into udc-devBrian Johnson
2023-03-23Remove references to MULTI_THREADED_PRESENTLeon Scroggins III
This feature isn't yet used, so remove it until we actually use it in the next release. Bug: 274954820 Test: make Change-Id: I960b3cce292e07b3b7e601e2bdd5019acf34dafc