summaryrefslogtreecommitdiff
path: root/power-libperfmgr
diff options
context:
space:
mode:
authorJimmy Shiu <jimmyshiu@google.com>2021-07-27 10:45:07 +0800
committerChris Fries <cfries@google.com>2021-08-02 17:36:07 +0000
commit0bcb7660c1b75f3d87b6026a11d80ec3d47b30aa (patch)
tree5787fbc0785138ebc5ff50729ce2b6b232e98350 /power-libperfmgr
parentec2ace918f9a9d59bb764aa50af0104fa5d4e0c5 (diff)
downloadpixel-0bcb7660c1b75f3d87b6026a11d80ec3d47b30aa.tar.gz
ADPF: fix no boost due to the big negative ILowLimit
Tuning the PID control loop as the below: ILowLimit: -512 -> -120 kPOver: 2->5 kPunder: 2->3 kDOver: 1->5 kDUnder: 0->0 Bug: 193165816 Test: cuj/youtuble, cuj/facebook, PtsUiBench Change-Id: Icc1a9a8d04004f60e47cabb7c4131ea67585be53
Diffstat (limited to 'power-libperfmgr')
-rw-r--r--power-libperfmgr/aidl/PowerHintSession.cpp8
1 files changed, 4 insertions, 4 deletions
diff --git a/power-libperfmgr/aidl/PowerHintSession.cpp b/power-libperfmgr/aidl/PowerHintSession.cpp
index 053aeda2..6b65fa69 100644
--- a/power-libperfmgr/aidl/PowerHintSession.cpp
+++ b/power-libperfmgr/aidl/PowerHintSession.cpp
@@ -94,10 +94,10 @@ static double getDoubleProperty(const char *prop, double value) {
return value;
}
-static double sPidPOver = getDoubleProperty(kPowerHalAdpfPidPOver, 2.0);
-static double sPidPUnder = getDoubleProperty(kPowerHalAdpfPidPUnder, 2.0);
+static double sPidPOver = getDoubleProperty(kPowerHalAdpfPidPOver, 5.0);
+static double sPidPUnder = getDoubleProperty(kPowerHalAdpfPidPUnder, 3.0);
static double sPidI = getDoubleProperty(kPowerHalAdpfPidI, 0.001);
-static double sPidDOver = getDoubleProperty(kPowerHalAdpfPidDOver, 100.0);
+static double sPidDOver = getDoubleProperty(kPowerHalAdpfPidDOver, 500.0);
static double sPidDUnder = getDoubleProperty(kPowerHalAdpfPidDUnder, 0.0);
static const int64_t sPidIInit =
(sPidI == 0) ? 0
@@ -112,7 +112,7 @@ static const int64_t sPidIHighLimit =
static const int64_t sPidILowLimit =
(sPidI == 0) ? 0
: static_cast<int64_t>(::android::base::GetIntProperty<int64_t>(
- kPowerHalAdpfPidILowLimit, -512) /
+ kPowerHalAdpfPidILowLimit, -120) /
sPidI);
static const int32_t sUclampMinHighLimit =
::android::base::GetUintProperty<uint32_t>(kPowerHalAdpfUclampMinHighLimit, 512);