diff options
| author | XiaoFeng <fengx.xiao@intel.com> | 2012-10-15 13:52:30 +0800 |
|---|---|---|
| committer | Patrick Tjin <pattjin@google.com> | 2014-07-21 22:03:39 -0700 |
| commit | 107bd5628b58f6869a2b7fc0580f1c953cb9eb42 (patch) | |
| tree | ee8c49890b0c6a82d74c8a63a55179fa77faa12c | |
| parent | deda6f15f609a7a778f9067256d5922fe84dea3d (diff) | |
| download | wrs_omxil_core-107bd5628b58f6869a2b7fc0580f1c953cb9eb42.tar.gz | |
Fix code defect which found through the code coverage
BZ: 62170
Fix nIndex out of boundary in componentRoleEnum function.
Change-Id: I665df1c7ec7a205d139ab5d9ab29b4ab03b3b207
Signed-off-by: XiaoFeng <fengx.xiao@intel.com>
Reviewed-on: http://android.intel.com:8080/70008
Reviewed-by: Liang, Dan <dan.liang@intel.com>
Reviewed-by: Wang, Yi A <yi.a.wang@intel.com>
Reviewed-by: Chen, Tianmi <tianmi.chen@intel.com>
Reviewed-by: Feng, Wei <wei.feng@intel.com>
Reviewed-by: Qiu, Junhai <junhai.qiu@intel.com>
Reviewed-by: Shi, PingX <pingx.shi@intel.com>
Tested-by: Shi, PingX <pingx.shi@intel.com>
Reviewed-by: buildbot <buildbot@intel.com>
Tested-by: buildbot <buildbot@intel.com>
| -rw-r--r-- | base/src/componentbase.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/base/src/componentbase.cpp b/base/src/componentbase.cpp index 31aa979..f98741d 100644 --- a/base/src/componentbase.cpp +++ b/base/src/componentbase.cpp @@ -1256,7 +1256,7 @@ OMX_ERRORTYPE ComponentBase::CBaseComponentRoleEnum( if (hComponent != (OMX_HANDLETYPE *)this->handle) return OMX_ErrorBadParameter; - if (nIndex > nr_roles) + if (nIndex >= nr_roles) return OMX_ErrorBadParameter; strncpy((char *)cRole, (const char *)roles[nIndex], |