Use -Werror in hardware/qcom/gps

* Suppress existing warnings.

Bug: 66996870
Test: build with WITH_TIDY=1
Change-Id: I1e78fe7898fc8b1a4a32434f8460e22a83bcec9d

7 files changed, 46 insertions, 6 deletions

diff --git a/msm8998/android/Android.mk b/msm8998/android/Android.mk
index 365929a..6d70507 100644
--- a/msm8998/android/Android.mk
+++ b/msm8998/android/Android.mk
@@ -1,10 +1,18 @@
 LOCAL_PATH := $(call my-dir)
 
+qcom_qti_common_cflags := \
+    -Wall \
+    -Werror \
+    -Wno-format \
+    -Wno-unused-parameter \
+    -Wno-unused-private-field \
+
 include $(CLEAR_VARS)
 LOCAL_MODULE := android.hardware.gnss@1.0-impl-qti
 LOCAL_VENDOR_MODULE := true
 LOCAL_MODULE_OWNER := qti
 LOCAL_MODULE_RELATIVE_PATH := hw
+LOCAL_CFLAGS := $(qcom_qti_common_cflags)
 LOCAL_SRC_FILES := \
     AGnss.cpp \
     Gnss.cpp \
@@ -53,6 +61,7 @@ LOCAL_MODULE_OWNER := qti
 LOCAL_MODULE_RELATIVE_PATH := hw
 LOCAL_INIT_RC := android.hardware.gnss@1.0-service-qti.rc
 LOCAL_VENDOR_MODULE := true
+LOCAL_CFLAGS := $(qcom_qti_common_cflags)
 LOCAL_SRC_FILES := \
     service.cpp \
 
diff --git a/msm8998/core/Android.mk b/msm8998/core/Android.mk
index b8d497e..1bcc16b 100644
--- a/msm8998/core/Android.mk
+++ b/msm8998/core/Android.mk
@@ -34,8 +34,19 @@ LOCAL_SRC_FILES += \
     SystemStatus.cpp
 
 LOCAL_CFLAGS += \
-     -fno-short-enums \
-     -D_ANDROID_
+    -fno-short-enums \
+    -D_ANDROID_ \
+    -Wall \
+    -Werror \
+    -Wno-format \
+    -Wno-sign-compare \
+    -Wno-unneeded-internal-declaration \
+    -Wno-unused-const-variable \
+    -Wno-unused-parameter \
+
+LOCAL_CPPFLAGS += \
+    -Wno-overloaded-virtual \
+    -Wno-reorder \
 
 LOCAL_C_INCLUDES:= \
     $(TARGET_OUT_HEADERS)/gps.utils \
diff --git a/msm8998/gnss/Android.mk b/msm8998/gnss/Android.mk
index fd8ceaa..541f4de 100644
--- a/msm8998/gnss/Android.mk
+++ b/msm8998/gnss/Android.mk
@@ -24,7 +24,10 @@ LOCAL_SRC_FILES += \
     Agps.cpp
 
 LOCAL_CFLAGS += \
-     -fno-short-enums \
+    -fno-short-enums \
+    -Wall \
+    -Werror \
+    -Wno-format \
 
 ifeq ($(TARGET_BUILD_VARIANT),user)
    LOCAL_CFLAGS += -DTARGET_BUILD_VARIANT_USER
diff --git a/msm8998/location/Android.mk b/msm8998/location/Android.mk
index b414338..c8e462e 100644
--- a/msm8998/location/Android.mk
+++ b/msm8998/location/Android.mk
@@ -22,7 +22,10 @@ LOCAL_SRC_FILES += \
     LocationAPIClientBase.cpp
 
 LOCAL_CFLAGS += \
-     -fno-short-enums
+    -fno-short-enums \
+    -Wall \
+    -Werror \
+    -Wno-unused-variable \
 
 LOCAL_C_INCLUDES:= \
     $(TARGET_OUT_HEADERS)/gps.utils
diff --git a/msm8998/utils/Android.mk b/msm8998/utils/Android.mk
index ff18f2f..3b1796a 100644
--- a/msm8998/utils/Android.mk
+++ b/msm8998/utils/Android.mk
@@ -30,8 +30,16 @@ LOCAL_SRC_FILES += \
 
 # Flag -std=c++11 is not accepted by compiler when LOCAL_CLANG is set to true
 LOCAL_CFLAGS += \
-     -fno-short-enums \
-     -D_ANDROID_
+    -fno-short-enums \
+    -D_ANDROID_ \
+    -Wall \
+    -Werror \
+    -Wno-macro-redefined \
+    -Wno-missing-braces \
+    -Wno-missing-field-initializers \
+    -Wno-null-conversion \
+    -Wno-unused-parameter \
+    -Wno-unused-variable \
 
 ifeq ($(TARGET_BUILD_VARIANT),user)
    LOCAL_CFLAGS += -DTARGET_BUILD_VARIANT_USER
diff --git a/msm8998/utils/platform_lib_abstractions/loc_pla/src/Android.mk b/msm8998/utils/platform_lib_abstractions/loc_pla/src/Android.mk
index 0d2afe7..87d5a1e 100644
--- a/msm8998/utils/platform_lib_abstractions/loc_pla/src/Android.mk
+++ b/msm8998/utils/platform_lib_abstractions/loc_pla/src/Android.mk
@@ -23,6 +23,9 @@ LOCAL_SRC_FILES += \
 LOCAL_CFLAGS += \
      -fno-short-enums \
      -D_ANDROID_ \
+     -Wall \
+     -Werror \
+     -Wno-macro-redefined \
      -std=c++11
 
 ## Includes
diff --git a/msm8998/utils/platform_lib_abstractions/loc_stub/src/Android.mk b/msm8998/utils/platform_lib_abstractions/loc_stub/src/Android.mk
index 0b1132c..0208f7f 100644
--- a/msm8998/utils/platform_lib_abstractions/loc_stub/src/Android.mk
+++ b/msm8998/utils/platform_lib_abstractions/loc_stub/src/Android.mk
@@ -22,6 +22,9 @@ LOCAL_SRC_FILES += \
 LOCAL_CFLAGS += \
      -fno-short-enums \
      -D_ANDROID_ \
+     -Wall \
+     -Werror \
+     -Wno-unused-parameter \
      -std=c++11