diff options
| author | Priyanka Gujjula <pgujjula@codeaurora.org> | 2019-10-22 14:55:26 +0530 |
|---|---|---|
| committer | android-build-team Robot <android-build-team-robot@google.com> | 2020-02-11 23:57:07 +0000 |
| commit | c09a90b3da06a27584e9351e5c7a0d7c6bedd3d6 (patch) | |
| tree | c5dc9195f7479351ef97a702ba8403c37df5d406 | |
| parent | b0efeb18b5983ae92094a062ca6615f646ecf6db (diff) | |
| download | media-c09a90b3da06a27584e9351e5c7a0d7c6bedd3d6.tar.gz | |
vdec: Set correct output buffer size: dynamic meta mode
When frameworks queries for output buffer size on
decoder via OMX_IndexParamPortDefinition, expectation
is to return metadata buffer size instead of YUV
buffer size in dynamic metadata mode.
Test: CtsMediaTestCases & CtsVideoTestCases pass
Bug: 147104052
Change-Id: Ica54841cbc81b29c4b3bfa0b58f94a0f82de300b
(cherry picked from commit 4c2000cb4ea3862d2183cd6ecb223446b40fa174)
| -rw-r--r-- | mm-video-v4l2/vidc/vdec/src/omx_vdec_v4l2.cpp | 14 |
1 files changed, 10 insertions, 4 deletions
diff --git a/mm-video-v4l2/vidc/vdec/src/omx_vdec_v4l2.cpp b/mm-video-v4l2/vidc/vdec/src/omx_vdec_v4l2.cpp index af9125f1..8eb30c3f 100644 --- a/mm-video-v4l2/vidc/vdec/src/omx_vdec_v4l2.cpp +++ b/mm-video-v4l2/vidc/vdec/src/omx_vdec_v4l2.cpp @@ -11375,8 +11375,13 @@ OMX_BUFFERHEADERTYPE* omx_vdec::allocate_color_convert_buf::get_il_buf_hdr() { bool status = true; pthread_mutex_lock(&omx->c_lock); + /* Whenever port mode is set to kPortModeDynamicANWBuffer, Video Frameworks + always uses VideoNativeMetadata and OMX receives buffer type as + grallocsource via storeMetaDataInBuffers_l API. The buffer_size + will be communicated to frameworks via IndexParamPortdefinition. */ if (!enabled) - buffer_size = omx->drv_ctx.op_buf.buffer_size; + buffer_size = omx->dynamic_buf_mode ? sizeof(struct VideoNativeMetadata) : + omx->drv_ctx.op_buf.buffer_size; else { buffer_size = c2dcc.getBuffSize(C2D_OUTPUT); } @@ -11385,9 +11390,10 @@ OMX_BUFFERHEADERTYPE* omx_vdec::allocate_color_convert_buf::get_il_buf_hdr() } OMX_ERRORTYPE omx_vdec::allocate_color_convert_buf::set_buffer_req( - OMX_U32 buffer_size, OMX_U32 actual_count) { - OMX_U32 expectedSize = enabled ? buffer_size_req : omx->drv_ctx.op_buf.buffer_size; - + OMX_U32 buffer_size, OMX_U32 actual_count) +{ + OMX_U32 expectedSize = is_color_conversion_enabled() ? buffer_size_req : omx->dynamic_buf_mode ? + sizeof(struct VideoDecoderOutputMetaData) : omx->drv_ctx.op_buf.buffer_size; if (buffer_size < expectedSize) { DEBUG_PRINT_ERROR("OP Requirements: Client size(%u) insufficient v/s requested(%u)", buffer_size, expectedSize); |